A few fixes around the object code reading test. The first patch
appears to be unrelated, but in this case the data symbol test is
broken on Arm N1 by the second commit.
Changes since V1:
* Put data symbol test fix first so that bisecting still works on N1
* Instead of skipping "test data symbol" on N1, add some noise into
the loop.
* Add a commit to replace the only usage of lscpu in the tests with
uname
James Clark (4):
perf tests: Make "test data symbol" more robust on Neoverse N1
perf tests: Apply attributes to all events in object code reading test
perf map: Remove kernel map before updating start and end addresses
perf tests: Remove dependency on lscpu
tools/perf/tests/code-reading.c | 10 +++++-----
tools/perf/tests/shell/test_arm_callgraph_fp.sh | 4 +++-
tools/perf/tests/workloads/datasym.c | 16 ++++++++++++++++
tools/perf/util/machine.c | 2 +-
4 files changed, 25 insertions(+), 7 deletions(-)
--
2.34.1
On Wed, Apr 10, 2024 at 3:35 AM James Clark <[email protected]> wrote:
>
> A few fixes around the object code reading test. The first patch
> appears to be unrelated, but in this case the data symbol test is
> broken on Arm N1 by the second commit.
>
> Changes since V1:
> * Put data symbol test fix first so that bisecting still works on N1
> * Instead of skipping "test data symbol" on N1, add some noise into
> the loop.
> * Add a commit to replace the only usage of lscpu in the tests with
> uname
>
> James Clark (4):
> perf tests: Make "test data symbol" more robust on Neoverse N1
> perf tests: Apply attributes to all events in object code reading test
> perf map: Remove kernel map before updating start and end addresses
> perf tests: Remove dependency on lscpu
Reviewed-by: Ian Rogers <[email protected]>
Thanks,
Ian
> tools/perf/tests/code-reading.c | 10 +++++-----
> tools/perf/tests/shell/test_arm_callgraph_fp.sh | 4 +++-
> tools/perf/tests/workloads/datasym.c | 16 ++++++++++++++++
> tools/perf/util/machine.c | 2 +-
> 4 files changed, 25 insertions(+), 7 deletions(-)
>
> --
> 2.34.1
>
Hello,
On Wed, Apr 10, 2024 at 3:35 AM James Clark <[email protected]> wrote:
>
> A few fixes around the object code reading test. The first patch
> appears to be unrelated, but in this case the data symbol test is
> broken on Arm N1 by the second commit.
>
> Changes since V1:
> * Put data symbol test fix first so that bisecting still works on N1
> * Instead of skipping "test data symbol" on N1, add some noise into
> the loop.
> * Add a commit to replace the only usage of lscpu in the tests with
> uname
>
> James Clark (4):
> perf tests: Make "test data symbol" more robust on Neoverse N1
> perf tests: Apply attributes to all events in object code reading test
> perf map: Remove kernel map before updating start and end addresses
> perf tests: Remove dependency on lscpu
Acked-by: Namhyung Kim <[email protected]>
Thanks,
Namhyung
On Wed, Apr 10, 2024 at 09:17:04AM -0700, Ian Rogers wrote:
> On Wed, Apr 10, 2024 at 3:35 AM James Clark <[email protected]> wrote:
> >
> > A few fixes around the object code reading test. The first patch
> > appears to be unrelated, but in this case the data symbol test is
> > broken on Arm N1 by the second commit.
> >
> > Changes since V1:
> > * Put data symbol test fix first so that bisecting still works on N1
> > * Instead of skipping "test data symbol" on N1, add some noise into
> > the loop.
> > * Add a commit to replace the only usage of lscpu in the tests with
> > uname
> >
> > James Clark (4):
> > perf tests: Make "test data symbol" more robust on Neoverse N1
> > perf tests: Apply attributes to all events in object code reading test
> > perf map: Remove kernel map before updating start and end addresses
> > perf tests: Remove dependency on lscpu
>
> Reviewed-by: Ian Rogers <[email protected]>
Thanks, applied to perf-tools-next,
- Arnaldo