Replace 'greceful' with 'graceful'.
Signed-off-by: Shi-Sheng Yang <[email protected]>
---
net/mptcp/subflow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/mptcp/subflow.c b/net/mptcp/subflow.c
index 6042a47da61b..c794288f6224 100644
--- a/net/mptcp/subflow.c
+++ b/net/mptcp/subflow.c
@@ -1234,7 +1234,7 @@ static void mptcp_subflow_fail(struct mptcp_sock *msk, struct sock *ssk)
struct mptcp_subflow_context *subflow = mptcp_subflow_ctx(ssk);
unsigned long fail_tout;
- /* greceful failure can happen only on the MPC subflow */
+ /* graceful failure can happen only on the MPC subflow */
if (WARN_ON_ONCE(ssk != READ_ONCE(msk->first)))
return;
--
2.34.1
On Tue, Apr 30, 2024 at 06:50:33AM +0800, Shi-Sheng Yang wrote:
> Replace 'greceful' with 'graceful'.
>
> Signed-off-by: Shi-Sheng Yang <[email protected]>
Hi Shi-Sheng Yang,
Elsewhere in the same file 'earlier' is mispelt as 'eariler'.
Could you consider fixing that too?
Better still, could you consider running codespell over
net/mptcp/ and fixing (the non false-positives) that it flags?
If you do repost then I think an appropriate prefix
would be 'mctp: ' rather than 'mctp: subflow.c ',
as this follows the pattern in git history.
And I think the target tree should be net-next.
That is, the patch should be based on net-next and
it should be designated in the subject.
e.g. Subject: [PATCH v2 net-next] mptcp: fix typos in comments
Lastly, please keep in mind that 24h should elapse
before posting a new version.
Link: https://docs.kernel.org/process/maintainer-netdev.html
..
On Tue, Apr 30, 2024 at 07:00:57PM +0100, Simon Horman wrote:
> On Tue, Apr 30, 2024 at 06:50:33AM +0800, Shi-Sheng Yang wrote:
> > Replace 'greceful' with 'graceful'.
> >
> > Signed-off-by: Shi-Sheng Yang <[email protected]>
>
> Hi Shi-Sheng Yang,
>
> Elsewhere in the same file 'earlier' is mispelt as 'eariler'.
> Could you consider fixing that too?
>
> Better still, could you consider running codespell over
> net/mptcp/ and fixing (the non false-positives) that it flags?
>
> If you do repost then I think an appropriate prefix
> would be 'mctp: ' rather than 'mctp: subflow.c ',
> as this follows the pattern in git history.
>
> And I think the target tree should be net-next.
> That is, the patch should be based on net-next and
> it should be designated in the subject.
>
> e.g. Subject: [PATCH v2 net-next] mptcp: fix typos in comments
>
> Lastly, please keep in mind that 24h should elapse
> before posting a new version.
>
> Link: https://docs.kernel.org/process/maintainer-netdev.html
>
> ...
>
Hi Shi-Sheng,
I also noticed that the email you sent and the email from SoB are not
the same, which causes checkpatch.pl to complain about the following
warning:
WARNING: From:/Signed-off-by: email address mismatch: 'From: Shi-ShengYang [email protected]' != 'Signed-off-by: Shi-Sheng Yang [email protected]'
total: 0 errors, 1 warning, 0 checks, 8 lines checked
Could you please address this issue in the next version as well?
Regards,
Kuan-Wei