2015-05-07 15:11:12

by Michal Suchanek

Subject: problem building on ARM with XEN enabled

Hello,

it appears the Linus master tree fails to build on ARM with XEN enabled.

Since commit 2b953a5e9 xen: Suspend ticks on all CPUs during suspend

provides the suspend function only for x86 this is not surprising.

I currently don't use XEN yet but building with XEN enabled was not a
problem in the past so this looks like a regression to me.

Thanks

Michal

2015-05-07 15:26:42

by Boris Ostrovsky

Subject: Re: problem building on ARM with XEN enabled

On 05/07/2015 11:10 AM, Michal Suchanek wrote:
> Hello,
>
> it appears the Linus master tree fails to build on ARM with XEN enabled.
>
> Since commit 2b953a5e9 xen: Suspend ticks on all CPUs during suspend
>
> provides the suspend function only for x86 this is not surprising.
>
> I currently don't use XEN yet but building with XEN enabled was not a
> problem in the past so this looks like a regression to me.



(+Stefano)

Does this fix it:

diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
index 224081c..7d0f070 100644
--- a/arch/arm/xen/enlighten.c
+++ b/arch/arm/xen/enlighten.c
@@ -272,6 +272,7 @@ void xen_arch_pre_suspend(void) { }
void xen_arch_post_suspend(int suspend_cancelled) { }
void xen_timer_resume(void) { }
void xen_arch_resume(void) { }
+void xen_arch_suspend(void) { }


/* In the hypervisor.S file. */

2015-05-07 16:40:47

by Stefano Stabellini

Subject: Re: problem building on ARM with XEN enabled

On Thu, 7 May 2015, Boris Ostrovsky wrote:
> On 05/07/2015 11:10 AM, Michal Suchanek wrote:
> > Hello,
> >
> > it appears the Linus master tree fails to build on ARM with XEN enabled.
> >
> > Since commit 2b953a5e9 xen: Suspend ticks on all CPUs during suspend
> >
> > provides the suspend function only for x86 this is not surprising.
> >
> > I currently don't use XEN yet but building with XEN enabled was not a
> > problem in the past so this looks like a regression to me.
>
>
>
> (+Stefano)
>
> Does this fix it:

Yes, it does. Please go ahead and add it to xentip.


> diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
> index 224081c..7d0f070 100644
> --- a/arch/arm/xen/enlighten.c
> +++ b/arch/arm/xen/enlighten.c
> @@ -272,6 +272,7 @@ void xen_arch_pre_suspend(void) { }
> void xen_arch_post_suspend(int suspend_cancelled) { }
> void xen_timer_resume(void) { }
> void xen_arch_resume(void) { }
> +void xen_arch_suspend(void) { }
>
>
> /* In the hypervisor.S file. */
>