2016-11-10 20:16:16

by Julia Lawall

Subject: [PATCH] driver-core: fix odd_ptr_err.cocci warnings

PTR_ERR should access the value just tested by IS_ERR

Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci

CC: Dmitry Torokhov <[email protected]>
Signed-off-by: Julia Lawall <[email protected]>
Signed-off-by: Fengguang Wu <[email protected]>
---

0-day warning related to the following commit:

tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git driver-core-testing
head: dfea747d2aba77443acf7ce6fa37caa729bd034c
commit: 79543cf2b18ea4a35f8864849d7ad8882ea8a23d [10/14] driver-core: add test module for asynchronous probing

I haven't checked the context in detail.


test_async_driver_probe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/base/test/test_async_driver_probe.c
+++ b/drivers/base/test/test_async_driver_probe.c
@@ -119,7 +119,7 @@ static int __init test_async_probe_init(
sync_dev_1 = platform_device_register_simple("test_sync_driver", 1,
NULL, 0);
if (IS_ERR(async_dev_1)) {
- error = PTR_ERR(sync_dev_1);
+ error = PTR_ERR(async_dev_1);
pr_err("failed to create sync_dev_1: %d", error);
goto err_unregister_sync_driver;
}

2016-11-10 20:19:41

by Dmitry Torokhov

Subject: Re: [PATCH] driver-core: fix odd_ptr_err.cocci warnings

[ resending as plain text ]

On Thu, Nov 10, 2016 at 12:18 PM, Dmitry Torokhov <[email protected]> wrote:
>
>
> On Thu, Nov 10, 2016 at 12:16 PM, Julia Lawall <[email protected]> wrote:
>>
>> PTR_ERR should access the value just tested by IS_ERR
>>
>> Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
>>
>> CC: Dmitry Torokhov <[email protected]>
>> Signed-off-by: Julia Lawall <[email protected]>
>> Signed-off-by: Fengguang Wu <[email protected]>
>> ---
>>
>> 0-day warning related to the following commit:
>>
>> tree:
>> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
>> driver-core-testing
>> head: dfea747d2aba77443acf7ce6fa37caa729bd034c
>> commit: 79543cf2b18ea4a35f8864849d7ad8882ea8a23d [10/14] driver-core: add
>> test module for asynchronous probing
>>
>> I haven't checked the context in detail.
>>
>>
>> test_async_driver_probe.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- a/drivers/base/test/test_async_driver_probe.c
>> +++ b/drivers/base/test/test_async_driver_probe.c
>> @@ -119,7 +119,7 @@ static int __init test_async_probe_init(
>> sync_dev_1 = platform_device_register_simple("test_sync_driver",
>> 1,
>> NULL, 0);
>> if (IS_ERR(async_dev_1)) {
>> - error = PTR_ERR(sync_dev_1);
>> + error = PTR_ERR(async_dev_1);
>
>
> NAK. It should be "if (IS_ERR(sync_dev_1)) {"
>
>>
>> pr_err("failed to create sync_dev_1: %d", error);
>> goto err_unregister_sync_driver;
>> }
>
>

2016-11-10 20:22:34

by Julia Lawall

Subject: Re: [PATCH] driver-core: fix odd_ptr_err.cocci warnings

On Thu, 10 Nov 2016, Dmitry Torokhov wrote:

> [ resending as plain text ]
>
> On Thu, Nov 10, 2016 at 12:18 PM, Dmitry Torokhov <[email protected]> wrote:
> >
> >
> > On Thu, Nov 10, 2016 at 12:16 PM, Julia Lawall <[email protected]> wrote:
> >>
> >> PTR_ERR should access the value just tested by IS_ERR
> >>
> >> Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
> >>
> >> CC: Dmitry Torokhov <[email protected]>
> >> Signed-off-by: Julia Lawall <[email protected]>
> >> Signed-off-by: Fengguang Wu <[email protected]>
> >> ---
> >>
> >> 0-day warning related to the following commit:
> >>
> >> tree:
> >> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
> >> driver-core-testing
> >> head: dfea747d2aba77443acf7ce6fa37caa729bd034c
> >> commit: 79543cf2b18ea4a35f8864849d7ad8882ea8a23d [10/14] driver-core: add
> >> test module for asynchronous probing
> >>
> >> I haven't checked the context in detail.
> >>
> >>
> >> test_async_driver_probe.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> --- a/drivers/base/test/test_async_driver_probe.c
> >> +++ b/drivers/base/test/test_async_driver_probe.c
> >> @@ -119,7 +119,7 @@ static int __init test_async_probe_init(
> >> sync_dev_1 = platform_device_register_simple("test_sync_driver",
> >> 1,
> >> NULL, 0);
> >> if (IS_ERR(async_dev_1)) {
> >> - error = PTR_ERR(sync_dev_1);
> >> + error = PTR_ERR(async_dev_1);
> >
> >
> > NAK. It should be "if (IS_ERR(sync_dev_1)) {"

Indeed, I should have noticed that. Will you make the fix, or should I
revise the proposed patch?

julia

> >
> >>
> >> pr_err("failed to create sync_dev_1: %d", error);
> >> goto err_unregister_sync_driver;
> >> }
> >
> >
>