Fix most checkpatch.pl issues of type:
CHECK: Alignment should match open parenthesis
Signed-off-by: Gabriel Francisco Mandaji <[email protected]>
---
drivers/staging/comedi/drivers/cb_pcidas64.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c
index fdd81c3..631a703 100644
--- a/drivers/staging/comedi/drivers/cb_pcidas64.c
+++ b/drivers/staging/comedi/drivers/cb_pcidas64.c
@@ -2268,14 +2268,14 @@ static inline unsigned int dma_transfer_size(struct comedi_device *dev)
}
static u32 ai_convert_counter_6xxx(const struct comedi_device *dev,
- const struct comedi_cmd *cmd)
+ const struct comedi_cmd *cmd)
{
/* supposed to load counter with desired divisor minus 3 */
return cmd->convert_arg / TIMER_BASE - 3;
}
static u32 ai_scan_counter_6xxx(struct comedi_device *dev,
- struct comedi_cmd *cmd)
+ struct comedi_cmd *cmd)
{
u32 count;
@@ -2296,7 +2296,7 @@ static u32 ai_scan_counter_6xxx(struct comedi_device *dev,
}
static u32 ai_convert_counter_4020(struct comedi_device *dev,
- struct comedi_cmd *cmd)
+ struct comedi_cmd *cmd)
{
struct pcidas64_private *devpriv = dev->private;
unsigned int divisor;
--
1.9.1
On Tue, 10 Apr 2018, Gabriel Francisco Mandaji wrote:
> Fix most checkpatch.pl issues of type:
>
> CHECK: Alignment should match open parenthesis
>
> Signed-off-by: Gabriel Francisco Mandaji <[email protected]>
> ---
> drivers/staging/comedi/drivers/cb_pcidas64.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c
> index fdd81c3..631a703 100644
> --- a/drivers/staging/comedi/drivers/cb_pcidas64.c
> +++ b/drivers/staging/comedi/drivers/cb_pcidas64.c
> @@ -2268,14 +2268,14 @@ static inline unsigned int dma_transfer_size(struct comedi_device *dev)
> }
>
> static u32 ai_convert_counter_6xxx(const struct comedi_device *dev,
> - const struct comedi_cmd *cmd)
> + const struct comedi_cmd *cmd)
Someone has made the effort to put const on these parameters, but not on
the other similar functions. Perhaps this can be improved as well.
julia
> {
> /* supposed to load counter with desired divisor minus 3 */
> return cmd->convert_arg / TIMER_BASE - 3;
> }
>
> static u32 ai_scan_counter_6xxx(struct comedi_device *dev,
> - struct comedi_cmd *cmd)
> + struct comedi_cmd *cmd)
> {
> u32 count;
>
> @@ -2296,7 +2296,7 @@ static u32 ai_scan_counter_6xxx(struct comedi_device *dev,
> }
>
> static u32 ai_convert_counter_4020(struct comedi_device *dev,
> - struct comedi_cmd *cmd)
> + struct comedi_cmd *cmd)
> {
> struct pcidas64_private *devpriv = dev->private;
> unsigned int divisor;
> --
> 1.9.1
>
>
On 11/04/18 06:07, Julia Lawall wrote:
> On Tue, 10 Apr 2018, Gabriel Francisco Mandaji wrote:
[snip]
>> diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c
>> index fdd81c3..631a703 100644
>> --- a/drivers/staging/comedi/drivers/cb_pcidas64.c
>> +++ b/drivers/staging/comedi/drivers/cb_pcidas64.c
>> @@ -2268,14 +2268,14 @@ static inline unsigned int dma_transfer_size(struct comedi_device *dev)
>> }
>>
>> static u32 ai_convert_counter_6xxx(const struct comedi_device *dev,
>> - const struct comedi_cmd *cmd)
>> + const struct comedi_cmd *cmd)
>
> Someone has made the effort to put const on these parameters, but not on
> the other similar functions. Perhaps this can be improved as well.
Perhaps, but that should be in a separate patch.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <[email protected]> )=-
-=( Web: http://www.mev.co.uk/ )=-
On 10/04/18 23:50, Gabriel Francisco Mandaji wrote:
> Fix most checkpatch.pl issues of type:
>
> CHECK: Alignment should match open parenthesis
>
> Signed-off-by: Gabriel Francisco Mandaji <[email protected]>
> ---
> drivers/staging/comedi/drivers/cb_pcidas64.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c
> index fdd81c3..631a703 100644
> --- a/drivers/staging/comedi/drivers/cb_pcidas64.c
> +++ b/drivers/staging/comedi/drivers/cb_pcidas64.c
> @@ -2268,14 +2268,14 @@ static inline unsigned int dma_transfer_size(struct comedi_device *dev)
> }
>
> static u32 ai_convert_counter_6xxx(const struct comedi_device *dev,
> - const struct comedi_cmd *cmd)
> + const struct comedi_cmd *cmd)
> {
> /* supposed to load counter with desired divisor minus 3 */
> return cmd->convert_arg / TIMER_BASE - 3;
> }
>
> static u32 ai_scan_counter_6xxx(struct comedi_device *dev,
> - struct comedi_cmd *cmd)
> + struct comedi_cmd *cmd)
> {
> u32 count;
>
> @@ -2296,7 +2296,7 @@ static u32 ai_scan_counter_6xxx(struct comedi_device *dev,
> }
>
> static u32 ai_convert_counter_4020(struct comedi_device *dev,
> - struct comedi_cmd *cmd)
> + struct comedi_cmd *cmd)
> {
> struct pcidas64_private *devpriv = dev->private;
> unsigned int divisor;
>
Looks good, thanks. I guess the remaining case of open parentheses
alignment wasn't changed because that would exceed 80 columns.
Reviewed-by: Ian Abbott <[email protected]>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <[email protected]> )=-
-=( Web: http://www.mev.co.uk/ )=-
On Wed, Apr 11, 2018 at 10:18:38AM +0100, Ian Abbott wrote:
> On 10/04/18 23:50, Gabriel Francisco Mandaji wrote:
> >Fix most checkpatch.pl issues of type:
> >
> >CHECK: Alignment should match open parenthesis
> >---
> Looks good, thanks. I guess the remaining case of open parentheses
> alignment wasn't changed because that would exceed 80 columns.
Exactly. I wasn't sure whether it would be OK to use a temporary variable
to store the longest parameter on that line (devpriv->ai_buffer[devpriv->ai_dma_index]),
so I ended up fixing only the straightforward occurrences.
Thanks!