2023-04-18 06:12:30

by Qi Han

Subject: [PATCH] f2fs: remove unnessary comment in __may_age_extent_tree

This comment make no sense and is in the wrong place, so let's
remove it.

Signed-off-by: Qi Han <[email protected]>
---
fs/f2fs/extent_cache.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/fs/f2fs/extent_cache.c b/fs/f2fs/extent_cache.c
index 28b12553f2b3..1f6d7de35794 100644
--- a/fs/f2fs/extent_cache.c
+++ b/fs/f2fs/extent_cache.c
@@ -86,7 +86,6 @@ static bool __may_age_extent_tree(struct inode *inode)

if (!test_opt(sbi, AGE_EXTENT_CACHE))
return false;
- /* don't cache block age info for cold file */
if (is_inode_flag_set(inode, FI_COMPRESSED_FILE))
return false;
if (file_is_cold(inode))
--
2.39.0

2023-04-21 02:34:46

by Chao Yu

Subject: Re: [PATCH] f2fs: remove unnessary comment in __may_age_extent_tree

On 2023/4/18 14:09, Qi Han wrote:
> This comment make no sense and is in the wrong place, so let's
> remove it.
>
> Signed-off-by: Qi Han <[email protected]>
> ---
> fs/f2fs/extent_cache.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/f2fs/extent_cache.c b/fs/f2fs/extent_cache.c
> index 28b12553f2b3..1f6d7de35794 100644
> --- a/fs/f2fs/extent_cache.c
> +++ b/fs/f2fs/extent_cache.c
> @@ -86,7 +86,6 @@ static bool __may_age_extent_tree(struct inode *inode)
>
> if (!test_opt(sbi, AGE_EXTENT_CACHE))
> return false;
> - /* don't cache block age info for cold file */
> if (is_inode_flag_set(inode, FI_COMPRESSED_FILE))
> return false;

Should move it here instead of removal?

/* don't cache block age info for cold file */

> if (file_is_cold(inode))

2023-04-21 07:00:06

by Qi Han

Subject: [PATCH] f2fs: move wrong comment to right place in __may_age_extent_tree

This code is commented in the wrong place, let's move it to the right
place.

Signed-off-by: Qi Han <[email protected]>
---
fs/f2fs/extent_cache.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/f2fs/extent_cache.c b/fs/f2fs/extent_cache.c
index 28b12553f2b3..0ad769a822ac 100644
--- a/fs/f2fs/extent_cache.c
+++ b/fs/f2fs/extent_cache.c
@@ -86,9 +86,9 @@ static bool __may_age_extent_tree(struct inode *inode)

if (!test_opt(sbi, AGE_EXTENT_CACHE))
return false;
- /* don't cache block age info for cold file */
if (is_inode_flag_set(inode, FI_COMPRESSED_FILE))
return false;
+ /* don't cache block age info for cold file */
if (file_is_cold(inode))
return false;

--
2.39.0

2023-04-21 19:25:15

by Jaegeuk Kim

Subject: Re: [PATCH] f2fs: remove unnessary comment in __may_age_extent_tree

On 04/21, Chao Yu wrote:
> On 2023/4/18 14:09, Qi Han wrote:
> > This comment make no sense and is in the wrong place, so let's
> > remove it.
> >
> > Signed-off-by: Qi Han <[email protected]>
> > ---
> > fs/f2fs/extent_cache.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/fs/f2fs/extent_cache.c b/fs/f2fs/extent_cache.c
> > index 28b12553f2b3..1f6d7de35794 100644
> > --- a/fs/f2fs/extent_cache.c
> > +++ b/fs/f2fs/extent_cache.c
> > @@ -86,7 +86,6 @@ static bool __may_age_extent_tree(struct inode *inode)
> > if (!test_opt(sbi, AGE_EXTENT_CACHE))
> > return false;
> > - /* don't cache block age info for cold file */
> > if (is_inode_flag_set(inode, FI_COMPRESSED_FILE))
> > return false;
>
> Should move it here instead of removal?
>
> /* don't cache block age info for cold file */

Not worth to comment this, as the code is exactly saying that.

>
> > if (file_is_cold(inode))

2023-04-22 12:34:49

by Chao Yu

Subject: Re: [PATCH] f2fs: remove unnessary comment in __may_age_extent_tree

On 2023/4/22 3:20, Jaegeuk Kim wrote:
> On 04/21, Chao Yu wrote:
>> On 2023/4/18 14:09, Qi Han wrote:
>>> This comment make no sense and is in the wrong place, so let's
>>> remove it.
>>>
>>> Signed-off-by: Qi Han <[email protected]>
>>> ---
>>> fs/f2fs/extent_cache.c | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>> diff --git a/fs/f2fs/extent_cache.c b/fs/f2fs/extent_cache.c
>>> index 28b12553f2b3..1f6d7de35794 100644
>>> --- a/fs/f2fs/extent_cache.c
>>> +++ b/fs/f2fs/extent_cache.c
>>> @@ -86,7 +86,6 @@ static bool __may_age_extent_tree(struct inode *inode)
>>> if (!test_opt(sbi, AGE_EXTENT_CACHE))
>>> return false;
>>> - /* don't cache block age info for cold file */
>>> if (is_inode_flag_set(inode, FI_COMPRESSED_FILE))
>>> return false;
>>
>> Should move it here instead of removal?
>>
>> /* don't cache block age info for cold file */
>
> Not worth to comment this, as the code is exactly saying that.

Correct.

Reviewed-by: Chao Yu <[email protected]>

Thanks,

>
>>
>>> if (file_is_cold(inode))

2023-04-24 18:16:07

by patchwork-bot+f2fs

Subject: Re: [f2fs-dev] [PATCH] f2fs: remove unnessary comment in __may_age_extent_tree

Hello:

This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <[email protected]>:

On Tue, 18 Apr 2023 14:09:54 +0800 you wrote:
> This comment make no sense and is in the wrong place, so let's
> remove it.
>
> Signed-off-by: Qi Han <[email protected]>
> ---
> fs/f2fs/extent_cache.c | 1 -
> 1 file changed, 1 deletion(-)

Here is the summary with links:
- [f2fs-dev] f2fs: remove unnessary comment in __may_age_extent_tree
https://git.kernel.org/jaegeuk/f2fs/c/8375be2b6414

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html