2023-10-23 12:36:40

by Gradinariu, Ramona

Subject: [PATCH 3/3] dt-bindings: adis16460: Add 'spi-cs-inactive-delay-ns' property

Add 'spi-cs-inactive-delay-ns' property.

Signed-off-by: Ramona Gradinariu <[email protected]>
---
Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml b/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
index 4e43c80e5119..3691c0be4f9d 100644
--- a/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
+++ b/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
@@ -25,6 +25,11 @@ properties:

spi-cpol: true

+ spi-cs-inactive-delay-ns:
+ minimum: 16000
+ description:
+ If not explicitly set in the device tree, the driver will set it to 16us.
+
interrupts:
maxItems: 1

--
2.34.1

2023-10-23 13:26:04

by Krzysztof Kozlowski

Subject: Re: [PATCH 3/3] dt-bindings: adis16460: Add 'spi-cs-inactive-delay-ns' property

On 23/10/2023 14:35, Ramona Gradinariu wrote:
> Add 'spi-cs-inactive-delay-ns' property.

This we see from the diff. Commit should explain: Why?

>
> Signed-off-by: Ramona Gradinariu <[email protected]>
> ---
> Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml b/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
> index 4e43c80e5119..3691c0be4f9d 100644
> --- a/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
> +++ b/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
> @@ -25,6 +25,11 @@ properties:
>
> spi-cpol: true
>
> + spi-cs-inactive-delay-ns:
> + minimum: 16000
> + description:
> + If not explicitly set in the device tree, the driver will set it to 16us.

Why do you even need it here?

Best regards,
Krzysztof

2023-10-24 12:27:22

by Jonathan Cameron

Subject: Re: [PATCH 3/3] dt-bindings: adis16460: Add 'spi-cs-inactive-delay-ns' property

On Mon, 23 Oct 2023 15:22:30 +0200
Krzysztof Kozlowski <[email protected]> wrote:

> On 23/10/2023 14:35, Ramona Gradinariu wrote:
> > Add 'spi-cs-inactive-delay-ns' property.
>
> This we see from the diff. Commit should explain: Why?
>
> >
> > Signed-off-by: Ramona Gradinariu <[email protected]>
> > ---
> > Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml b/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
> > index 4e43c80e5119..3691c0be4f9d 100644
> > --- a/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
> > +++ b/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
> > @@ -25,6 +25,11 @@ properties:
> >
> > spi-cpol: true
> >
> > + spi-cs-inactive-delay-ns:
> > + minimum: 16000
> > + description:
> > + If not explicitly set in the device tree, the driver will set it to 16us.
>
> Why do you even need it here?

Along side that, if you have a default
default: xxxx
rather than in the description.


>
> Best regards,
> Krzysztof
>
>

2023-10-27 13:58:46

by Jonathan Cameron

Subject: Re: [PATCH 3/3] dt-bindings: adis16460: Add 'spi-cs-inactive-delay-ns' property

On Tue, 24 Oct 2023 13:27:05 +0100
Jonathan Cameron <[email protected]> wrote:

> On Mon, 23 Oct 2023 15:22:30 +0200
> Krzysztof Kozlowski <[email protected]> wrote:
>
> > On 23/10/2023 14:35, Ramona Gradinariu wrote:
> > > Add 'spi-cs-inactive-delay-ns' property.
> >
> > This we see from the diff. Commit should explain: Why?
> >
> > >
> > > Signed-off-by: Ramona Gradinariu <[email protected]>
> > > ---
> > > Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml | 5 +++++
> > > 1 file changed, 5 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml b/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
> > > index 4e43c80e5119..3691c0be4f9d 100644
> > > --- a/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
> > > +++ b/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
> > > @@ -25,6 +25,11 @@ properties:
> > >
> > > spi-cpol: true
> > >
> > > + spi-cs-inactive-delay-ns:
> > > + minimum: 16000
> > > + description:
> > > + If not explicitly set in the device tree, the driver will set it to 16us.
> >
> > Why do you even need it here?
>
> Along side that, if you have a default
> default: xxxx
> rather than in the description.

ah. I didn't get Krzysztof's reply to patch 1 for some reason where he already
said this...

Anyhow, I've nothing to add to comments on v2. Will aim to pick up v3.

>
>
> >
> > Best regards,
> > Krzysztof
> >
> >
>