2018-08-08 15:11:37

by zhong jiang

Subject: [PATCH] drivers/block/mtip32xx: remove the null check for debugfs_remove_recursive

debugfs_remove_recursive has taken null pointer into account. So it is
safe to drop the null check before calling the funtion.

Signed-off-by: zhong jiang <[email protected]>
---
drivers/block/mtip32xx/mtip32xx.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
index 2b6d6bc..d0666f5c 100644
--- a/drivers/block/mtip32xx/mtip32xx.c
+++ b/drivers/block/mtip32xx/mtip32xx.c
@@ -2574,8 +2574,7 @@ static int mtip_hw_debugfs_init(struct driver_data *dd)

static void mtip_hw_debugfs_exit(struct driver_data *dd)
{
- if (dd->dfs_node)
- debugfs_remove_recursive(dd->dfs_node);
+ debugfs_remove_recursive(dd->dfs_node);
}

/*
--
1.7.12.4

2018-08-08 15:18:13

by Jens Axboe

Subject: Re: [PATCH] drivers/block/mtip32xx: remove the null check for debugfs_remove_recursive

On 8/8/18 8:58 AM, zhong jiang wrote:
> debugfs_remove_recursive has taken null pointer into account. So it is
> safe to drop the null check before calling the funtion.

Applied, thanks.

--
Jens Axboe