2018-09-17 07:13:26

by Chao Yu

Subject: [PATCH] jfs: remove redundant dquot_initialize() in jfs_evict_inode()

We don't need to call dquot_initialize() twice in jfs_evict_inode(),
remove one of them for cleanup.

Signed-off-by: Chao Yu <[email protected]>
---
fs/jfs/inode.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/fs/jfs/inode.c b/fs/jfs/inode.c
index 054cc761b426..805ae9e8944a 100644
--- a/fs/jfs/inode.c
+++ b/fs/jfs/inode.c
@@ -166,7 +166,6 @@ void jfs_evict_inode(struct inode *inode)
/*
* Free the inode from the quota allocation.
*/
- dquot_initialize(inode);
dquot_free_inode(inode);
}
} else {
--
2.18.0.rc1

2018-09-20 14:21:08

by Chao Yu

Subject: Re: [PATCH] jfs: remove redundant dquot_initialize() in jfs_evict_inode()

Ping,

Any comments?

On 2018/9/17 15:12, Chao Yu wrote:
> We don't need to call dquot_initialize() twice in jfs_evict_inode(),
> remove one of them for cleanup.
>
> Signed-off-by: Chao Yu <[email protected]>
> ---
> fs/jfs/inode.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/jfs/inode.c b/fs/jfs/inode.c
> index 054cc761b426..805ae9e8944a 100644
> --- a/fs/jfs/inode.c
> +++ b/fs/jfs/inode.c
> @@ -166,7 +166,6 @@ void jfs_evict_inode(struct inode *inode)
> /*
> * Free the inode from the quota allocation.
> */
> - dquot_initialize(inode);
> dquot_free_inode(inode);
> }
> } else {
>

2018-09-20 14:25:53

by Dave Kleikamp

Subject: Re: [PATCH] jfs: remove redundant dquot_initialize() in jfs_evict_inode()

On 9/20/18 9:18 AM, Chao Yu wrote:
> Ping,
>
> Any comments?

Sorry for putting it off. It looks good to me. I'll push it upstream.

Thanks,
Dave

>
> On 2018/9/17 15:12, Chao Yu wrote:
>> We don't need to call dquot_initialize() twice in jfs_evict_inode(),
>> remove one of them for cleanup.
>>
>> Signed-off-by: Chao Yu <[email protected]>
>> ---
>> fs/jfs/inode.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/fs/jfs/inode.c b/fs/jfs/inode.c
>> index 054cc761b426..805ae9e8944a 100644
>> --- a/fs/jfs/inode.c
>> +++ b/fs/jfs/inode.c
>> @@ -166,7 +166,6 @@ void jfs_evict_inode(struct inode *inode)
>> /*
>> * Free the inode from the quota allocation.
>> */
>> - dquot_initialize(inode);
>> dquot_free_inode(inode);
>> }
>> } else {
>>

2018-09-20 14:33:31

by Chao Yu

Subject: Re: [PATCH] jfs: remove redundant dquot_initialize() in jfs_evict_inode()

On 2018/9/20 22:24, Dave Kleikamp wrote:
> On 9/20/18 9:18 AM, Chao Yu wrote:
>> Ping,
>>
>> Any comments?
>
> Sorry for putting it off. It looks good to me. I'll push it upstream.

Thanks for your review. ;)

Thanks,

>
> Thanks,
> Dave
>
>>
>> On 2018/9/17 15:12, Chao Yu wrote:
>>> We don't need to call dquot_initialize() twice in jfs_evict_inode(),
>>> remove one of them for cleanup.
>>>
>>> Signed-off-by: Chao Yu <[email protected]>
>>> ---
>>> fs/jfs/inode.c | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>> diff --git a/fs/jfs/inode.c b/fs/jfs/inode.c
>>> index 054cc761b426..805ae9e8944a 100644
>>> --- a/fs/jfs/inode.c
>>> +++ b/fs/jfs/inode.c
>>> @@ -166,7 +166,6 @@ void jfs_evict_inode(struct inode *inode)
>>> /*
>>> * Free the inode from the quota allocation.
>>> */
>>> - dquot_initialize(inode);
>>> dquot_free_inode(inode);
>>> }
>>> } else {
>>>