2 patches:
- some comments and making function static;
- improving speed of run_pack by checking runs in advance
Konstantin Komarov (2):
fs/ntfs3: Added comments to frecord functions
fs/ntfs3: Check possible errors in run_pack in advance
fs/ntfs3/bitmap.c | 3 +--
fs/ntfs3/frecord.c | 8 ++++----
fs/ntfs3/ntfs_fs.h | 1 -
fs/ntfs3/run.c | 41 +++++++++++++++++++++++------------------
4 files changed, 28 insertions(+), 25 deletions(-)
--
2.37.0
Hi Konstantin,
now that you have time to actively work on the ntfs3 driver again, can
you consider looking into converting the I/O path to iomap, as already
request during the merge? Getting drivers off the old buffer head based
I/O helpers is something we need to address in the coming years, so
any relatively simple and actually maintained file system would be a
good start.
On Wed, Jul 06, 2022 at 08:31:25PM +0300, Konstantin Komarov wrote:
> 2 patches:
> - some comments and making function static;
> - improving speed of run_pack by checking runs in advance
>
> Konstantin Komarov (2):
> fs/ntfs3: Added comments to frecord functions
> fs/ntfs3: Check possible errors in run_pack in advance
>
> fs/ntfs3/bitmap.c | 3 +--
> fs/ntfs3/frecord.c | 8 ++++----
> fs/ntfs3/ntfs_fs.h | 1 -
> fs/ntfs3/run.c | 41 +++++++++++++++++++++++------------------
> 4 files changed, 28 insertions(+), 25 deletions(-)
>
> --
> 2.37.0
>
---end quoted text---
On 7/7/22 07:42, Christoph Hellwig wrote:
> Hi Konstantin,
>
> now that you have time to actively work on the ntfs3 driver again, can
> you consider looking into converting the I/O path to iomap, as already
> request during the merge? Getting drivers off the old buffer head based
> I/O helpers is something we need to address in the coming years, so
> any relatively simple and actually maintained file system would be a
> good start.
>
> On Wed, Jul 06, 2022 at 08:31:25PM +0300, Konstantin Komarov wrote:
>> 2 patches:
>> - some comments and making function static;
>> - improving speed of run_pack by checking runs in advance
>>
>> Konstantin Komarov (2):
>> fs/ntfs3: Added comments to frecord functions
>> fs/ntfs3: Check possible errors in run_pack in advance
>>
>> fs/ntfs3/bitmap.c | 3 +--
>> fs/ntfs3/frecord.c | 8 ++++----
>> fs/ntfs3/ntfs_fs.h | 1 -
>> fs/ntfs3/run.c | 41 +++++++++++++++++++++++------------------
>> 4 files changed, 28 insertions(+), 25 deletions(-)
>>
>> --
>> 2.37.0
>>
> ---end quoted text---
Hi Christoph
I will look into converting the I/O path to iomap.
Thank you for reminding about it.
On Wed, Jul 13, 2022 at 07:41:58PM +0300, Konstantin Komarov wrote:
> I will look into converting the I/O path to iomap.
> Thank you for reminding about it.
If you have any questions or need help feel free to contact me.