This configuration option provides a misc device as an API to userspace.
Make this API usable without having to select the module as a transitive
dependency.
This also fixes an issue where localyesconfig would select
CONFIG_XEN_PRIVCMD=m because it was not visible and defaulted to
building as module.
Based-on-patch-by: Thomas Weißschuh <[email protected]>
Signed-off-by: Juergen Gross <[email protected]>
---
drivers/xen/Kconfig | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
index a1b11c62da9e..a2e91d3ca372 100644
--- a/drivers/xen/Kconfig
+++ b/drivers/xen/Kconfig
@@ -259,9 +259,14 @@ config XEN_SCSI_BACKEND
if guests need generic access to SCSI devices.
config XEN_PRIVCMD
- tristate
+ tristate "Xen hypercall passthrough driver"
depends on XEN
default m
+ help
+ The hypercall passthrough driver allows user land programs to perform
+ Xen hypercalls. This driver is normally required for systems running
+ as Dom0 to perform privileged operations, but in some disaggregated
+ Xen setups this driver might be needed for other domains, too.
config XEN_ACPI_PROCESSOR
tristate "Xen ACPI processor"
--
2.26.2
On 16.11.2021 15:33, Juergen Gross wrote:
> This configuration option provides a misc device as an API to userspace.
> Make this API usable without having to select the module as a transitive
> dependency.
>
> This also fixes an issue where localyesconfig would select
> CONFIG_XEN_PRIVCMD=m because it was not visible and defaulted to
> building as module.
>
> Based-on-patch-by: Thomas Weißschuh <[email protected]>
> Signed-off-by: Juergen Gross <[email protected]>
Reviewed-by: Jan Beulich <[email protected]>
> --- a/drivers/xen/Kconfig
> +++ b/drivers/xen/Kconfig
> @@ -259,9 +259,14 @@ config XEN_SCSI_BACKEND
> if guests need generic access to SCSI devices.
>
> config XEN_PRIVCMD
> - tristate
> + tristate "Xen hypercall passthrough driver"
> depends on XEN
> default m
> + help
> + The hypercall passthrough driver allows user land programs to perform
Maybe worth adding "privileged" here? Albeit of course that's different
from the use of the word ...
> + Xen hypercalls. This driver is normally required for systems running
> + as Dom0 to perform privileged operations, but in some disaggregated
... here, so there'd be a small risk of confusion.
Jan
> + Xen setups this driver might be needed for other domains, too.
>
> config XEN_ACPI_PROCESSOR
> tristate "Xen ACPI processor"
>
Thanks!
On 2021-11-16 15:33+0100, Juergen Gross wrote:
> This configuration option provides a misc device as an API to userspace.
> Make this API usable without having to select the module as a transitive
> dependency.
>
> This also fixes an issue where localyesconfig would select
> CONFIG_XEN_PRIVCMD=m because it was not visible and defaulted to
> building as module.
>
> Based-on-patch-by: Thomas Weißschuh <[email protected]>
> Signed-off-by: Juergen Gross <[email protected]>
> ---
> drivers/xen/Kconfig | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
> index a1b11c62da9e..a2e91d3ca372 100644
> --- a/drivers/xen/Kconfig
> +++ b/drivers/xen/Kconfig
> @@ -259,9 +259,14 @@ config XEN_SCSI_BACKEND
> if guests need generic access to SCSI devices.
>
> config XEN_PRIVCMD
> - tristate
> + tristate "Xen hypercall passthrough driver"
> depends on XEN
> default m
> + help
> + The hypercall passthrough driver allows user land programs to perform
> + Xen hypercalls. This driver is normally required for systems running
> + as Dom0 to perform privileged operations, but in some disaggregated
> + Xen setups this driver might be needed for other domains, too.
>
> config XEN_ACPI_PROCESSOR
> tristate "Xen ACPI processor"
> --
> 2.26.2
Reviewed-by: Thomas Weißschuh <[email protected]>
On 16.11.21 15:55, Jan Beulich wrote:
> On 16.11.2021 15:33, Juergen Gross wrote:
>> This configuration option provides a misc device as an API to userspace.
>> Make this API usable without having to select the module as a transitive
>> dependency.
>>
>> This also fixes an issue where localyesconfig would select
>> CONFIG_XEN_PRIVCMD=m because it was not visible and defaulted to
>> building as module.
>>
>> Based-on-patch-by: Thomas Weißschuh <[email protected]>
>> Signed-off-by: Juergen Gross <[email protected]>
>
> Reviewed-by: Jan Beulich <[email protected]>
>
>> --- a/drivers/xen/Kconfig
>> +++ b/drivers/xen/Kconfig
>> @@ -259,9 +259,14 @@ config XEN_SCSI_BACKEND
>> if guests need generic access to SCSI devices.
>>
>> config XEN_PRIVCMD
>> - tristate
>> + tristate "Xen hypercall passthrough driver"
>> depends on XEN
>> default m
>> + help
>> + The hypercall passthrough driver allows user land programs to perform
>
> Maybe worth adding "privileged" here? Albeit of course that's different
> from the use of the word ...
I guess you mean "... allows privileged user programs ..." (another
variant might be "The privileged hypercall passthrough ...")?
Juergen
On 16.11.2021 16:01, Juergen Gross wrote:
> On 16.11.21 15:55, Jan Beulich wrote:
>> On 16.11.2021 15:33, Juergen Gross wrote:
>>> This configuration option provides a misc device as an API to userspace.
>>> Make this API usable without having to select the module as a transitive
>>> dependency.
>>>
>>> This also fixes an issue where localyesconfig would select
>>> CONFIG_XEN_PRIVCMD=m because it was not visible and defaulted to
>>> building as module.
>>>
>>> Based-on-patch-by: Thomas Weißschuh <[email protected]>
>>> Signed-off-by: Juergen Gross <[email protected]>
>>
>> Reviewed-by: Jan Beulich <[email protected]>
>>
>>> --- a/drivers/xen/Kconfig
>>> +++ b/drivers/xen/Kconfig
>>> @@ -259,9 +259,14 @@ config XEN_SCSI_BACKEND
>>> if guests need generic access to SCSI devices.
>>>
>>> config XEN_PRIVCMD
>>> - tristate
>>> + tristate "Xen hypercall passthrough driver"
>>> depends on XEN
>>> default m
>>> + help
>>> + The hypercall passthrough driver allows user land programs to perform
>>
>> Maybe worth adding "privileged" here? Albeit of course that's different
>> from the use of the word ...
>
> I guess you mean "... allows privileged user programs ..." (another
> variant might be "The privileged hypercall passthrough ...")?
The former, yes.
Jan
On 11/16/21 11:05 AM, Jan Beulich wrote:
> On 16.11.2021 16:01, Juergen Gross wrote:
>> On 16.11.21 15:55, Jan Beulich wrote:
>>> On 16.11.2021 15:33, Juergen Gross wrote:
>>>
>>>>
>>>> config XEN_PRIVCMD
>>>> - tristate
>>>> + tristate "Xen hypercall passthrough driver"
>>>> depends on XEN
>>>> default m
>>>> + help
>>>> + The hypercall passthrough driver allows user land programs to perform
>>> Maybe worth adding "privileged" here? Albeit of course that's different
>>> from the use of the word ...
>> I guess you mean "... allows privileged user programs ..." (another
>> variant might be "The privileged hypercall passthrough ...")?
> The former, yes.
I can apply with this change, no need to resend.
-boris
On 11/16/21 5:33 PM, Boris Ostrovsky wrote:
>
> On 11/16/21 11:05 AM, Jan Beulich wrote:
>> On 16.11.2021 16:01, Juergen Gross wrote:
>>> On 16.11.21 15:55, Jan Beulich wrote:
>>>> On 16.11.2021 15:33, Juergen Gross wrote:
>>>>
>>>>> config XEN_PRIVCMD
>>>>> - tristate
>>>>> + tristate "Xen hypercall passthrough driver"
>>>>> depends on XEN
>>>>> default m
>>>>> + help
>>>>> + The hypercall passthrough driver allows user land programs to perform
>>>> Maybe worth adding "privileged" here? Albeit of course that's different
>>>> from the use of the word ...
>>> I guess you mean "... allows privileged user programs ..." (another
>>> variant might be "The privileged hypercall passthrough ...")?
>> The former, yes.
>
>
> I can apply with this change, no need to resend.
>
>
Applied to for-linus-5.16c
-boris