2022-09-11 03:24:33

by Xiu Jianfeng

Subject: [PATCH] rv/monitor: add __init/__exit annotations to module init/exit funcs

Add missing __init/__exit annotations to module init/exit funcs.

Fixes: 8812d21219b9 ("rv/monitor: Add the wip monitor skeleton created by dot2k")
Fixes: ccc319dcb450 ("rv/monitor: Add the wwnr monitor")
Signed-off-by: Xiu Jianfeng <[email protected]>
---
kernel/trace/rv/monitors/wip/wip.c | 4 ++--
kernel/trace/rv/monitors/wwnr/wwnr.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/kernel/trace/rv/monitors/wip/wip.c b/kernel/trace/rv/monitors/wip/wip.c
index 83cace53b9fa..6be876e2f405 100644
--- a/kernel/trace/rv/monitors/wip/wip.c
+++ b/kernel/trace/rv/monitors/wip/wip.c
@@ -69,13 +69,13 @@ struct rv_monitor rv_wip = {
.enabled = 0,
};

-static int register_wip(void)
+static int __init register_wip(void)
{
rv_register_monitor(&rv_wip);
return 0;
}

-static void unregister_wip(void)
+static void __exit unregister_wip(void)
{
rv_unregister_monitor(&rv_wip);
}
diff --git a/kernel/trace/rv/monitors/wwnr/wwnr.c b/kernel/trace/rv/monitors/wwnr/wwnr.c
index 599225d9cf38..c1fac4808b02 100644
--- a/kernel/trace/rv/monitors/wwnr/wwnr.c
+++ b/kernel/trace/rv/monitors/wwnr/wwnr.c
@@ -68,13 +68,13 @@ struct rv_monitor rv_wwnr = {
.enabled = 0,
};

-static int register_wwnr(void)
+static int __init register_wwnr(void)
{
rv_register_monitor(&rv_wwnr);
return 0;
}

-static void unregister_wwnr(void)
+static void __exit unregister_wwnr(void)
{
rv_unregister_monitor(&rv_wwnr);
}
--
2.17.1

2022-09-22 10:44:59

by Daniel Bristot de Oliveira

Subject: Re: [PATCH] rv/monitor: add __init/__exit annotations to module init/exit funcs

Hi Xiu

The first char after the subsys: must be capital, i.e.,

[PATCH] rv/monitor: Add __init/__exit annotations to module init/exit funcs

On 9/11/22 05:04, Xiu Jianfeng wrote:
> Add missing __init/__exit annotations to module init/exit funcs.

Please, also add these tags to the monitor templates here:


tools/verification/dot2/dot2k_templates/main_global.c
tools/verification/dot2/dot2k_templates/main_per_cpu.c
tools/verification/dot2/dot2k_templates/main_per_task.c

So the fix is propagated to future monitors.

Thanks
-- Daniel

2022-09-22 11:06:42

by Xiu Jianfeng

Subject: Re: [PATCH] rv/monitor: add __init/__exit annotations to module init/exit funcs

Hi,

在 2022/9/22 17:25, Daniel Bristot de Oliveira 写道:
> Hi Xiu
>
> The first char after the subsys: must be capital, i.e.,
>
> [PATCH] rv/monitor: Add __init/__exit annotations to module init/exit funcs
>
> On 9/11/22 05:04, Xiu Jianfeng wrote:
>> Add missing __init/__exit annotations to module init/exit funcs.
>
> Please, also add these tags to the monitor templates here:
>
>
> tools/verification/dot2/dot2k_templates/main_global.c
> tools/verification/dot2/dot2k_templates/main_per_cpu.c
> tools/verification/dot2/dot2k_templates/main_per_task.c
>
> So the fix is propagated to future monitors.

Thanks for the review, will do in v2.

>
> Thanks
> -- Daniel
> .
>