Chromeos devices are equipped with the embedded controller (EC)
that can be used as a watchdog. The following patches
updates the structures and definitions required to
communicate with EC-based watchdog and implements the
driver itself.
The previous version of this patch was sent here:
https://patchwork.kernel.org/project/linux-watchdog/list/?series=817925
Changelog
V2->V3:
* drop "-drv" from driver name
* use format #define<space>NAME<tab>value
Best regards,
Lukasz
Lukasz Majczak (3):
platform/chrome: Update binary interface for EC-based watchdog
watchdog: Add ChromeOS EC-based watchdog driver
mfd: cros_ec: Register EC-based watchdog subdevice
MAINTAINERS | 6 +
drivers/mfd/cros_ec_dev.c | 9 +
drivers/watchdog/Kconfig | 11 +
drivers/watchdog/Makefile | 1 +
drivers/watchdog/cros_ec_wdt.c | 202 ++++++++++++++++++
.../linux/platform_data/cros_ec_commands.h | 78 +++----
6 files changed, 264 insertions(+), 43 deletions(-)
create mode 100644 drivers/watchdog/cros_ec_wdt.c
--
2.43.0.429.g432eaa2c6b-goog
Update structures and defines related to EC_CMD_HANG_DETECT
to allow usage of new EC-based watchdog.
Signed-off-by: Lukasz Majczak <[email protected]>
---
.../linux/platform_data/cros_ec_commands.h | 78 +++++++++----------
1 file changed, 35 insertions(+), 43 deletions(-)
diff --git a/include/linux/platform_data/cros_ec_commands.h b/include/linux/platform_data/cros_ec_commands.h
index 7dae17b62a4d..ecc47d5fe239 100644
--- a/include/linux/platform_data/cros_ec_commands.h
+++ b/include/linux/platform_data/cros_ec_commands.h
@@ -3961,60 +3961,52 @@ struct ec_response_i2c_passthru {
} __ec_align1;
/*****************************************************************************/
-/* Power button hang detect */
-
+/* AP hang detect */
#define EC_CMD_HANG_DETECT 0x009F
-/* Reasons to start hang detection timer */
-/* Power button pressed */
-#define EC_HANG_START_ON_POWER_PRESS BIT(0)
-
-/* Lid closed */
-#define EC_HANG_START_ON_LID_CLOSE BIT(1)
-
- /* Lid opened */
-#define EC_HANG_START_ON_LID_OPEN BIT(2)
-
-/* Start of AP S3->S0 transition (booting or resuming from suspend) */
-#define EC_HANG_START_ON_RESUME BIT(3)
-
-/* Reasons to cancel hang detection */
+#define EC_HANG_DETECT_MIN_TIMEOUT 5
+#define EC_HANG_DETECT_MAX_TIMEOUT 65535
-/* Power button released */
-#define EC_HANG_STOP_ON_POWER_RELEASE BIT(8)
+/* EC hang detect commands */
+enum ec_hang_detect_cmds {
+ /* Reload AP hang detect timer. */
+ EC_HANG_DETECT_CMD_RELOAD = 0x0,
-/* Any host command from AP received */
-#define EC_HANG_STOP_ON_HOST_COMMAND BIT(9)
+ /* Stop AP hang detect timer. */
+ EC_HANG_DETECT_CMD_CANCEL = 0x1,
-/* Stop on end of AP S0->S3 transition (suspending or shutting down) */
-#define EC_HANG_STOP_ON_SUSPEND BIT(10)
+ /* Configure watchdog with given reboot timeout and
+ * cancel currently running AP hang detect timer.
+ */
+ EC_HANG_DETECT_CMD_SET_TIMEOUT = 0x2,
-/*
- * If this flag is set, all the other fields are ignored, and the hang detect
- * timer is started. This provides the AP a way to start the hang timer
- * without reconfiguring any of the other hang detect settings. Note that
- * you must previously have configured the timeouts.
- */
-#define EC_HANG_START_NOW BIT(30)
+ /* Get last hang status - whether the AP boot was clear or not */
+ EC_HANG_DETECT_CMD_GET_STATUS = 0x3,
-/*
- * If this flag is set, all the other fields are ignored (including
- * EC_HANG_START_NOW). This provides the AP a way to stop the hang timer
- * without reconfiguring any of the other hang detect settings.
- */
-#define EC_HANG_STOP_NOW BIT(31)
+ /* Clear last hang status. Called when AP is rebooting/shutting down
+ * gracefully.
+ */
+ EC_HANG_DETECT_CMD_CLEAR_STATUS = 0x4
+};
struct ec_params_hang_detect {
- /* Flags; see EC_HANG_* */
- uint32_t flags;
-
- /* Timeout in msec before generating host event, if enabled */
- uint16_t host_event_timeout_msec;
+ uint16_t command; /* enum ec_hang_detect_cmds */
+ /* Timeout in seconds before generating reboot */
+ uint16_t reboot_timeout_sec;
+} __ec_align2;
- /* Timeout in msec before generating warm reboot, if enabled */
- uint16_t warm_reboot_timeout_msec;
-} __ec_align4;
+/* Status codes that describe whether AP has boot normally or the hang has been
+ * detected and EC has reset AP
+ */
+enum ec_hang_detect_status {
+ EC_HANG_DETECT_AP_BOOT_NORMAL = 0x0,
+ EC_HANG_DETECT_AP_BOOT_EC_WDT = 0x1,
+ EC_HANG_DETECT_AP_BOOT_COUNT,
+};
+struct ec_response_hang_detect {
+ uint8_t status; /* enum ec_hang_detect_status */
+} __ec_align1;
/*****************************************************************************/
/* Commands for battery charging */
--
2.43.0.429.g432eaa2c6b-goog
Embedded Controller (EC) present on Chromebook devices
can be used as a watchdog.
Implement a driver to support it.
Signed-off-by: Lukasz Majczak <[email protected]>
---
MAINTAINERS | 6 +
drivers/watchdog/Kconfig | 11 ++
drivers/watchdog/Makefile | 1 +
drivers/watchdog/cros_ec_wdt.c | 202 +++++++++++++++++++++++++++++++++
4 files changed, 220 insertions(+)
create mode 100644 drivers/watchdog/cros_ec_wdt.c
diff --git a/MAINTAINERS b/MAINTAINERS
index ef90ddc0fda6..aaae581aae70 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4981,6 +4981,12 @@ R: Sami Kyöstilä <[email protected]>
S: Maintained
F: drivers/platform/chrome/cros_hps_i2c.c
+CHROMEOS EC WATCHDOG
+M: Lukasz Majczak <[email protected]>
+L: [email protected]
+S: Maintained
+F: drivers/watchdog/cros_ec_wdt.c
+
CHRONTEL CH7322 CEC DRIVER
M: Joe Tessler <[email protected]>
L: [email protected]
diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
index 7d22051b15a2..4700b218340f 100644
--- a/drivers/watchdog/Kconfig
+++ b/drivers/watchdog/Kconfig
@@ -181,6 +181,17 @@ config BD957XMUF_WATCHDOG
watchdog. Alternatively say M to compile the driver as a module,
which will be called bd9576_wdt.
+config CROS_EC_WATCHDOG
+ tristate "ChromeOS EC-based watchdog"
+ select WATCHDOG_CORE
+ depends on CROS_EC
+ help
+ Watchdog driver for Chromebook devices equipped with embedded controller.
+ Trigger event is recorded in EC and checked on the subsequent boot.
+
+ To compile this driver as a module, choose M here: the
+ module will be called cros_ec_wdt.
+
config DA9052_WATCHDOG
tristate "Dialog DA9052 Watchdog"
depends on PMIC_DA9052 || COMPILE_TEST
diff --git a/drivers/watchdog/Makefile b/drivers/watchdog/Makefile
index 7cbc34514ec1..3710c218f05e 100644
--- a/drivers/watchdog/Makefile
+++ b/drivers/watchdog/Makefile
@@ -217,6 +217,7 @@ obj-$(CONFIG_XEN_WDT) += xen_wdt.o
# Architecture Independent
obj-$(CONFIG_BD957XMUF_WATCHDOG) += bd9576_wdt.o
+obj-$(CONFIG_CROS_EC_WATCHDOG) += cros_ec_wdt.o
obj-$(CONFIG_DA9052_WATCHDOG) += da9052_wdt.o
obj-$(CONFIG_DA9055_WATCHDOG) += da9055_wdt.o
obj-$(CONFIG_DA9062_WATCHDOG) += da9062_wdt.o
diff --git a/drivers/watchdog/cros_ec_wdt.c b/drivers/watchdog/cros_ec_wdt.c
new file mode 100644
index 000000000000..d03eb0562e08
--- /dev/null
+++ b/drivers/watchdog/cros_ec_wdt.c
@@ -0,0 +1,202 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright 2024 Google LLC.
+ * Author: Lukasz Majczak <[email protected]>
+ */
+
+#include <linux/err.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/mod_devicetable.h>
+#include <linux/platform_data/cros_ec_commands.h>
+#include <linux/platform_data/cros_ec_proto.h>
+#include <linux/platform_device.h>
+#include <linux/watchdog.h>
+
+#define CROS_EC_WATCHDOG_DEFAULT_TIME 30 /* seconds */
+#define DRV_NAME "cros-ec-wdt"
+
+union cros_ec_wdt_data {
+ struct ec_params_hang_detect req;
+ struct ec_response_hang_detect resp;
+} __packed;
+
+static int cros_ec_wdt_send_cmd(struct cros_ec_device *cros_ec,
+ union cros_ec_wdt_data *arg)
+{
+ int ret;
+ struct {
+ struct cros_ec_command msg;
+ union cros_ec_wdt_data data;
+ } __packed buf = {
+ .msg = {
+ .version = 0,
+ .command = EC_CMD_HANG_DETECT,
+ .insize = (arg->req.command == EC_HANG_DETECT_CMD_GET_STATUS) ?
+ sizeof(struct ec_response_hang_detect) :
+ 0,
+ .outsize = sizeof(struct ec_params_hang_detect),
+ },
+ .data.req = arg->req
+ };
+
+ ret = cros_ec_cmd_xfer_status(cros_ec, &buf.msg);
+ if (ret < 0)
+ return ret;
+
+ arg->resp = buf.data.resp;
+
+ return 0;
+}
+
+static int cros_ec_wdt_ping(struct watchdog_device *wdd)
+{
+ struct cros_ec_device *cros_ec = watchdog_get_drvdata(wdd);
+ union cros_ec_wdt_data arg;
+ int ret;
+
+ arg.req.command = EC_HANG_DETECT_CMD_RELOAD;
+ ret = cros_ec_wdt_send_cmd(cros_ec, &arg);
+ if (ret < 0)
+ dev_dbg(wdd->parent, "Failed to ping watchdog (%d)", ret);
+
+ return ret;
+}
+
+static int cros_ec_wdt_start(struct watchdog_device *wdd)
+{
+ struct cros_ec_device *cros_ec = watchdog_get_drvdata(wdd);
+ union cros_ec_wdt_data arg;
+ int ret;
+
+ /* Prepare watchdog on EC side */
+ arg.req.command = EC_HANG_DETECT_CMD_SET_TIMEOUT;
+ arg.req.reboot_timeout_sec = wdd->timeout;
+ ret = cros_ec_wdt_send_cmd(cros_ec, &arg);
+ if (ret < 0)
+ dev_dbg(wdd->parent, "Failed to start watchdog (%d)", ret);
+
+ return ret;
+}
+
+static int cros_ec_wdt_stop(struct watchdog_device *wdd)
+{
+ struct cros_ec_device *cros_ec = watchdog_get_drvdata(wdd);
+ union cros_ec_wdt_data arg;
+ int ret;
+
+ arg.req.command = EC_HANG_DETECT_CMD_CANCEL;
+ ret = cros_ec_wdt_send_cmd(cros_ec, &arg);
+ if (ret < 0)
+ dev_dbg(wdd->parent, "Failed to stop watchdog (%d)", ret);
+
+ return ret;
+}
+
+static int cros_ec_wdt_set_timeout(struct watchdog_device *wdd, unsigned int t)
+{
+ unsigned int old_timeout = wdd->timeout;
+ int ret;
+
+ wdd->timeout = t;
+ ret = cros_ec_wdt_start(wdd);
+ if (ret < 0)
+ wdd->timeout = old_timeout;
+
+ return ret;
+}
+
+static const struct watchdog_info cros_ec_wdt_ident = {
+ .options = WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING | WDIOF_MAGICCLOSE,
+ .firmware_version = 0,
+ .identity = DRV_NAME,
+};
+
+static const struct watchdog_ops cros_ec_wdt_ops = {
+ .owner = THIS_MODULE,
+ .ping = cros_ec_wdt_ping,
+ .start = cros_ec_wdt_start,
+ .stop = cros_ec_wdt_stop,
+ .set_timeout = cros_ec_wdt_set_timeout,
+};
+
+static int cros_ec_wdt_probe(struct platform_device *pdev)
+{
+ struct device *dev = &pdev->dev;
+ struct cros_ec_dev *ec_dev = dev_get_drvdata(dev->parent);
+ struct cros_ec_device *cros_ec = ec_dev->ec_dev;
+ struct watchdog_device *wdd;
+ union cros_ec_wdt_data arg;
+ int ret = 0;
+
+ wdd = devm_kzalloc(&pdev->dev, sizeof(struct watchdog_device), GFP_KERNEL);
+ if (!wdd)
+ return -ENOMEM;
+
+ arg.req.command = EC_HANG_DETECT_CMD_GET_STATUS;
+ ret = cros_ec_wdt_send_cmd(cros_ec, &arg);
+ if (ret < 0)
+ return dev_err_probe(dev, ret, "Failed to get watchdog bootstatus");
+
+ wdd->parent = &pdev->dev;
+ wdd->info = &cros_ec_wdt_ident;
+ wdd->ops = &cros_ec_wdt_ops;
+ wdd->timeout = CROS_EC_WATCHDOG_DEFAULT_TIME;
+ wdd->min_timeout = EC_HANG_DETECT_MIN_TIMEOUT;
+ wdd->max_timeout = EC_HANG_DETECT_MAX_TIMEOUT;
+ if (arg.resp.status == EC_HANG_DETECT_AP_BOOT_EC_WDT)
+ wdd->bootstatus = WDIOF_CARDRESET;
+
+ arg.req.command = EC_HANG_DETECT_CMD_CLEAR_STATUS;
+ ret = cros_ec_wdt_send_cmd(cros_ec, &arg);
+ if (ret < 0)
+ return dev_err_probe(dev, ret, "Failed to clear watchdog bootstatus");
+
+ watchdog_stop_on_reboot(wdd);
+ watchdog_stop_on_unregister(wdd);
+ watchdog_set_drvdata(wdd, cros_ec);
+ platform_set_drvdata(pdev, wdd);
+
+ return devm_watchdog_register_device(dev, wdd);
+}
+
+static int __maybe_unused cros_ec_wdt_suspend(struct platform_device *pdev, pm_message_t state)
+{
+ struct watchdog_device *wdd = platform_get_drvdata(pdev);
+ int ret = 0;
+
+ if (watchdog_active(wdd))
+ ret = cros_ec_wdt_stop(wdd);
+
+ return ret;
+}
+
+static int __maybe_unused cros_ec_wdt_resume(struct platform_device *pdev)
+{
+ struct watchdog_device *wdd = platform_get_drvdata(pdev);
+ int ret = 0;
+
+ if (watchdog_active(wdd))
+ ret = cros_ec_wdt_start(wdd);
+
+ return ret;
+}
+
+static struct platform_driver cros_ec_wdt_driver = {
+ .probe = cros_ec_wdt_probe,
+ .suspend = pm_ptr(cros_ec_wdt_suspend),
+ .resume = pm_ptr(cros_ec_wdt_resume),
+ .driver = {
+ .name = DRV_NAME,
+ },
+};
+
+module_platform_driver(cros_ec_wdt_driver);
+
+static const struct platform_device_id cros_ec_wdt_id[] = {
+ { DRV_NAME, 0 },
+ {}
+};
+MODULE_DEVICE_TABLE(platform, cros_ec_wdt_id);
+MODULE_DESCRIPTION("Cros EC Watchdog Device Driver");
+MODULE_LICENSE("GPL");
--
2.43.0.429.g432eaa2c6b-goog
Add ChromeOS EC-based watchdog as EC subdevice.
Signed-off-by: Lukasz Majczak <[email protected]>
---
drivers/mfd/cros_ec_dev.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
index 603b1cd52785..4996220ce64b 100644
--- a/drivers/mfd/cros_ec_dev.c
+++ b/drivers/mfd/cros_ec_dev.c
@@ -91,6 +91,10 @@ static const struct mfd_cell cros_usbpd_notify_cells[] = {
{ .name = "cros-usbpd-notify", },
};
+static const struct mfd_cell cros_ec_wdt_cells[] = {
+ { .name = "cros-ec-wdt", }
+};
+
static const struct cros_feature_to_cells cros_subdevices[] = {
{
.id = EC_FEATURE_CEC,
@@ -107,6 +111,11 @@ static const struct cros_feature_to_cells cros_subdevices[] = {
.mfd_cells = cros_usbpd_charger_cells,
.num_cells = ARRAY_SIZE(cros_usbpd_charger_cells),
},
+ {
+ .id = EC_FEATURE_HANG_DETECT,
+ .mfd_cells = cros_ec_wdt_cells,
+ .num_cells = ARRAY_SIZE(cros_ec_wdt_cells),
+ },
};
static const struct mfd_cell cros_ec_platform_cells[] = {
--
2.43.0.429.g432eaa2c6b-goog
On 1/19/24 00:43, Lukasz Majczak wrote:
> Chromeos devices are equipped with the embedded controller (EC)
> that can be used as a watchdog. The following patches
> updates the structures and definitions required to
> communicate with EC-based watchdog and implements the
> driver itself.
>
> The previous version of this patch was sent here:
> https://patchwork.kernel.org/project/linux-watchdog/list/?series=817925
>
> Changelog
> V2->V3:
> * drop "-drv" from driver name
> * use format #define<space>NAME<tab>value
>
I am a bit lost here. You dropped my Reviewed-by: tags, even though
I specifically said that they applied with those changes made.
Also, according to the above patch 1/3 was not changed at all.
What else did you change that warrants dropping the tags ?
Guenter
On Fri, Jan 19, 2024 at 1:50 PM Guenter Roeck <[email protected]> wrote:
>
> On 1/19/24 00:43, Lukasz Majczak wrote:
> > Chromeos devices are equipped with the embedded controller (EC)
> > that can be used as a watchdog. The following patches
> > updates the structures and definitions required to
> > communicate with EC-based watchdog and implements the
> > driver itself.
> >
> > The previous version of this patch was sent here:
> > https://patchwork.kernel.org/project/linux-watchdog/list/?series=817925
> >
> > Changelog
> > V2->V3:
> > * drop "-drv" from driver name
> > * use format #define<space>NAME<tab>value
> >
>
> I am a bit lost here. You dropped my Reviewed-by: tags, even though
> I specifically said that they applied with those changes made.
> Also, according to the above patch 1/3 was not changed at all.
>
> What else did you change that warrants dropping the tags ?
>
> Guenter
>
The "-drv" change was related to patch 2 and 3, and I have used
"format #define<space>NAME<tab>value" only in patch 3 (as
ec_commands.h is mixing those)
Sorry for dropping your "Reviewed-by" tag :( I've assumed (wrong) that
I cannot take it for granted sending V3.
Alos in such a case if there are changes in patch 2 and 3 and 1
remains untouched shall I send only 2 and 3 in the next version ?
Best regards,
Lukasz
On 1/19/24 06:10, Łukasz Majczak wrote:
> On Fri, Jan 19, 2024 at 1:50 PM Guenter Roeck <[email protected]> wrote:
>>
>> On 1/19/24 00:43, Lukasz Majczak wrote:
>>> Chromeos devices are equipped with the embedded controller (EC)
>>> that can be used as a watchdog. The following patches
>>> updates the structures and definitions required to
>>> communicate with EC-based watchdog and implements the
>>> driver itself.
>>>
>>> The previous version of this patch was sent here:
>>> https://patchwork.kernel.org/project/linux-watchdog/list/?series=817925
>>>
>>> Changelog
>>> V2->V3:
>>> * drop "-drv" from driver name
>>> * use format #define<space>NAME<tab>value
>>>
>>
>> I am a bit lost here. You dropped my Reviewed-by: tags, even though
>> I specifically said that they applied with those changes made.
>> Also, according to the above patch 1/3 was not changed at all.
>>
>> What else did you change that warrants dropping the tags ?
>>
>> Guenter
>>
> The "-drv" change was related to patch 2 and 3, and I have used
> "format #define<space>NAME<tab>value" only in patch 3 (as
> ec_commands.h is mixing those)
> Sorry for dropping your "Reviewed-by" tag :( I've assumed (wrong) that
> I cannot take it for granted sending V3.
From Documentation/process/submitting-patches.rst:
Both Tested-by and Reviewed-by tags, once received on mailing list from tester
or reviewer, should be added by author to the applicable patches when sending
next versions. However if the patch has changed substantially in following
version, these tags might not be applicable anymore and thus should be removed.
Usually removal of someone's Tested-by or Reviewed-by tags should be mentioned
in the patch changelog (after the '---' separator).
> Alos in such a case if there are changes in patch 2 and 3 and 1
> remains untouched shall I send only 2 and 3 in the next version ?
>
Again, from Documentation/process/submitting-patches.rst:
.. the patch (series) and its description should be self-contained.
This benefits both the maintainers and reviewers. Some reviewers
probably didn't even receive earlier versions of the patch.
Note that the same document also says:
Wait for a minimum of one week before resubmitting or pinging reviewers
- possibly longer during busy times like merge windows.
I could just send another series of Reviewed-by: tags, but quite frankly
by now I am wary that you might drop those again, so I guess I'll wait
a while to see if there is another version of the series.
Guenter
Gunter,
I'm sorry for the confusion, I've just forgotten to add "received-by"
and there are no other changes besides mentioned in the cover letter
changelog.
Thank you for mentioning the process, now I understand why it is so important.
I will send V4 for the sake of following the process.
Best regards,
Lukasz
On Fri, Jan 19, 2024 at 3:43 PM Guenter Roeck <[email protected]> wrote:
>
> On 1/19/24 06:10, Łukasz Majczak wrote:
> > On Fri, Jan 19, 2024 at 1:50 PM Guenter Roeck <[email protected]> wrote:
> >>
> >> On 1/19/24 00:43, Lukasz Majczak wrote:
> >>> Chromeos devices are equipped with the embedded controller (EC)
> >>> that can be used as a watchdog. The following patches
> >>> updates the structures and definitions required to
> >>> communicate with EC-based watchdog and implements the
> >>> driver itself.
> >>>
> >>> The previous version of this patch was sent here:
> >>> https://patchwork.kernel.org/project/linux-watchdog/list/?series=817925
> >>>
> >>> Changelog
> >>> V2->V3:
> >>> * drop "-drv" from driver name
> >>> * use format #define<space>NAME<tab>value
> >>>
> >>
> >> I am a bit lost here. You dropped my Reviewed-by: tags, even though
> >> I specifically said that they applied with those changes made.
> >> Also, according to the above patch 1/3 was not changed at all.
> >>
> >> What else did you change that warrants dropping the tags ?
> >>
> >> Guenter
> >>
> > The "-drv" change was related to patch 2 and 3, and I have used
> > "format #define<space>NAME<tab>value" only in patch 3 (as
> > ec_commands.h is mixing those)
> > Sorry for dropping your "Reviewed-by" tag :( I've assumed (wrong) that
> > I cannot take it for granted sending V3.
>
> From Documentation/process/submitting-patches.rst:
>
> Both Tested-by and Reviewed-by tags, once received on mailing list from tester
> or reviewer, should be added by author to the applicable patches when sending
> next versions. However if the patch has changed substantially in following
> version, these tags might not be applicable anymore and thus should be removed.
> Usually removal of someone's Tested-by or Reviewed-by tags should be mentioned
> in the patch changelog (after the '---' separator).
>
> > Alos in such a case if there are changes in patch 2 and 3 and 1
> > remains untouched shall I send only 2 and 3 in the next version ?
> >
>
> Again, from Documentation/process/submitting-patches.rst:
>
> ... the patch (series) and its description should be self-contained.
> This benefits both the maintainers and reviewers. Some reviewers
> probably didn't even receive earlier versions of the patch.
>
> Note that the same document also says:
>
> Wait for a minimum of one week before resubmitting or pinging reviewers
> - possibly longer during busy times like merge windows.
>
> I could just send another series of Reviewed-by: tags, but quite frankly
> by now I am wary that you might drop those again, so I guess I'll wait
> a while to see if there is another version of the series.
>
> Guenter
>
Ohhh, I get it now. Gunter please send reviewed-by to V3 whenever you
feel appropriate.
Best regards,
Lukasz
On Fri, Jan 19, 2024 at 3:50 PM Łukasz Majczak <[email protected]> wrote:
>
> Gunter,
>
> I'm sorry for the confusion, I've just forgotten to add "received-by"
> and there are no other changes besides mentioned in the cover letter
> changelog.
> Thank you for mentioning the process, now I understand why it is so important.
>
> I will send V4 for the sake of following the process.
>
> Best regards,
> Lukasz
>
> On Fri, Jan 19, 2024 at 3:43 PM Guenter Roeck <[email protected]> wrote:
> >
> > On 1/19/24 06:10, Łukasz Majczak wrote:
> > > On Fri, Jan 19, 2024 at 1:50 PM Guenter Roeck <linux@roeck-usnet> wrote:
> > >>
> > >> On 1/19/24 00:43, Lukasz Majczak wrote:
> > >>> Chromeos devices are equipped with the embedded controller (EC)
> > >>> that can be used as a watchdog. The following patches
> > >>> updates the structures and definitions required to
> > >>> communicate with EC-based watchdog and implements the
> > >>> driver itself.
> > >>>
> > >>> The previous version of this patch was sent here:
> > >>> https://patchwork.kernel.org/project/linux-watchdog/list/?series=817925
> > >>>
> > >>> Changelog
> > >>> V2->V3:
> > >>> * drop "-drv" from driver name
> > >>> * use format #define<space>NAME<tab>value
> > >>>
> > >>
> > >> I am a bit lost here. You dropped my Reviewed-by: tags, even though
> > >> I specifically said that they applied with those changes made.
> > >> Also, according to the above patch 1/3 was not changed at all.
> > >>
> > >> What else did you change that warrants dropping the tags ?
> > >>
> > >> Guenter
> > >>
> > > The "-drv" change was related to patch 2 and 3, and I have used
> > > "format #define<space>NAME<tab>value" only in patch 3 (as
> > > ec_commands.h is mixing those)
> > > Sorry for dropping your "Reviewed-by" tag :( I've assumed (wrong) that
> > > I cannot take it for granted sending V3.
> >
> > From Documentation/process/submitting-patches.rst:
> >
> > Both Tested-by and Reviewed-by tags, once received on mailing list from tester
> > or reviewer, should be added by author to the applicable patches when sending
> > next versions. However if the patch has changed substantially in following
> > version, these tags might not be applicable anymore and thus should be removed.
> > Usually removal of someone's Tested-by or Reviewed-by tags should be mentioned
> > in the patch changelog (after the '---' separator).
> >
> > > Alos in such a case if there are changes in patch 2 and 3 and 1
> > > remains untouched shall I send only 2 and 3 in the next version ?
> > >
> >
> > Again, from Documentation/process/submitting-patches.rst:
> >
> > ... the patch (series) and its description should be self-contained.
> > This benefits both the maintainers and reviewers. Some reviewers
> > probably didn't even receive earlier versions of the patch.
> >
> > Note that the same document also says:
> >
> > Wait for a minimum of one week before resubmitting or pinging reviewers
> > - possibly longer during busy times like merge windows.
> >
> > I could just send another series of Reviewed-by: tags, but quite frankly
> > by now I am wary that you might drop those again, so I guess I'll wait
> > a while to see if there is another version of the series.
> >
> > Guenter
> >
On 19/01/2024 09:43, Lukasz Majczak wrote:
> Embedded Controller (EC) present on Chromebook devices
> can be used as a watchdog.
> Implement a driver to support it.
>
..
> +static int cros_ec_wdt_probe(struct platform_device *pdev)
> +{
> + struct device *dev = &pdev->dev;
> + struct cros_ec_dev *ec_dev = dev_get_drvdata(dev->parent);
> + struct cros_ec_device *cros_ec = ec_dev->ec_dev;
> + struct watchdog_device *wdd;
> + union cros_ec_wdt_data arg;
> + int ret = 0;
> +
> + wdd = devm_kzalloc(&pdev->dev, sizeof(struct watchdog_device), GFP_KERNEL);
sizeof(*)
> + if (!wdd)
> + return -ENOMEM;
> +
> + arg.req.command = EC_HANG_DETECT_CMD_GET_STATUS;
> + ret = cros_ec_wdt_send_cmd(cros_ec, &arg);
> + if (ret < 0)
> + return dev_err_probe(dev, ret, "Failed to get watchdog bootstatus");
> +
> + wdd->parent = &pdev->dev;
> + wdd->info = &cros_ec_wdt_ident;
> + wdd->ops = &cros_ec_wdt_ops;
> + wdd->timeout = CROS_EC_WATCHDOG_DEFAULT_TIME;
> + wdd->min_timeout = EC_HANG_DETECT_MIN_TIMEOUT;
> + wdd->max_timeout = EC_HANG_DETECT_MAX_TIMEOUT;
> + if (arg.resp.status == EC_HANG_DETECT_AP_BOOT_EC_WDT)
> + wdd->bootstatus = WDIOF_CARDRESET;
> +
> + arg.req.command = EC_HANG_DETECT_CMD_CLEAR_STATUS;
> + ret = cros_ec_wdt_send_cmd(cros_ec, &arg);
> + if (ret < 0)
> + return dev_err_probe(dev, ret, "Failed to clear watchdog bootstatus");
> +
> + watchdog_stop_on_reboot(wdd);
> + watchdog_stop_on_unregister(wdd);
> + watchdog_set_drvdata(wdd, cros_ec);
> + platform_set_drvdata(pdev, wdd);
> +
> + return devm_watchdog_register_device(dev, wdd);
> +}
> +
> +static int __maybe_unused cros_ec_wdt_suspend(struct platform_device *pdev, pm_message_t state)
> +{
> + struct watchdog_device *wdd = platform_get_drvdata(pdev);
> + int ret = 0;
> +
> + if (watchdog_active(wdd))
> + ret = cros_ec_wdt_stop(wdd);
> +
> + return ret;
> +}
> +
> +static int __maybe_unused cros_ec_wdt_resume(struct platform_device *pdev)
> +{
> + struct watchdog_device *wdd = platform_get_drvdata(pdev);
> + int ret = 0;
> +
> + if (watchdog_active(wdd))
> + ret = cros_ec_wdt_start(wdd);
> +
> + return ret;
> +}
> +
> +static struct platform_driver cros_ec_wdt_driver = {
> + .probe = cros_ec_wdt_probe,
> + .suspend = pm_ptr(cros_ec_wdt_suspend),
> + .resume = pm_ptr(cros_ec_wdt_resume),
> + .driver = {
> + .name = DRV_NAME,
> + },
> +};
> +
> +module_platform_driver(cros_ec_wdt_driver);
> +
> +static const struct platform_device_id cros_ec_wdt_id[] = {
> + { DRV_NAME, 0 },
> + {}
> +};
> +MODULE_DEVICE_TABLE(platform, cros_ec_wdt_id);
device_id is not placed here, please open existing drivers for
reference. Why this isn't referenced in driver structure?
> +MODULE_DESCRIPTION("Cros EC Watchdog Device Driver");
> +MODULE_LICENSE("GPL");
Best regards,
Krzysztof
On Mon, Jan 22, 2024 at 11:31 AM Krzysztof Kozlowski <[email protected]> wrote:
> > + wdd = devm_kzalloc(&pdev->dev, sizeof(struct watchdog_device), GFP_KERNEL);
>
> sizeof(*)
>
ACK.
> > +MODULE_DEVICE_TABLE(platform, cros_ec_wdt_id);
>
> device_id is not placed here, please open existing drivers for
> reference. Why this isn't referenced in driver structure?
>
ACK, I will take s3c2410_wdt.c as an example, thank you.
Best regards,
Lukasz
On Fri, 19 Jan 2024 08:43:27 +0000, Lukasz Majczak wrote:
> Add ChromeOS EC-based watchdog as EC subdevice.
>
>
Applied, thanks!
[3/3] mfd: cros_ec: Register EC-based watchdog subdevice
commit: a1958f84deb5cdba020af725fc5003a05af4819c
--
Lee Jones [李琼斯]
On Thu, Jan 25, 2024 at 2:37 PM Lee Jones <[email protected]> wrote:
>
> On Fri, 19 Jan 2024 08:43:27 +0000, Lukasz Majczak wrote:
> > Add ChromeOS EC-based watchdog as EC subdevice.
> >
> >
>
> Applied, thanks!
>
> [3/3] mfd: cros_ec: Register EC-based watchdog subdevice
> commit: a1958f84deb5cdba020af725fc5003a05af4819c
>
> --
> Lee Jones [李琼斯]
>
Hi Lee,
I will send V4 of the patchset to address Krzysztof suggestions, in
that case I should skip adding V4 of this patch and have only patches
1 and 2 in the V4 patchset?
Best regards,
Lukasz
On Thu, 25 Jan 2024, Łukasz Majczak wrote:
> On Thu, Jan 25, 2024 at 2:37 PM Lee Jones <[email protected]> wrote:
> >
> > On Fri, 19 Jan 2024 08:43:27 +0000, Lukasz Majczak wrote:
> > > Add ChromeOS EC-based watchdog as EC subdevice.
> > >
> > >
> >
> > Applied, thanks!
> >
> > [3/3] mfd: cros_ec: Register EC-based watchdog subdevice
> > commit: a1958f84deb5cdba020af725fc5003a05af4819c
> >
> > --
> > Lee Jones [李琼斯]
> >
> Hi Lee,
>
> I will send V4 of the patchset to address Krzysztof suggestions, in
> that case I should skip adding V4 of this patch and have only patches
> 1 and 2 in the V4 patchset?
Yes please. No need to resend patches which have already been merged.
--
Lee Jones [李琼斯]
Hello:
This series was applied to chrome-platform/linux.git (for-kernelci)
by Lee Jones <[email protected]>:
On Fri, 19 Jan 2024 08:43:24 +0000 you wrote:
> Chromeos devices are equipped with the embedded controller (EC)
> that can be used as a watchdog. The following patches
> updates the structures and definitions required to
> communicate with EC-based watchdog and implements the
> driver itself.
>
> The previous version of this patch was sent here:
> https://patchwork.kernel.org/project/linux-watchdog/list/?series=817925
>
> [...]
Here is the summary with links:
- [v3,1/3] platform/chrome: Update binary interface for EC-based watchdog
https://git.kernel.org/chrome-platform/c/4d2ff655fb85
- [v3,2/3] watchdog: Add ChromeOS EC-based watchdog driver
(no matching commit)
- [v3,3/3] mfd: cros_ec: Register EC-based watchdog subdevice
https://git.kernel.org/chrome-platform/c/6cea614ba78d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
Hello:
This series was applied to chrome-platform/linux.git (for-next)
by Lee Jones <[email protected]>:
On Fri, 19 Jan 2024 08:43:24 +0000 you wrote:
> Chromeos devices are equipped with the embedded controller (EC)
> that can be used as a watchdog. The following patches
> updates the structures and definitions required to
> communicate with EC-based watchdog and implements the
> driver itself.
>
> The previous version of this patch was sent here:
> https://patchwork.kernel.org/project/linux-watchdog/list/?series=817925
>
> [...]
Here is the summary with links:
- [v3,1/3] platform/chrome: Update binary interface for EC-based watchdog
https://git.kernel.org/chrome-platform/c/4d2ff655fb85
- [v3,2/3] watchdog: Add ChromeOS EC-based watchdog driver
(no matching commit)
- [v3,3/3] mfd: cros_ec: Register EC-based watchdog subdevice
https://git.kernel.org/chrome-platform/c/6cea614ba78d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html