2020-10-30 08:48:09

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH v2 0/5] Introduce a new helper marco DEFINE_SHOW_STORE_ATTRIBUTE at seq_file.c

On Fri, Oct 30, 2020 at 04:31:57PM +0800, Luo Jiaxing wrote:
> We already own DEFINE_SHOW_ATTRIBUTE() helper macro for defining attribute
> for read-only file, but we found many of drivers also want a helper marco for
> read-write file too.
>
> So we try to add this macro to help decrease code duplication.
>
> Luo Jiaxing (5):
> seq_file: Introduce DEFINE_SHOW_STORE_ATTRIBUTE() helper macro
> scsi: hisi_sas: Introduce DEFINE_SHOW_STORE_ATTRIBUTE for debugfs
> scsi: qla2xxx: Introduce DEFINE_SHOW_STORE_ATTRIBUTE for debugfs
> usb: dwc3: debugfs: Introduce DEFINE_SHOW_STORE_ATTRIBUTE
> drm/i915/display: Introduce DEFINE_SHOW_STORE_ATTRIBUTE for debugfs

What changed from v1?

thanks,

greg k-h


2020-11-03 08:21:18

by Luo Jiaxing

[permalink] [raw]
Subject: Re: [PATCH v2 0/5] Introduce a new helper marco DEFINE_SHOW_STORE_ATTRIBUTE at seq_file.c

Hi

On 2020/10/30 16:44, Greg KH wrote:
> On Fri, Oct 30, 2020 at 04:31:57PM +0800, Luo Jiaxing wrote:
>> We already own DEFINE_SHOW_ATTRIBUTE() helper macro for defining attribute
>> for read-only file, but we found many of drivers also want a helper marco for
>> read-write file too.
>>
>> So we try to add this macro to help decrease code duplication.
>>
>> Luo Jiaxing (5):
>> seq_file: Introduce DEFINE_SHOW_STORE_ATTRIBUTE() helper macro
>> scsi: hisi_sas: Introduce DEFINE_SHOW_STORE_ATTRIBUTE for debugfs
>> scsi: qla2xxx: Introduce DEFINE_SHOW_STORE_ATTRIBUTE for debugfs
>> usb: dwc3: debugfs: Introduce DEFINE_SHOW_STORE_ATTRIBUTE
>> drm/i915/display: Introduce DEFINE_SHOW_STORE_ATTRIBUTE for debugfs
> What changed from v1?


Sorry, I should add a commit for the change.


In v1, Andy pointed out that the old name of DEFINE_STORE_ATTRIBUTE was
easily misunderstood as a write-only file rather than a read-write file.

Therefore, it is changed to DEFINE_SHOW_STORE_ATTRIBUTE according to his
suggestion.


Thanks

Jiaxing


>
> thanks,
>
> greg k-h
>
> .
>

2020-11-03 08:28:39

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH v2 0/5] Introduce a new helper marco DEFINE_SHOW_STORE_ATTRIBUTE at seq_file.c

On Tue, Nov 03, 2020 at 04:19:09PM +0800, luojiaxing wrote:
> Hi
>
> On 2020/10/30 16:44, Greg KH wrote:
> > On Fri, Oct 30, 2020 at 04:31:57PM +0800, Luo Jiaxing wrote:
> > > We already own DEFINE_SHOW_ATTRIBUTE() helper macro for defining attribute
> > > for read-only file, but we found many of drivers also want a helper marco for
> > > read-write file too.
> > >
> > > So we try to add this macro to help decrease code duplication.
> > >
> > > Luo Jiaxing (5):
> > > seq_file: Introduce DEFINE_SHOW_STORE_ATTRIBUTE() helper macro
> > > scsi: hisi_sas: Introduce DEFINE_SHOW_STORE_ATTRIBUTE for debugfs
> > > scsi: qla2xxx: Introduce DEFINE_SHOW_STORE_ATTRIBUTE for debugfs
> > > usb: dwc3: debugfs: Introduce DEFINE_SHOW_STORE_ATTRIBUTE
> > > drm/i915/display: Introduce DEFINE_SHOW_STORE_ATTRIBUTE for debugfs
> > What changed from v1?
>
>
> Sorry, I should add a commit for the change.
>
>
> In v1, Andy pointed out that the old name of DEFINE_STORE_ATTRIBUTE was
> easily misunderstood as a write-only file rather than a read-write file.
>
> Therefore, it is changed to DEFINE_SHOW_STORE_ATTRIBUTE according to his
> suggestion.

All of that needs to go in the patch, below the --- line, or in the
00/XX email here, like is documented.

Please fix that up and resend a v3 if you wish for people to look at
this series and know what is going on.

thanks,

greg k-h