2023-03-06 21:37:15

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: Signed-off-by missing for commit in the net tree

Hi all,

Commit

58aac3a2ef41 ("net: phy: smsc: fix link up detection in forced irq mode")

is missing a Signed-off-by from its committer.

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (488.00 B)
OpenPGP digital signature

2023-03-06 22:16:16

by Heiner Kallweit

[permalink] [raw]
Subject: Re: linux-next: Signed-off-by missing for commit in the net tree

On 06.03.2023 22:37, Stephen Rothwell wrote:
> Hi all,
>
> Commit
>
> 58aac3a2ef41 ("net: phy: smsc: fix link up detection in forced irq mode")
>
> is missing a Signed-off-by from its committer.
>

Seems to be ok, false positive?

net: phy: smsc: fix link up detection in forced irq mode
Currently link up can't be detected in forced mode if polling
isn't used. Only link up interrupt source we have is aneg
complete which isn't applicable in forced mode. Therefore we
have to use energy-on as link up indicator.

Fixes: 7365494550f6 ("net: phy: smsc: skip ENERGYON interrupt if disabled")
Signed-off-by: Heiner Kallweit <[email protected]>
Signed-off-by: David S. Miller <[email protected]>

2023-03-07 00:53:03

by Stephen Rothwell

[permalink] [raw]
Subject: Re: linux-next: Signed-off-by missing for commit in the net tree

Hi Heiner,

On Mon, 6 Mar 2023 23:16:09 +0100 Heiner Kallweit <[email protected]> wrote:
>
> On 06.03.2023 22:37, Stephen Rothwell wrote:
> >
> > Commit
> >
> > 58aac3a2ef41 ("net: phy: smsc: fix link up detection in forced irq mode")
> >
> > is missing a Signed-off-by from its committer.
>
> Seems to be ok, false positive?
>
> net: phy: smsc: fix link up detection in forced irq mode
> Currently link up can't be detected in forced mode if polling
> isn't used. Only link up interrupt source we have is aneg
> complete which isn't applicable in forced mode. Therefore we
> have to use energy-on as link up indicator.
>
> Fixes: 7365494550f6 ("net: phy: smsc: skip ENERGYON interrupt if disabled")
> Signed-off-by: Heiner Kallweit <[email protected]>
> Signed-off-by: David S. Miller <[email protected]>

It was committed by Jakub Kicinski <[email protected]>

$ git show --pretty=raw 58aac3a2ef41
commit 58aac3a2ef414fea6d7fdf823ea177744a087d13
tree 26bf9b3b866bd43baa1b8055d42536ac7ce3b3cf
parent 89b59a84cb166f1ab5b6de9830e61324937c661e
author Heiner Kallweit <[email protected]> 1677927164 +0100
committer Jakub Kicinski <[email protected]> 1678137790 -0800

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (488.00 B)
OpenPGP digital signature

2023-03-07 01:33:42

by Jakub Kicinski

[permalink] [raw]
Subject: Re: linux-next: Signed-off-by missing for commit in the net tree

On Tue, 7 Mar 2023 11:52:52 +1100 Stephen Rothwell wrote:
> > Seems to be ok, false positive?
> >
> > net: phy: smsc: fix link up detection in forced irq mode
> > Currently link up can't be detected in forced mode if polling
> > isn't used. Only link up interrupt source we have is aneg
> > complete which isn't applicable in forced mode. Therefore we
> > have to use energy-on as link up indicator.
> >
> > Fixes: 7365494550f6 ("net: phy: smsc: skip ENERGYON interrupt if disabled")
> > Signed-off-by: Heiner Kallweit <[email protected]>
> > Signed-off-by: David S. Miller <[email protected]>
>
> It was committed by Jakub Kicinski <[email protected]>
>
> $ git show --pretty=raw 58aac3a2ef41
> commit 58aac3a2ef414fea6d7fdf823ea177744a087d13
> tree 26bf9b3b866bd43baa1b8055d42536ac7ce3b3cf
> parent 89b59a84cb166f1ab5b6de9830e61324937c661e
> author Heiner Kallweit <[email protected]> 1677927164 +0100
> committer Jakub Kicinski <[email protected]> 1678137790 -0800

Yes, my bad, sorry.