Remove fields that are not used, from structure definitions , and
eliminate the comments associated with them.
Srishti Sharma (2):
Staging: dgnc: Remove unused variables in structure definition
Staging: dgnc: Remove unused variable in structure
drivers/staging/dgnc/dgnc_driver.h | 15 ---------------
1 file changed, 15 deletions(-)
--
2.7.4
Remove unused fields and comments associated with them in
the structure definition.
Signed-off-by: Srishti Sharma <[email protected]>
---
Changes in v2:
- Use the word field instead of variable.
drivers/staging/dgnc/dgnc_driver.h | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.h b/drivers/staging/dgnc/dgnc_driver.h
index 764d6fe..5d2566e 100644
--- a/drivers/staging/dgnc/dgnc_driver.h
+++ b/drivers/staging/dgnc/dgnc_driver.h
@@ -104,7 +104,6 @@ struct board_ops {
* struct dgnc_board - Per board information.
* @boardnum: Board number (0 - 32).
*
- * @type: Type of board.
* @name: Product name.
* @pdev: Pointer to the pci_dev structure.
* @bd_flags: Board flags.
@@ -140,13 +139,9 @@ struct board_ops {
* @dpastatus: Board status as defined by DPA.
* @bd_dividend: Board/UART's specific dividend.
* @bd_ops: Pointer to board operations structure.
- * @proc_entry_pointer: Proc/<board> entry
- * @dgnc_board_table: Proc/<board> entry
*/
struct dgnc_board {
int boardnum;
-
- int type;
char *name;
struct pci_dev *pdev;
unsigned long bd_flags;
@@ -200,10 +195,6 @@ struct dgnc_board {
uint bd_dividend;
struct board_ops *bd_ops;
-
- struct proc_dir_entry *proc_entry_pointer;
- struct dgnc_proc_entry *dgnc_board_table;
-
};
/* Unit flag definitions for un_flags. */
--
2.7.4
Eliminate the fields that are not used and the comments
associated with them.
Signed-off-by: Srishti Sharma <[email protected]>
---
Changes in v2:
- Use the word field instead of variable.
drivers/staging/dgnc/dgnc_driver.h | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.h b/drivers/staging/dgnc/dgnc_driver.h
index 5d2566e..082d659 100644
--- a/drivers/staging/dgnc/dgnc_driver.h
+++ b/drivers/staging/dgnc/dgnc_driver.h
@@ -312,8 +312,6 @@ struct un_t {
* @ch_err_overrun: Count of overruns on channel.
* @ch_xon_sends: Count of xons transmitted.
* @ch_xoff_sends: Count of xoffs transmitted.
- * @proc_entry_pointer: Proc/<board>/<channel> entry.
- * @dgnc_channel_table: Proc/<board>/<channel> entry.
*/
struct channel_t {
struct dgnc_board *ch_bd;
@@ -382,10 +380,6 @@ struct channel_t {
ulong ch_xon_sends;
ulong ch_xoff_sends;
-
- struct proc_dir_entry *proc_entry_pointer;
- struct dgnc_proc_entry *dgnc_channel_table;
-
};
extern uint dgnc_major; /* Our driver/mgmt major */
--
2.7.4
On Sat, 16 Sep 2017, Srishti Sharma wrote:
> Remove unused fields and comments associated with them in
> the structure definition.
>
> Signed-off-by: Srishti Sharma <[email protected]>
Acked-by: Julia Lawall <[email protected]>
> ---
> Changes in v2:
> - Use the word field instead of variable.
>
> drivers/staging/dgnc/dgnc_driver.h | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_driver.h b/drivers/staging/dgnc/dgnc_driver.h
> index 764d6fe..5d2566e 100644
> --- a/drivers/staging/dgnc/dgnc_driver.h
> +++ b/drivers/staging/dgnc/dgnc_driver.h
> @@ -104,7 +104,6 @@ struct board_ops {
> * struct dgnc_board - Per board information.
> * @boardnum: Board number (0 - 32).
> *
> - * @type: Type of board.
> * @name: Product name.
> * @pdev: Pointer to the pci_dev structure.
> * @bd_flags: Board flags.
> @@ -140,13 +139,9 @@ struct board_ops {
> * @dpastatus: Board status as defined by DPA.
> * @bd_dividend: Board/UART's specific dividend.
> * @bd_ops: Pointer to board operations structure.
> - * @proc_entry_pointer: Proc/<board> entry
> - * @dgnc_board_table: Proc/<board> entry
> */
> struct dgnc_board {
> int boardnum;
> -
> - int type;
> char *name;
> struct pci_dev *pdev;
> unsigned long bd_flags;
> @@ -200,10 +195,6 @@ struct dgnc_board {
> uint bd_dividend;
>
> struct board_ops *bd_ops;
> -
> - struct proc_dir_entry *proc_entry_pointer;
> - struct dgnc_proc_entry *dgnc_board_table;
> -
> };
>
> /* Unit flag definitions for un_flags. */
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
> To post to this group, send email to [email protected].
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/dd9a08aabab9cfc60a5c7c7c0d5191d72e68c2d2.1505579408.git.srishtishar%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
On Sat, 16 Sep 2017, Srishti Sharma wrote:
> Eliminate the fields that are not used and the comments
> associated with them.
>
> Signed-off-by: Srishti Sharma <[email protected]>
Acked-by: Julia Lawall <[email protected]>
> ---
> Changes in v2:
> - Use the word field instead of variable.
>
> drivers/staging/dgnc/dgnc_driver.h | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_driver.h b/drivers/staging/dgnc/dgnc_driver.h
> index 5d2566e..082d659 100644
> --- a/drivers/staging/dgnc/dgnc_driver.h
> +++ b/drivers/staging/dgnc/dgnc_driver.h
> @@ -312,8 +312,6 @@ struct un_t {
> * @ch_err_overrun: Count of overruns on channel.
> * @ch_xon_sends: Count of xons transmitted.
> * @ch_xoff_sends: Count of xoffs transmitted.
> - * @proc_entry_pointer: Proc/<board>/<channel> entry.
> - * @dgnc_channel_table: Proc/<board>/<channel> entry.
> */
> struct channel_t {
> struct dgnc_board *ch_bd;
> @@ -382,10 +380,6 @@ struct channel_t {
>
> ulong ch_xon_sends;
> ulong ch_xoff_sends;
> -
> - struct proc_dir_entry *proc_entry_pointer;
> - struct dgnc_proc_entry *dgnc_channel_table;
> -
> };
>
> extern uint dgnc_major; /* Our driver/mgmt major */
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
> To post to this group, send email to [email protected].
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/a57f835fc443d51ae9eadd1b995435c215f14974.1505579409.git.srishtishar%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>