2023-02-08 10:25:46

by Rafał Miłecki

[permalink] [raw]
Subject: Re: [PATCH v3 2/2] nvmem: brcm_nvram: use bcm47xx buffered data

On 7.02.2023 09:42, Willem-Jan de Hoog wrote:
> From: Willem-Jan de Hoog <[email protected]>
>
> The bcm47xx module has a copy of the NVRAM data in ram. When available, use
> this one instead of reading from io memory since it causes mtd/ubi to fail.

This doesn't explain anything. Why do we need that? If anything we
should rather get rid of that NVRAM firmware driver. It was needed
before we had all NVMEM stuff in place. Finally how can reading
iomem break mtd/ubi?!

It seems like some hack instead of proper fix. Possibly because of lack
of understanding the issue / some subsystem.


2023-02-08 10:30:49

by Arınç ÜNAL

[permalink] [raw]
Subject: Re: [PATCH v3 2/2] nvmem: brcm_nvram: use bcm47xx buffered data

On 8.02.2023 13:25, Rafał Miłecki wrote:
> On 7.02.2023 09:42, Willem-Jan de Hoog wrote:
>> From: Willem-Jan de Hoog <[email protected]>
>>
>> The bcm47xx module has a copy of the NVRAM data in ram. When
>> available, use
>> this one instead of reading from io memory since it causes mtd/ubi to
>> fail.
>
> This doesn't explain anything. Why do we need that? If anything we
> should rather get rid of that NVRAM firmware driver. It was needed
> before we had all NVMEM stuff in place. Finally how can reading
> iomem break mtd/ubi?!

Did you take a look at the bootlog on this post on the thread, I've
mentioned your user handle a few times but received no response on the
forum.

https://forum.openwrt.org/t/asus-rt-ac88u-hw-a6-broken-in-22-03-3/147882/6?u=arinc9

Arınç

2023-02-08 10:45:24

by Rafał Miłecki

[permalink] [raw]
Subject: Re: [PATCH v3 2/2] nvmem: brcm_nvram: use bcm47xx buffered data

On 8.02.2023 11:29, Arınç ÜNAL wrote:
> On 8.02.2023 13:25, Rafał Miłecki wrote:
>> On 7.02.2023 09:42, Willem-Jan de Hoog wrote:
>>> From: Willem-Jan de Hoog <[email protected]>
>>>
>>> The bcm47xx module has a copy of the NVRAM data in ram. When available, use
>>> this one instead of reading from io memory since it causes mtd/ubi to fail.
>>
>> This doesn't explain anything. Why do we need that? If anything we
>> should rather get rid of that NVRAM firmware driver. It was needed
>> before we had all NVMEM stuff in place. Finally how can reading
>> iomem break mtd/ubi?!
>
> Did you take a look at the bootlog on this post on the thread, I've mentioned your user handle a few times but received no response on the forum.
>
> https://forum.openwrt.org/t/asus-rt-ac88u-hw-a6-broken-in-22-03-3/147882/6?u=arinc9

Well, it doesn't really matter *in context* of getting this patch
accepted for mainline. It needs to be properly described on its own so
people can review it without looking through dozens of forum posts.

Sorry for not following that closely, I lagged behind due to my work on
other Broadcom topics. Broken LZMA, broken Linksys device support,
broken BCM5358. I'll see if I can figure out sth from that thread.