2024-02-11 00:40:40

by Christian Heusel

[permalink] [raw]
Subject: [PATCH] jffs2: print symbolic error name instead of error code

Utilize the %pe print specifier to get the symbolic error name as a
string (i.e "-ENOMEM") in the log message instead of the error code to
increase its readablility.

This change was suggested in
https://lore.kernel.org/all/[email protected]/

Signed-off-by: Christian Heusel <[email protected]>
---
fs/jffs2/background.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/jffs2/background.c b/fs/jffs2/background.c
index 6da92ecaf66d..bb0ee1a59e71 100644
--- a/fs/jffs2/background.c
+++ b/fs/jffs2/background.c
@@ -44,8 +44,8 @@ int jffs2_start_garbage_collect_thread(struct jffs2_sb_info *c)

tsk = kthread_run(jffs2_garbage_collect_thread, c, "jffs2_gcd_mtd%d", c->mtd->index);
if (IS_ERR(tsk)) {
- pr_warn("fork failed for JFFS2 garbage collect thread: %ld\n",
- -PTR_ERR(tsk));
+ pr_warn("fork failed for JFFS2 garbage collect thread: %pe\n",
+ tsk);
complete(&c->gc_thread_exit);
ret = PTR_ERR(tsk);
} else {
--
2.43.1



2024-02-18 01:14:05

by Zhihao Cheng

[permalink] [raw]
Subject: Re: [PATCH] jffs2: print symbolic error name instead of error code

?? 2024/2/11 8:39, Christian Heusel д??:
> Utilize the %pe print specifier to get the symbolic error name as a
> string (i.e "-ENOMEM") in the log message instead of the error code to
> increase its readablility.
>
> This change was suggested in
> https://lore.kernel.org/all/[email protected]/
>
> Signed-off-by: Christian Heusel <[email protected]>
> ---
> fs/jffs2/background.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Zhihao Cheng <[email protected]>
>
> diff --git a/fs/jffs2/background.c b/fs/jffs2/background.c
> index 6da92ecaf66d..bb0ee1a59e71 100644
> --- a/fs/jffs2/background.c
> +++ b/fs/jffs2/background.c
> @@ -44,8 +44,8 @@ int jffs2_start_garbage_collect_thread(struct jffs2_sb_info *c)
>
> tsk = kthread_run(jffs2_garbage_collect_thread, c, "jffs2_gcd_mtd%d", c->mtd->index);
> if (IS_ERR(tsk)) {
> - pr_warn("fork failed for JFFS2 garbage collect thread: %ld\n",
> - -PTR_ERR(tsk));
> + pr_warn("fork failed for JFFS2 garbage collect thread: %pe\n",
> + tsk);
> complete(&c->gc_thread_exit);
> ret = PTR_ERR(tsk);
> } else {
> --
> 2.43.1
>
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
> .
>


2024-03-11 12:48:23

by Christian Heusel

[permalink] [raw]
Subject: Re: [PATCH] jffs2: print symbolic error name instead of error code

On 24/02/11 01:39AM, Christian Heusel wrote:
> Utilize the %pe print specifier to get the symbolic error name as a
> string (i.e "-ENOMEM") in the log message instead of the error code to
> increase its readablility.
>
> This change was suggested in
> https://lore.kernel.org/all/[email protected]/
>
> Signed-off-by: Christian Heusel <[email protected]>
> ---
> fs/jffs2/background.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/jffs2/background.c b/fs/jffs2/background.c
> index 6da92ecaf66d..bb0ee1a59e71 100644
> --- a/fs/jffs2/background.c
> +++ b/fs/jffs2/background.c
> @@ -44,8 +44,8 @@ int jffs2_start_garbage_collect_thread(struct jffs2_sb_info *c)
>
> tsk = kthread_run(jffs2_garbage_collect_thread, c, "jffs2_gcd_mtd%d", c->mtd->index);
> if (IS_ERR(tsk)) {
> - pr_warn("fork failed for JFFS2 garbage collect thread: %ld\n",
> - -PTR_ERR(tsk));
> + pr_warn("fork failed for JFFS2 garbage collect thread: %pe\n",
> + tsk);
> complete(&c->gc_thread_exit);
> ret = PTR_ERR(tsk);
> } else {
> --
> 2.43.1

Friendly ping on the above patch, since it's now a month after sending
it :)

Cheers,
chris

Attachments:
(No filename) (1.21 kB)
 signature.asc (849.00 B)
 Download all attachments

2024-03-11 12:56:44

by Richard Weinberger

[permalink] [raw]
Subject: Re: [PATCH] jffs2: print symbolic error name instead of error code

----- Ursprüngliche Mail -----
> Von: "Christian Heusel" <[email protected]>
> An: "David Woodhouse" <[email protected]>, "richard" <[email protected]>, "linux-mtd" <[email protected]>,
> "linux-kernel" <[email protected]>
> CC: "kernel-janitors" <[email protected]>
> Gesendet: Montag, 11. März 2024 13:47:40
> Betreff: Re: [PATCH] jffs2: print symbolic error name instead of error code

> On 24/02/11 01:39AM, Christian Heusel wrote:
>> Utilize the %pe print specifier to get the symbolic error name as a
>> string (i.e "-ENOMEM") in the log message instead of the error code to
>> increase its readablility.
>>
>> This change was suggested in
>> https://lore.kernel.org/all/[email protected]/
>>
>> Signed-off-by: Christian Heusel <[email protected]>
>> ---
>> fs/jffs2/background.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/jffs2/background.c b/fs/jffs2/background.c
>> index 6da92ecaf66d..bb0ee1a59e71 100644
>> --- a/fs/jffs2/background.c
>> +++ b/fs/jffs2/background.c
>> @@ -44,8 +44,8 @@ int jffs2_start_garbage_collect_thread(struct jffs2_sb_info
>> *c)
>>
>> tsk = kthread_run(jffs2_garbage_collect_thread, c, "jffs2_gcd_mtd%d",
>> c->mtd->index);
>> if (IS_ERR(tsk)) {
>> - pr_warn("fork failed for JFFS2 garbage collect thread: %ld\n",
>> - -PTR_ERR(tsk));
>> + pr_warn("fork failed for JFFS2 garbage collect thread: %pe\n",
>> + tsk);
>> complete(&c->gc_thread_exit);
>> ret = PTR_ERR(tsk);
>> } else {
>> --
>> 2.43.1
>
> Friendly ping on the above patch, since it's now a month after sending
> it :)

Thanks for the ping. Your patch looks good. I'll queue it.

Thanks,
//richard