2020-03-17 04:54:06

by Rayagonda Kokatanur

Subject: [PATCH v1 1/1] firmware: tee_bnxt: remove unused variable init

Remove unused variable initialization.

Signed-off-by: Rayagonda Kokatanur <[email protected]>
---
drivers/firmware/broadcom/tee_bnxt_fw.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c
index ed10da5313e8..6fd62657e35f 100644
--- a/drivers/firmware/broadcom/tee_bnxt_fw.c
+++ b/drivers/firmware/broadcom/tee_bnxt_fw.c
@@ -143,8 +143,6 @@ int tee_bnxt_copy_coredump(void *buf, u32 offset, u32 size)
prepare_args(TA_CMD_BNXT_COPY_COREDUMP, &arg, param);

while (rbytes) {
- nbytes = rbytes;
-
nbytes = min_t(u32, rbytes, param[0].u.memref.size);

/* Fill additional invoke cmd params */
--
2.17.1

2020-03-17 09:10:32

by Sergei Shtylyov

Subject: Re: [PATCH v1 1/1] firmware: tee_bnxt: remove unused variable init

Hello!

On 17.03.2020 7:07, Rayagonda Kokatanur wrote:

> Remove unused variable initialization.

I think it's not an initialization, it's an assignment. :-)

> Signed-off-by: Rayagonda Kokatanur <[email protected]>
> ---
> drivers/firmware/broadcom/tee_bnxt_fw.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c
> index ed10da5313e8..6fd62657e35f 100644
> --- a/drivers/firmware/broadcom/tee_bnxt_fw.c
> +++ b/drivers/firmware/broadcom/tee_bnxt_fw.c
> @@ -143,8 +143,6 @@ int tee_bnxt_copy_coredump(void *buf, u32 offset, u32 size)
> prepare_args(TA_CMD_BNXT_COPY_COREDUMP, &arg, param);
>
> while (rbytes) {
> - nbytes = rbytes;
> -
> nbytes = min_t(u32, rbytes, param[0].u.memref.size);
>
> /* Fill additional invoke cmd params */

MBR, Sergei

2020-03-17 09:55:37

by Rayagonda Kokatanur

Subject: Re: [PATCH v1 1/1] firmware: tee_bnxt: remove unused variable init

On Tue, Mar 17, 2020 at 2:39 PM Sergei Shtylyov
<[email protected]> wrote:
>
> Hello!
>
> On 17.03.2020 7:07, Rayagonda Kokatanur wrote:
>
> > Remove unused variable initialization.
>
> I think it's not an initialization, it's an assignment. :-)
Thanks will fix it and send v2.
>
> > Signed-off-by: Rayagonda Kokatanur <[email protected]>
> > ---
> > drivers/firmware/broadcom/tee_bnxt_fw.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c
> > index ed10da5313e8..6fd62657e35f 100644
> > --- a/drivers/firmware/broadcom/tee_bnxt_fw.c
> > +++ b/drivers/firmware/broadcom/tee_bnxt_fw.c
> > @@ -143,8 +143,6 @@ int tee_bnxt_copy_coredump(void *buf, u32 offset, u32 size)
> > prepare_args(TA_CMD_BNXT_COPY_COREDUMP, &arg, param);
> >
> > while (rbytes) {
> > - nbytes = rbytes;
> > -
> > nbytes = min_t(u32, rbytes, param[0].u.memref.size);
> >
> > /* Fill additional invoke cmd params */
>
> MBR, Sergei