2024-01-12 04:20:12

by Su Hui

Subject: [PATCH] scsi: isci: request: Fix an error code problem in isci_io_request_build

Clang static complains that Value stored to 'status' is never read.
Return 'status' rather than 'SCI_SUCCESS'.

Fixes: f1f52e75939b ("isci: uplevel request infrastructure")
Signed-off-by: Su Hui <[email protected]>
---
drivers/scsi/isci/request.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/isci/request.c b/drivers/scsi/isci/request.c
index 71f711cb0628..355a0bc0828e 100644
--- a/drivers/scsi/isci/request.c
+++ b/drivers/scsi/isci/request.c
@@ -3387,7 +3387,7 @@ static enum sci_status isci_io_request_build(struct isci_host *ihost,
return SCI_FAILURE;
}

- return SCI_SUCCESS;
+ return status;
}

static struct isci_request *isci_request_from_tag(struct isci_host *ihost, u16 tag)
--
2.30.2

2024-01-15 08:46:14

by Artur Paszkiewicz

Subject: Re: [PATCH] scsi: isci: request: Fix an error code problem in isci_io_request_build

On 1/12/24 05:19, Su Hui wrote:
> Clang static complains that Value stored to 'status' is never read.
> Return 'status' rather than 'SCI_SUCCESS'.
>
> Fixes: f1f52e75939b ("isci: uplevel request infrastructure")
> Signed-off-by: Su Hui <[email protected]>

Reviewed-by: Artur Paszkiewicz <[email protected]>

2024-01-17 19:45:20

by Martin K. Petersen

Subject: Re: [PATCH] scsi: isci: request: Fix an error code problem in isci_io_request_build

> Clang static complains that Value stored to 'status' is never read.
> Return 'status' rather than 'SCI_SUCCESS'.

Applied to 6.8/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering