2022-10-31 16:16:56

by Colin Ian King

Subject: [PATCH] scsi: BusLogic: remove variable adapter_count

Variable adapter_count is just being incremented and it's never used
anywhere else. The variable and the increment are redundant so
remove it.

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/scsi/BusLogic.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/scsi/BusLogic.c b/drivers/scsi/BusLogic.c
index f2abffce2659..f7b7ffda1161 100644
--- a/drivers/scsi/BusLogic.c
+++ b/drivers/scsi/BusLogic.c
@@ -2198,7 +2198,7 @@ static int blogic_slaveconfig(struct scsi_device *dev)

static int __init blogic_init(void)
{
- int adapter_count = 0, drvr_optindex = 0, probeindex;
+ int drvr_optindex = 0, probeindex;
struct blogic_adapter *adapter;
int ret = 0;

@@ -2368,10 +2368,8 @@ static int __init blogic_init(void)
list_del(&myadapter->host_list);
scsi_host_put(host);
ret = -ENODEV;
- } else {
+ } else
scsi_scan_host(host);
- adapter_count++;
- }
}
} else {
/*
--
2.37.3

2022-10-31 16:50:18

by Khalid Aziz

Subject: Re: [PATCH] scsi: BusLogic: remove variable adapter_count

On 10/31/22 10:05, Colin Ian King wrote:
> Variable adapter_count is just being incremented and it's never used
> anywhere else. The variable and the increment are redundant so
> remove it.
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/scsi/BusLogic.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)

Looks good to me.

Acked-by: Khalid Aziz <[email protected]>


>
> diff --git a/drivers/scsi/BusLogic.c b/drivers/scsi/BusLogic.c
> index f2abffce2659..f7b7ffda1161 100644
> --- a/drivers/scsi/BusLogic.c
> +++ b/drivers/scsi/BusLogic.c
> @@ -2198,7 +2198,7 @@ static int blogic_slaveconfig(struct scsi_device *dev)
>
> static int __init blogic_init(void)
> {
> - int adapter_count = 0, drvr_optindex = 0, probeindex;
> + int drvr_optindex = 0, probeindex;
> struct blogic_adapter *adapter;
> int ret = 0;
>
> @@ -2368,10 +2368,8 @@ static int __init blogic_init(void)
> list_del(&myadapter->host_list);
> scsi_host_put(host);
> ret = -ENODEV;
> - } else {
> + } else
> scsi_scan_host(host);
> - adapter_count++;
> - }
> }
> } else {
> /*

2022-11-08 03:34:30

by Martin K. Petersen

Subject: Re: [PATCH] scsi: BusLogic: remove variable adapter_count

Colin,

> Variable adapter_count is just being incremented and it's never used
> anywhere else. The variable and the increment are redundant so
> remove it.

Applied to 6.2/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering

2022-11-17 18:35:22

by Martin K. Petersen

Subject: Re: [PATCH] scsi: BusLogic: remove variable adapter_count

On Mon, 31 Oct 2022 16:05:12 +0000, Colin Ian King wrote:

> Variable adapter_count is just being incremented and it's never used
> anywhere else. The variable and the increment are redundant so
> remove it.
>
>

Applied to 6.2/scsi-queue, thanks!

[1/1] scsi: BusLogic: remove variable adapter_count
https://git.kernel.org/mkp/scsi/c/81cb3eb68af5

--
Martin K. Petersen Oracle Linux Engineering