2022-04-19 11:22:04

by Yunbo Yu

Subject: [PATCH] dmaengine: plx_dma: Move spin_lock_bh() to spin_lock()

It is unnecessary to call spin_lock_bh() for you are already in a tasklet.

Signed-off-by: Yunbo Yu <[email protected]>
---
drivers/dma/plx_dma.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/dma/plx_dma.c b/drivers/dma/plx_dma.c
index 1ffcb5ca9788..12725fa1655f 100644
--- a/drivers/dma/plx_dma.c
+++ b/drivers/dma/plx_dma.c
@@ -137,7 +137,7 @@ static void plx_dma_process_desc(struct plx_dma_dev *plxdev)
struct plx_dma_desc *desc;
u32 flags;

- spin_lock_bh(&plxdev->ring_lock);
+ spin_lock(&plxdev->ring_lock);

while (plxdev->tail != plxdev->head) {
desc = plx_dma_get_desc(plxdev, plxdev->tail);
@@ -165,7 +165,7 @@ static void plx_dma_process_desc(struct plx_dma_dev *plxdev)
plxdev->tail++;
}

- spin_unlock_bh(&plxdev->ring_lock);
+ spin_unlock(&plxdev->ring_lock);
}

static void plx_dma_abort_desc(struct plx_dma_dev *plxdev)
--
2.25.1

2022-04-19 15:30:21

by Logan Gunthorpe

Subject: Re: [PATCH] dmaengine: plx_dma: Move spin_lock_bh() to spin_lock()

On 2022-04-18 08:20, Yunbo Yu wrote:
> It is unnecessary to call spin_lock_bh() for you are already in a tasklet.
>
> Signed-off-by: Yunbo Yu <[email protected]>

Ah, thanks!

Reviewed-by: Logan Gunthorpe <[email protected]>

> ---
> drivers/dma/plx_dma.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/plx_dma.c b/drivers/dma/plx_dma.c
> index 1ffcb5ca9788..12725fa1655f 100644
> --- a/drivers/dma/plx_dma.c
> +++ b/drivers/dma/plx_dma.c
> @@ -137,7 +137,7 @@ static void plx_dma_process_desc(struct plx_dma_dev *plxdev)
> struct plx_dma_desc *desc;
> u32 flags;
>
> - spin_lock_bh(&plxdev->ring_lock);
> + spin_lock(&plxdev->ring_lock);
>
> while (plxdev->tail != plxdev->head) {
> desc = plx_dma_get_desc(plxdev, plxdev->tail);
> @@ -165,7 +165,7 @@ static void plx_dma_process_desc(struct plx_dma_dev *plxdev)
> plxdev->tail++;
> }
>
> - spin_unlock_bh(&plxdev->ring_lock);
> + spin_unlock(&plxdev->ring_lock);
> }
>
> static void plx_dma_abort_desc(struct plx_dma_dev *plxdev)

2022-04-21 04:57:06

by Vinod Koul

Subject: Re: [PATCH] dmaengine: plx_dma: Move spin_lock_bh() to spin_lock()

On 18-04-22, 22:20, Yunbo Yu wrote:
> It is unnecessary to call spin_lock_bh() for you are already in a tasklet.

call spin_lock_bh() if you are already in a ..


With that fixed, applied. Thanks
>
> Signed-off-by: Yunbo Yu <[email protected]>
> ---
> drivers/dma/plx_dma.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/plx_dma.c b/drivers/dma/plx_dma.c
> index 1ffcb5ca9788..12725fa1655f 100644
> --- a/drivers/dma/plx_dma.c
> +++ b/drivers/dma/plx_dma.c
> @@ -137,7 +137,7 @@ static void plx_dma_process_desc(struct plx_dma_dev *plxdev)
> struct plx_dma_desc *desc;
> u32 flags;
>
> - spin_lock_bh(&plxdev->ring_lock);
> + spin_lock(&plxdev->ring_lock);
>
> while (plxdev->tail != plxdev->head) {
> desc = plx_dma_get_desc(plxdev, plxdev->tail);
> @@ -165,7 +165,7 @@ static void plx_dma_process_desc(struct plx_dma_dev *plxdev)
> plxdev->tail++;
> }
>
> - spin_unlock_bh(&plxdev->ring_lock);
> + spin_unlock(&plxdev->ring_lock);
> }
>
> static void plx_dma_abort_desc(struct plx_dma_dev *plxdev)
> --
> 2.25.1

--
~Vinod