2023-06-08 16:35:01

by Johan Jonker

Subject: [PATCH v1 3/5] mtd: nand: raw: rockchip-nand-controller: fix nand timing default

Somehow not all NAND chips give a valid timing setting with the
nand_get_sdr_timings() function. Don't consider it as an error,
but fall back to the default value in order to continue to use
the driver.

Signed-off-by: Johan Jonker <[email protected]>
---
drivers/mtd/nand/raw/rockchip-nand-controller.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/nand/raw/rockchip-nand-controller.c b/drivers/mtd/nand/raw/rockchip-nand-controller.c
index f56430f6c..e39431cfa 100644
--- a/drivers/mtd/nand/raw/rockchip-nand-controller.c
+++ b/drivers/mtd/nand/raw/rockchip-nand-controller.c
@@ -429,8 +429,10 @@ static int rk_nfc_setup_interface(struct nand_chip *chip, int target,
return 0;

timings = nand_get_sdr_timings(conf);
- if (IS_ERR(timings))
- return -EOPNOTSUPP;
+ if (IS_ERR(timings)) {
+ rknand->timing = 0x1081;
+ return 0;
+ }

if (IS_ERR(nfc->nfc_clk))
rate = clk_get_rate(nfc->ahb_clk);
--
2.30.2

2023-06-09 08:55:01

by Miquel Raynal

Subject: Re: [PATCH v1 3/5] mtd: nand: raw: rockchip-nand-controller: fix nand timing default

Hi Johan,

[email protected] wrote on Thu, 8 Jun 2023 18:30:40 +0200:

> Somehow not all NAND chips give a valid timing setting with the
> nand_get_sdr_timings() function.

nand_get_sdr_timings() is a core function and is not particularly
clever. All chips are supposed to support SDR mode 0 so if you chip
does not advertises that the chip is broken, not the controller. This
must be fixed in the chip manufacturer driver, not in the controller
driver.

> Don't consider it as an error,
> but fall back to the default value in order to continue to use
> the driver.
>
> Signed-off-by: Johan Jonker <[email protected]>
> ---
> drivers/mtd/nand/raw/rockchip-nand-controller.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/rockchip-nand-controller.c b/drivers/mtd/nand/raw/rockchip-nand-controller.c
> index f56430f6c..e39431cfa 100644
> --- a/drivers/mtd/nand/raw/rockchip-nand-controller.c
> +++ b/drivers/mtd/nand/raw/rockchip-nand-controller.c
> @@ -429,8 +429,10 @@ static int rk_nfc_setup_interface(struct nand_chip *chip, int target,
> return 0;
>
> timings = nand_get_sdr_timings(conf);
> - if (IS_ERR(timings))
> - return -EOPNOTSUPP;
> + if (IS_ERR(timings)) {
> + rknand->timing = 0x1081;

This is way to magical anyway :)

> + return 0;
> + }
>
> if (IS_ERR(nfc->nfc_clk))
> rate = clk_get_rate(nfc->ahb_clk);
> --
> 2.30.2
>


Thanks,
Miquèl