2016-11-24 18:12:08

by Gary Bisson

Subject: [PATCH] pinctrl: imx: fix imx_pinctrl_desc initialization

Was introduced by:
6e408ed pinctrl: imx: fix initialization of imx_pinctrl_desc

Signed-off-by: Gary Bisson <[email protected]>
---
drivers/pinctrl/freescale/pinctrl-imx.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c
index 79c4e14..5ef7e87 100644
--- a/drivers/pinctrl/freescale/pinctrl-imx.c
+++ b/drivers/pinctrl/freescale/pinctrl-imx.c
@@ -778,10 +778,10 @@ int imx_pinctrl_probe(struct platform_device *pdev,
imx_pinctrl_desc->name = dev_name(&pdev->dev);
imx_pinctrl_desc->pins = info->pins;
imx_pinctrl_desc->npins = info->npins;
- imx_pinctrl_desc->pctlops = &imx_pctrl_ops,
- imx_pinctrl_desc->pmxops = &imx_pmx_ops,
- imx_pinctrl_desc->confops = &imx_pinconf_ops,
- imx_pinctrl_desc->owner = THIS_MODULE,
+ imx_pinctrl_desc->pctlops = &imx_pctrl_ops;
+ imx_pinctrl_desc->pmxops = &imx_pmx_ops;
+ imx_pinctrl_desc->confops = &imx_pinconf_ops;
+ imx_pinctrl_desc->owner = THIS_MODULE;

ret = imx_pinctrl_probe_dt(pdev, info);
if (ret) {
--
2.9.3

2016-11-24 18:22:03

by Gary Bisson

Subject: Re: [PATCH] pinctrl: imx: fix imx_pinctrl_desc initialization

Hi all,

Just resending this email since there was a typo in Shawn's e-mail
address.

Regards,
Gary

On Thu, Nov 24, 2016 at 07:11:51PM +0100, Gary Bisson wrote:
> Was introduced by:
> 6e408ed pinctrl: imx: fix initialization of imx_pinctrl_desc
>
> Signed-off-by: Gary Bisson <[email protected]>
> ---
> drivers/pinctrl/freescale/pinctrl-imx.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c
> index 79c4e14..5ef7e87 100644
> --- a/drivers/pinctrl/freescale/pinctrl-imx.c
> +++ b/drivers/pinctrl/freescale/pinctrl-imx.c
> @@ -778,10 +778,10 @@ int imx_pinctrl_probe(struct platform_device *pdev,
> imx_pinctrl_desc->name = dev_name(&pdev->dev);
> imx_pinctrl_desc->pins = info->pins;
> imx_pinctrl_desc->npins = info->npins;
> - imx_pinctrl_desc->pctlops = &imx_pctrl_ops,
> - imx_pinctrl_desc->pmxops = &imx_pmx_ops,
> - imx_pinctrl_desc->confops = &imx_pinconf_ops,
> - imx_pinctrl_desc->owner = THIS_MODULE,
> + imx_pinctrl_desc->pctlops = &imx_pctrl_ops;
> + imx_pinctrl_desc->pmxops = &imx_pmx_ops;
> + imx_pinctrl_desc->confops = &imx_pinconf_ops;
> + imx_pinctrl_desc->owner = THIS_MODULE;
>
> ret = imx_pinctrl_probe_dt(pdev, info);
> if (ret) {
> --
> 2.9.3
>

2016-11-24 20:18:11

by Vladimir Zapolskiy

Subject: Re: [PATCH] pinctrl: imx: fix imx_pinctrl_desc initialization

Hi Gary,

On 11/24/2016 08:11 PM, Gary Bisson wrote:
> Was introduced by:
> 6e408ed pinctrl: imx: fix initialization of imx_pinctrl_desc
>
> Signed-off-by: Gary Bisson <[email protected]>
> ---
> drivers/pinctrl/freescale/pinctrl-imx.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c
> index 79c4e14..5ef7e87 100644
> --- a/drivers/pinctrl/freescale/pinctrl-imx.c
> +++ b/drivers/pinctrl/freescale/pinctrl-imx.c
> @@ -778,10 +778,10 @@ int imx_pinctrl_probe(struct platform_device *pdev,
> imx_pinctrl_desc->name = dev_name(&pdev->dev);
> imx_pinctrl_desc->pins = info->pins;
> imx_pinctrl_desc->npins = info->npins;
> - imx_pinctrl_desc->pctlops = &imx_pctrl_ops,
> - imx_pinctrl_desc->pmxops = &imx_pmx_ops,
> - imx_pinctrl_desc->confops = &imx_pinconf_ops,
> - imx_pinctrl_desc->owner = THIS_MODULE,
> + imx_pinctrl_desc->pctlops = &imx_pctrl_ops;
> + imx_pinctrl_desc->pmxops = &imx_pmx_ops;
> + imx_pinctrl_desc->confops = &imx_pinconf_ops;
> + imx_pinctrl_desc->owner = THIS_MODULE;
>
> ret = imx_pinctrl_probe_dt(pdev, info);
> if (ret) {
>

excellent catch, my compiler does not report the issue.

Subject and commit message are not quite informative, but
the change is trivial, so please feel free to add my

Reviewed-by: Vladimir Zapolskiy <[email protected]>

--
With best wishes,
Vladimir

2016-11-25 01:17:12

by Peng Fan

Subject: Re: [PATCH] pinctrl: imx: fix imx_pinctrl_desc initialization

Hi Gary,

On Thu, Nov 24, 2016 at 07:11:51PM +0100, Gary Bisson wrote:
>Was introduced by:
>6e408ed pinctrl: imx: fix initialization of imx_pinctrl_desc
>
>Signed-off-by: Gary Bisson <[email protected]>
>---
> drivers/pinctrl/freescale/pinctrl-imx.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c
>index 79c4e14..5ef7e87 100644
>--- a/drivers/pinctrl/freescale/pinctrl-imx.c
>+++ b/drivers/pinctrl/freescale/pinctrl-imx.c
>@@ -778,10 +778,10 @@ int imx_pinctrl_probe(struct platform_device *pdev,
> imx_pinctrl_desc->name = dev_name(&pdev->dev);
> imx_pinctrl_desc->pins = info->pins;
> imx_pinctrl_desc->npins = info->npins;
>- imx_pinctrl_desc->pctlops = &imx_pctrl_ops,
>- imx_pinctrl_desc->pmxops = &imx_pmx_ops,
>- imx_pinctrl_desc->confops = &imx_pinconf_ops,
>- imx_pinctrl_desc->owner = THIS_MODULE,
>+ imx_pinctrl_desc->pctlops = &imx_pctrl_ops;
>+ imx_pinctrl_desc->pmxops = &imx_pmx_ops;
>+ imx_pinctrl_desc->confops = &imx_pinconf_ops;
>+ imx_pinctrl_desc->owner = THIS_MODULE;

Thanks for the fix.

Reviewed-by: Peng Fan <[email protected]>

>
> ret = imx_pinctrl_probe_dt(pdev, info);
> if (ret) {
>--
>2.9.3
>

--

2016-11-25 13:11:48

by Linus Walleij

Subject: Re: [PATCH] pinctrl: imx: fix imx_pinctrl_desc initialization

On Thu, Nov 24, 2016 at 7:11 PM, Gary Bisson
<[email protected]> wrote:

> Was introduced by:
> 6e408ed pinctrl: imx: fix initialization of imx_pinctrl_desc
>
> Signed-off-by: Gary Bisson <[email protected]>

Patch applied with the review tags.

Yours,
Linus Walleij