2024-04-08 03:08:42

by Mirela Rabulea

[permalink] [raw]
Subject: [PATCH v4 1/2] dt-bindings: media: imx8-jpeg: Add clocks entries

From: Fabio Estevam <[email protected]>

The JPEG decoder/encoder present in iMX8QXP and iMX8QM SoCs need
the PER and IPG clocks to be functional, so add the clock entries.

This also fixes the following schema warning:

imx8qm-apalis-eval.dtb: jpegdec@58400000: 'assigned-clock-rates', 'assigned-clocks', 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/media/nxp,imx8-jpeg.yaml#

Signed-off-by: Fabio Estevam <[email protected]>
Signed-off-by: Mirela Rabulea <[email protected]>
---

Changes since v3:
- Add items for clocks (per Krzysztof's feddback)
- Add description for clocks (per Conor's feddback to the other similar patch from Alexander)
- Add "media:" to the subject
- Add Mirela's signed-off
- For the similar patches that were sent for this issue, should Co-developed-by/Signed-off-by be added? Alexander Stein? Frank Li?

Changes since v2:
- Remove clock-names. (Mirela)

.../devicetree/bindings/media/nxp,imx8-jpeg.yaml | 14 ++++++++++++++
1 file changed, 14 insertions(+)

diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
index 3d9d1db37040..cc040feb77d7 100644
--- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
+++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
@@ -31,6 +31,14 @@ properties:
reg:
maxItems: 1

+ clocks:
+ description:
+ The JPEG decoder/encoder requires two clocks for it's wrapper (AXI and APB),
+ and one clock for it's core engine (AXI, same source as for the wrapper)
+ items:
+ - description: AXI DMA engine clock for fetching JPEG bitstream from memory (per)
+ - description: IP bus clock for register access (ipg)
+
interrupts:
description: |
There are 4 slots available in the IP, which the driver may use
@@ -49,6 +57,7 @@ properties:
required:
- compatible
- reg
+ - clocks
- interrupts
- power-domains

@@ -56,12 +65,15 @@ additionalProperties: false

examples:
- |
+ #include <dt-bindings/clock/imx8-lpcg.h>
#include <dt-bindings/interrupt-controller/arm-gic.h>
#include <dt-bindings/firmware/imx/rsrc.h>

jpegdec: jpegdec@58400000 {
compatible = "nxp,imx8qxp-jpgdec";
reg = <0x58400000 0x00050000 >;
+ clocks = <&img_jpeg_dec_lpcg IMX_LPCG_CLK_0>,
+ <&img_jpeg_dec_lpcg IMX_LPCG_CLK_4>;
interrupts = <GIC_SPI 309 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 310 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 311 IRQ_TYPE_LEVEL_HIGH>,
@@ -76,6 +88,8 @@ examples:
jpegenc: jpegenc@58450000 {
compatible = "nxp,imx8qm-jpgenc", "nxp,imx8qxp-jpgenc";
reg = <0x58450000 0x00050000 >;
+ clocks = <&img_jpeg_enc_lpcg IMX_LPCG_CLK_0>,
+ <&img_jpeg__lpcg IMX_LPCG_CLK_4>;
interrupts = <GIC_SPI 305 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 306 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 307 IRQ_TYPE_LEVEL_HIGH>,
--
2.25.1



2024-04-08 06:38:33

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v4 1/2] dt-bindings: media: imx8-jpeg: Add clocks entries

On 08/04/2024 05:07, Mirela Rabulea wrote:
> From: Fabio Estevam <[email protected]>
>
> The JPEG decoder/encoder present in iMX8QXP and iMX8QM SoCs need
> the PER and IPG clocks to be functional, so add the clock entries.
>
> This also fixes the following schema warning:
>
> imx8qm-apalis-eval.dtb: jpegdec@58400000: 'assigned-clock-rates', 'assigned-clocks', 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+'
> from schema $id: http://devicetree.org/schemas/media/nxp,imx8-jpeg.yaml#
>
> Signed-off-by: Fabio Estevam <[email protected]>
> Signed-off-by: Mirela Rabulea <[email protected]>
> ---
>

Please correct subject. You already got comments on this.
https://lore.kernel.org/linux-devicetree/[email protected]/

> Changes since v3:
> - Add items for clocks (per Krzysztof's feddback)
> - Add description for clocks (per Conor's feddback to the other similar patch from Alexander)
> - Add "media:" to the subject

Where? It was there before, so what did you change?


> - Add Mirela's signed-off
> - For the similar patches that were sent for this issue, should Co-developed-by/Signed-off-by be added? Alexander Stein? Frank Li?
>
> Changes since v2:
> - Remove clock-names. (Mirela)
>
> .../devicetree/bindings/media/nxp,imx8-jpeg.yaml | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
> index 3d9d1db37040..cc040feb77d7 100644
> --- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
> +++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
> @@ -31,6 +31,14 @@ properties:
> reg:
> maxItems: 1
>
> + clocks:
> + description:
> + The JPEG decoder/encoder requires two clocks for it's wrapper (AXI and APB),
> + and one clock for it's core engine (AXI, same source as for the wrapper)

Description is now redundant, drop it.

> + items:
> + - description: AXI DMA engine clock for fetching JPEG bitstream from memory (per)
> + - description: IP bus clock for register access (ipg)
> +
> interrupts:
> description: |
> There are 4 slots available in the IP, which the driver may use
> @@ -49,6 +57,7 @@ properties:
> required:
> - compatible
> - reg
> + - clocks
> - interrupts
> - power-domains

Best regards,
Krzysztof


2024-04-08 07:55:29

by Mirela Rabulea

[permalink] [raw]
Subject: Re: Re: [PATCH v4 1/2] dt-bindings: media: imx8-jpeg: Add clocks entries

Hi Krzysztof,

On 08.04.2024 09:38, Krzysztof Kozlowski wrote:
> Please correct subject. You already got comments on this.
> https://lore.kernel.org/linux-devicetree/[email protected]/

Sorry I missed that.

I will update the prefix to "media: dt-bindings: nxp,imx8-jpeg:". as you
suggested in v2.
>> Changes since v3:
>> - Add items for clocks (per Krzysztof's feddback)
>> - Add description for clocks (per Conor's feddback to the other similar patch from Alexander)
>> - Add "media:" to the subject
> Where? It was there before, so what did you change?

I started from v3 here:
https://lore.kernel.org/linux-devicetree/[email protected]/

The subject was: "[PATCH v3 1/3] dt-bindings: imx8-jpeg: Add clocks
entries", I had just added "media:". Anyways, will update it again.

>> + clocks:
>> + description:
>> + The JPEG decoder/encoder requires two clocks for it's wrapper (AXI and APB),
>> + and one clock for it's core engine (AXI, same source as for the wrapper)
> Description is now redundant, drop it.

Ok, I will do so in v5.

Thanks a lot for feedback,

Mirela