'make randconfig' can produce a .config file with
"CONFIG_MEMORY_RESERVE=" (no value) since it has no default.
When a subsequent 'make all' is done, kconfig restarts the config
and prompts for a value for MEMORY_RESERVE. This breaks
scripting/automation where there is no interactive user input.
Add a default value for MEMORY_RESERVE. (Any integer value will
work here for kconfig.)
Fixes a kconfig warning:
.config:214:warning: symbol value '' invalid for MEMORY_RESERVE
* Restart config...
Memory reservation (MiB) (MEMORY_RESERVE) [] (NEW)
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") # from beginning of git history
Signed-off-by: Randy Dunlap <[email protected]>
Cc: Geert Uytterhoeven <[email protected]>
Cc: Greg Ungerer <[email protected]>
Cc: [email protected]
---
arch/m68k/Kconfig.machine | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20211001.orig/arch/m68k/Kconfig.machine
+++ linux-next-20211001/arch/m68k/Kconfig.machine
@@ -203,6 +203,7 @@ config INIT_LCD
config MEMORY_RESERVE
int "Memory reservation (MiB)"
depends on (UCSIMM || UCDIMM)
+ default 0
help
Reserve certain memory regions on 68x328 based boards.
On Sun, Oct 3, 2021 at 2:02 AM Randy Dunlap <[email protected]> wrote:
> 'make randconfig' can produce a .config file with
> "CONFIG_MEMORY_RESERVE=" (no value) since it has no default.
> When a subsequent 'make all' is done, kconfig restarts the config
> and prompts for a value for MEMORY_RESERVE. This breaks
> scripting/automation where there is no interactive user input.
>
> Add a default value for MEMORY_RESERVE. (Any integer value will
> work here for kconfig.)
>
> Fixes a kconfig warning:
>
> .config:214:warning: symbol value '' invalid for MEMORY_RESERVE
> * Restart config...
> Memory reservation (MiB) (MEMORY_RESERVE) [] (NEW)
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") # from beginning of git history
> Signed-off-by: Randy Dunlap <[email protected]>
Reviewed-by: Geert Uytterhoeven <[email protected]>
As this is relevant for m68knommu, I'll leave it to Greg, unless he's too
busy.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
On 4/10/21 4:47 pm, Geert Uytterhoeven wrote:
> On Sun, Oct 3, 2021 at 2:02 AM Randy Dunlap <[email protected]> wrote:
>> 'make randconfig' can produce a .config file with
>> "CONFIG_MEMORY_RESERVE=" (no value) since it has no default.
>> When a subsequent 'make all' is done, kconfig restarts the config
>> and prompts for a value for MEMORY_RESERVE. This breaks
>> scripting/automation where there is no interactive user input.
>>
>> Add a default value for MEMORY_RESERVE. (Any integer value will
>> work here for kconfig.)
>>
>> Fixes a kconfig warning:
>>
>> .config:214:warning: symbol value '' invalid for MEMORY_RESERVE
>> * Restart config...
>> Memory reservation (MiB) (MEMORY_RESERVE) [] (NEW)
>>
>> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") # from beginning of git history
>> Signed-off-by: Randy Dunlap <[email protected]>
>
> Reviewed-by: Geert Uytterhoeven <[email protected]>
Acked-by: Greg Ungerer <[email protected]>
> As this is relevant for m68knommu, I'll leave it to Greg, unless he's too
> busy.
Thanks Geert. No problem though, I'll pick this up and push to
the m68knommu git tree.
Regards
Greg