2.2.19pre10
o Update aic7xxx driver to 5.1.33 (Doug Ledford)
o Revert shm change - its unsafe (Richard Nelson)
o Update sunrpc code, add rpc ping congestion (Trond Myklebust)
checks
o Fix wrong kfree in cosa driver (Jan Kasprzak)
o NFS client fixes (Trond Myklebust)
o Better dcache/inode hashes (Dave Miller)
o Fix missing skb->protocol init in AX.25 (Thomas Osterried)
o EEpro100 reporting fix as per 2.4 (Ion Badulescu)
o Starfire ethernet driver (Don Becker,
Ion Badulescu,
Jeff Garzik, ...)
o Memory handling fixes for ISDN core code (Kai Germaschewski)
o ISDN module locking fixes (Kai Germaschewski)
o Fix ISDN modem profile reading (Kai Germaschewski)
o Fix missing mark_bh calls in isdn (Kai Germaschewski)
o Fix problems make xconfig has with config (Andrzej Krzysztofowicz)
o Clean up isdn to user new __init etc (Kai Germaschewski)
2.2.19pre9
o Merge all the pending NFS server fixes (Neil Brown)
o Neil becomes NFS server maintainer (Neil Brown)
o Update to aic7xxx 5.1.32 (Doug Ledford)
o Fix cs89x0 media selection (Frank Copeland)
o Tidy APM stuff, make buggy bios selector tighter(Stephen Rothwell)
o Fix i2o config typo (YOSHIMURA Keitaro)
o Network updates, fix possible classifier hang (Dave Miller)
o Sparc updates (nfs compat, syscalls) (Dave Miller)
o Sparc watchdog driver (Eric Brower)
o Remove experimental tag on QoS code (Dave Miller)
o Move dumpable extra logic into binfmt avoiding (Solar Designer)
other changes to arch code. Back out old stuff
o Fix sysctl miscastings from signed/unsigned (Greg Kroah-Hartmann)
o Alpha OSF syscall remove error printk
o Don't trust IRQ routing on the ruffian ARC (Ivan Kokshaysky)
2.2.19pre8
o Add support for ICS1893 PHY to sis900 (L C Chang)
o Fix typo in nautilus code (Tom Vier)
o Clean up usb bandwidth messages (Randy Dunlap)
o USB ACM loosen up end point rules (Randy Dunlap)
o Fix tty module count corruptions (Maciej Rozycki)
o i2o block updates (Boji Kannanthanam)
o menuconfig updates (Kirk Reiser)
o Fix dmi/apm ordering bug (Keith Owens,
Neale Banks)
o Alpha SMP build fix (Herbert Xu)
o Fix igmp bugs (Stefan Jonsson)
o Fix USB config.in problems (Greg Kroah-Hartmann)
o Update Cort Dougan's info (Cort Dougan)
o Update to 2.4.0 style A20 gate handler (Randy Dunlap)
o Fix unneeded compat defines on S/390 ctc (Kurt Roeckx)
o Macintosh HID driver fixes (Cort Dougan)
o Fix ppc config/input layer and ksyms (Cort Dougan)
o ISDN updates (Kai Germaschewski)
o TGAfb as a module (Andrzej Krzysztofowicz)
o Syscall table updates for sparc64 (Ben Collins)
o 8139too driver updates (Jens David)
o Tighten packet length checks in masq/tproxy (Julian Anastasov)
o Fix udp port selection hang (Dave Miller)
2.2.19pre7
o Remove dead arm files (Russell King)
o Fix VIA rhine build failure for a few folks (Peter Monta)
o ARM ptrace fixes (Russell King)
o Fix ymfpci setup for legacy devices (Pete Zaitcev)
o xspeed dsl needs pci (Lars Holmberg)
o Typo fix (Dave Miller)
o Update ftdi usb serial driver (Greg Kroah-Hartmann)
o Update keyspan usb serial drivers (Greg Kroah-Hartmann)
o Sparc updates (Dave Miller)
o Remove incorrect lp printk (Tim Waugh)
o Fix ppa panic on timeout (Tim Waugh)
o Maestro3 needs ac97 codec (Oleg Krivosheev)
o Fix kwhich versus old bash (Pete Zaitcev)
o Fix ip checksum compiler behaviour assumption (Dave Miller)
o Fix real audio masq in presence of options (John Villalovos)
o ne2k-pci version printing tweaks (J. Magallon)
o Fix incorrect minors for some dasd devices as (Holger Smolinski)
root
o Fix alpha exception table printk (Andrzej Krzysztofowicz)
o USB config updates (Greg Kroah-Hartmann)
o USB audio driver updates (Greg Kroah-Hartmann)
o Fix missing unlock_kernel in usbdev (Greg Kroah-Hartmann)
o Update USB hid driver (Greg Kroah-Hartmann)
o USB rio driver update (Greg Kroah-Hartmann)
o Hopefully fix CyrixIII panic on boot (Ingo Oeser,
H Peter Anvin)
o Further CMOS lock fixes, move ioctls (Paul Gortmaker)
o Dumpable should now work right again (Zack Weinberg,
me)
2.2.19pre6
o Yamaha PCI sound updates (Pete Zaitcev)
o Alpha SMP ASN reuse races (Andrea Arcangeli)
o Alpha bottom half SMP race fixes (Andrea Arcangeli)
o Alpha SMP read_unloc race fix (Andrea Arcangeli)
o Show registers across CPUs on SMP alpha death (Andrea Arcangeli)
o Print the 8K of stack not the top 4K on x86 (Andrea Arcangeli)
o Dcache aging (Andrea Arcangeli)
o Kill unused parameter in free_inode_memory (Andrea Arcangeli)
2.2.19pre5
o Fix dumpable stuff (Wolfgang Walter)
o PPA driver update (Tim Waugh)
o ARM updates (Russell - ptrace.c errored please (Russell King)
resolve)
o Fix NFS data alignment on ARM (Russell King)
o Fix hang on boot with ALi5451 shared irq midi (Stephen Usher)
o ESS Maestro 3 driver (Zach 'Fufu' Brown)
o Belorussia/Ukraine NLS table (koi8-ru) (Andy Rysin)
2.2.19pre4
o Fixed duplicate info on the microcode driver (Daniel Rogers)
o Update watchdog structs for nice user export (Eric Brower)
o Update Documentation/devices.txt (H Peter Anvin)
o Tweak sched.h to handle limit in Sparc (Andrea Arcangeli)
'make check_asm'
o Move isdn pci definitions into pci.h (Kai Germaschewski)
o Tidy init data/static vars in the isdn code (Kai Germaschewski)
o Fix abuse of int for bitops in isdn (Kai Germaschewski)
o Use named initializers on the AVM B1 (Kai Germaschewski)
o Switch capi message length to unsigned (Kai Germaschewski)
o ISDN updates (Kai Germaschewski)
o Update microcode code to check features right (Tigran Aivazian)
in 2.2
o E820 handling fixup (Andrea Arcangeli)
o Fix ne2k-pci driver build bug (J.A. Magallon)
o DC390 driver updates (Kurt Garloff)
o Handle thinkpad E820 edx overwriting (Marc Joosen)
o Update the osst driver to 0.8.6.1 (Kurt Garloff,
Willem Riede)
o Init the cmpci if compiled in (Ra?l N??ez de Arenas Coronado)
o ATP870U SCSI updates to fix disconnect bug (Wittman Li)
o Clean up the usbdevfs backport (Dan Streetman)
o Fix ATI rage makefiles (Brad Douglas)
2.2.19pre3
o Merge ADMtek-comet tulip support (Jim McQuillan)
o Update microcode driver (Tigran Aivazian)
o Merge Don Becker's NE2K full duplex support (Juan Lacarta)
o Optimise kernel compiler detect, kgcc before (Peter Samuelson)
gcc272 also
o Fix compile combination problems (Arjan van de Ven)
o Update via-rhine driver to include Don's changes(Urban Widmark)
for VT6102
o Documentation updates (Tim Waugh)
o Add ISDN PCI defines to pci.h (Kai Germaschewski)
o Fix smb/fat handling for pre 1980 dates (Igor Zhbanov)
o SyncLink updates (Paul Fulghum)
o ICP vortex driver updates (Andreas K?pf)
o mdacon clean up (Pavel Rabel)
o Fix bugs in es1370/es1371/sonicvibes/solo1/ (Thomas Sailer)
dabusb
o Speed up x86 irq/fault paths by avoiding xchg (Mikael Pettersson)
locked cycles (from Brian Gerst's 2.4test change)
o Tighten up K6 check in bug tests (Mikael Pettersson)
o Backport configure scripts bug fixes (Mikael Pettersson)
o Fix duplicat help entries (Riley Williams)
o Fix small asm bug in constant size uaccess (David Kutz)
o Update ymfpci driver to handle legacy audio (Daisuke Nagano)
o Remove ymfsb driver now no longer needed (Daisuke Nagano)
o Add Empeg support to usb-serial (Gary Brubaker)
o Fix e820 handling (Andrea Arcangeli)
o Fix lanstreamer SMP locking (George Staikos)
o Fix S/390 non SMP build (Kurt Roeckx)
o Fix the PCI syscall on PowerMac (Benjamin Herrenschmidt)
o Fix IPC_RMID behaviour (Christoph Rohland)
o Fix NETCTL_GETFD on sparc64 (Dave Miller)
o Tidy unneeded restore_flags/save sequence (Arnaldo Carvalho de Melo)
on the ultrastor
o Fix resource clean up on error in 89xo (Arnaldo Carvalho de Melo)
driver
o Update wireless headers (Jean Tourrilhes)
o Fix non modular emu10k init (Mikael Pettersson)
o Fix cpuid/msr driver crashes (Andrew Morton)
o Write core files sparse (Christoph Rohland)
o Merge the i810 tco (watchdog) timer (me)
| original by Jeff Garzik
2.2.19pre2
o Drop the page aging for a moment to merge the
Andrea VM
o Merge Andrea's VM-global patch (Andrea Arcangeli)
2.2.19pre1
o Basic page aging (Neil Schemenauer)
| This is a beginning to trying to get the VM right
| Next stage is to go through Andrea's stuff and sort
| it out the way I want it.
o E820 memory detect backport from 2.4 (Michael Chen)
o Fix cs46xx refusing to run on emachines400 (me)
o Fix parport docs (Tim Waugh)
o Fix USB serial name reporting (me)
o Fix else warning in initio scsi (John Fort)
o Fix incorrect timeout (that couldnt occur
fortunately) in sched.c (Andrew Archibald)
o Fix A20 fix credits (Christian Lademann)
o Support for OnStream SC-x0 tape drives (Willem Riede,
Kurt Garloff)
o Intel 815 added to the AGPGART code (Robert M Love)
o 3Ware scsi fixes (Arnaldo Carvalho de Melo)
o Clean up scsi_init_malloc no mem case (Arnaldo Carvalho de Melo)
o Fix dead module parameter in ip_masq_user.c (Keith Owens)
o Switch max_files and friends to a struct to (Tigran Aivazian)
be sure they stay together
o Update microcode driver (Tigran Aivazian)
o Fix free memory dereference in lance driver (Eli Carter)
o ISOfs fixes (Andries Brouwer)
o Watchdog driver for Advantech boards (Marek Michalkiewicz)
o ISDN updates (Karsten Keil)
o Docs fix (Pavel Rabel)
o wake_one semantics for accept() (Andrew Morton)
o Masquerade updates (Juanjo Ciarlante)
o Add support for long serialnums on the Metricom (Alex Belits)
o Onboard ethernet driver for the Intel 'Panther' (Ard van Breemen,
boards Andries Brouwer)
o VIA686a timer reset to 18Hz background (Vojtech Pavlik)
o 3c527 driver rewrite (Richard Procter)
| This supercedes my driver because
| - it works for more people
| - he has time to use his MCA box to debug it
o Minix subpartition support (Anand Krishnamurthy
Rajeev Pillai)
o Remove unused() crap from DRM. You will need
to hand load agp as well if needed (me)
--
Alan Cox <[email protected]>
Red Hat Kernel Hacker
& Linux 2.2 Maintainer Brainbench MVP for TCP/IP
http://www.linux.org.uk/diary http://www.brainbench.com
On Mon, 12 Feb 2001, Alan Cox wrote:
> 2.2.19pre10
> o Revert shm change - its unsafe (Richard Nelson)
>
> [...]
>
> 2.2.19pre3
> o Fix IPC_RMID behaviour (Christoph Rohland)
>
Ack...
First, I'm glad I wasn't hallucinating, and that the mail did indeed get
seen by someone.
Second, instead of reverting, can't we simply move those two lines up a
bit:
case IPC_RMID:
if (current->euid == shp->u.shm_perm.uid ||
current->euid == shp->u.shm_perm.cuid ||
capable(CAP_SYS_ADMIN)) {
shp->u.shm_perm.mode |= SHM_DEST;
+ /* Do not find it any more */
+ shp->shm_perm.key = IPC_PRIVATE;
if (shp->u.shm_nattch <= 0)
killseg (id);
break;
This way, we're not violating specs, programs work, *and* we're not
touching freshly kfree()d storage?
--
Rick Nelson
DOS: n., A small annoying boot virus that causes random spontaneous system
crashes, usually just before saving a massive project. Easily cured by
UNIX. See also MS-DOS, IBM-DOS, DR-DOS.
(from David Vicker's .plan)
> First, I'm glad I wasn't hallucinating, and that the mail did indeed get
> seen by someone.
>
> Second, instead of reverting, can't we simply move those two lines up a
> bit:
Possibly but its a minor item that doesnt really matter anyway so leaving it
is fine
On Mon, 12 Feb 2001, Alan Cox wrote:
> > First, I'm glad I wasn't hallucinating, and that the mail did indeed get
> > seen by someone.
> >
> > Second, instead of reverting, can't we simply move those two lines up a
> > bit:
>
> Possibly but its a minor item that doesnt really matter anyway so leaving it
> is fine
Ah, but it does matter ! We break compatibility with other systems (and
our manpages, and possibly standards) if we don't mark the segment
IPC_PRIVATE upon removal -
Marking the segment IPC_PRIVATE allows its continued use by those alread
connected to the segment (until the count drops to zero, and its
deleted), but *prevents* new users from attaching to the segment.
I started down this road because we weren't marking the segment, was
delighted to see it done in pre3 - but it seemed like the setting
wasn't always done ;-{
--
Rick Nelson
Life'll kill ya -- Warren Zevon
Then you'll be dead -- Life'll kill ya
> Ah, but it does matter ! We break compatibility with other systems (and
> our manpages, and possibly standards) if we don't mark the segment
> IPC_PRIVATE upon removal -
This being so midbogglingly critical a bug that nobody noticed until 2.2.18
and the bug existed since 1.2 or earlier. I think I can wait for 2.2.20
Hi Alan,
On Mon, 12 Feb 2001, Alan Cox wrote:
>> First, I'm glad I wasn't hallucinating, and that the mail did
>> indeed get seen by someone.
>>
>> Second, instead of reverting, can't we simply move those two lines
>> up a bit:
>
> Possibly but its a minor item that doesnt really matter anyway so leaving it
> is fine
No, I do not think that it's minor. We had to bring down running
application servers to be able to start another one, because the new
one couldn't create or attach the systemwide os-monitoring
segment and thus refused to start. That's very bad behaviour.
Greetings
Christoph
> > Possibly but its a minor item that doesnt really matter anyway so leaving it
> > is fine
>
> No, I do not think that it's minor. We had to bring down running
> application servers to be able to start another one, because the new
> one couldn't create or attach the systemwide os-monitoring
> segment and thus refused to start. That's very bad behaviour.
Well I'll take corrected fixes, but Im not going to hold up a release for it
Hi Alan,
On Tue, 13 Feb 2001, Alan Cox wrote:
>> No, I do not think that it's minor. We had to bring down running
>> application servers to be able to start another one, because the
>> new one couldn't create or attach the systemwide os-monitoring
>> segment and thus refused to start. That's very bad behaviour.
>
> Well I'll take corrected fixes, but Im not going to hold up a release for it
Yes, I understand that. But I never got any note that my fix is broken
and I still do not understand what's the concern.
We are holding the BKL while doing this. And if shm_close does not get
called with it we should probably acquire it.
Greetings
Christoph
> Yes, I understand that. But I never got any note that my fix is broken
> and I still do not understand what's the concern.
Unless Im misreading the code the segment you poke at has potentially been
freed before it is written too.
Hi Alan,
On Tue, 13 Feb 2001, Alan Cox wrote:
>> Yes, I understand that. But I never got any note that my fix is
>> broken and I still do not understand what's the concern.
>
> Unless Im misreading the code the segment you poke at has
> potentially been freed before it is written too.
Oh yes I was blind, shame on me. Here comes a fixed version.
Greetings
Christoph
--- 2.2.19-pre10/ipc/shm.c.orig Tue Feb 13 14:35:25 2001
+++ 2.2.19-pre10/ipc/shm.c Tue Feb 13 14:34:49 2001
@@ -337,6 +337,8 @@
if (current->euid == shp->u.shm_perm.uid ||
current->euid == shp->u.shm_perm.cuid ||
capable(CAP_SYS_ADMIN)) {
+ /* Do not find it any more */
+ shp->u.shm_perm.key = IPC_PRIVATE;
shp->u.shm_perm.mode |= SHM_DEST;
if (shp->u.shm_nattch <= 0)
killseg (id);