2023-10-05 14:41:54

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] usb: dwc3: fix possible object reference leak

On Thu, Oct 05, 2023 at 09:49:46PM +0800, Zhang Shurong wrote:
> The of_find_device_by_node takes a reference to the struct device
> when find the match device,we should release it when fail.
>
> Fix it by calling by calling platform_device_put when error returns.
>
> Signed-off-by: Zhang Shurong <[email protected]>
> ---

What commit id does this fix?

And how did you find this? How was it tested?

thanks,

greg k-h


2023-10-05 15:47:21

by Zhang Shurong

[permalink] [raw]
Subject: Re: [PATCH] usb: dwc3: fix possible object reference leak

I apologize for the poorly formatted patch.
I will make the necessary revisions and send it to you again.
Additionally, I thought that it may not be straightforward
to test but I will try.

Kind regards,
Shurong

在 2023/10/5 21:59, Greg KH 写道:
> On Thu, Oct 05, 2023 at 09:49:46PM +0800, Zhang Shurong wrote:
>> The of_find_device_by_node takes a reference to the struct device
>> when find the match device,we should release it when fail.
>>
>> Fix it by calling by calling platform_device_put when error returns.
>>
>> Signed-off-by: Zhang Shurong <[email protected]>
>> ---
> What commit id does this fix?
>
> And how did you find this? How was it tested?
>
> thanks,
>
> greg k-h