The comment is "misleading"; fix it by adapting a comment from
push_rt_tasks.
Signed-off-by: Andrea Parri <[email protected]>
---
kernel/sched/deadline.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index 0a17af35..7c17001 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -1563,7 +1563,7 @@ out:
static void push_dl_tasks(struct rq *rq)
{
- /* Terminates as it moves a -deadline task */
+ /* push_dl_task will return true if it moved a -deadline task */
while (push_dl_task(rq))
;
}
--
1.9.1
The flag "dl_boosted" is set by comparing *absolute* deadlines
(c.f., rt_mutex_setprio).
Signed-off-by: Andrea Parri <[email protected]>
---
kernel/sched/deadline.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index 7c17001..be2ca5e 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -953,7 +953,7 @@ static void enqueue_task_dl(struct rq *rq, struct task_struct *p, int flags)
/*
* Use the scheduling parameters of the top pi-waiter
- * task if we have one and its (relative) deadline is
+ * task if we have one and its (absolute) deadline is
* smaller than our one... OTW we keep our runtime and
* deadline.
*/
--
1.9.1
Hi Andrea,
On 05/08/15 14:56, Andrea Parri wrote:
> The comment is "misleading"; fix it by adapting a comment from
> push_rt_tasks.
>
> Signed-off-by: Andrea Parri <[email protected]>
> ---
> kernel/sched/deadline.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index 0a17af35..7c17001 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -1563,7 +1563,7 @@ out:
>
> static void push_dl_tasks(struct rq *rq)
> {
> - /* Terminates as it moves a -deadline task */
> + /* push_dl_task will return true if it moved a -deadline task */
> while (push_dl_task(rq))
> ;
> }
>
Looks good, thanks!
Best,
- Juri
Hi,
On 05/08/15 14:56, Andrea Parri wrote:
> The flag "dl_boosted" is set by comparing *absolute* deadlines
> (c.f., rt_mutex_setprio).
>
> Signed-off-by: Andrea Parri <[email protected]>
> ---
> kernel/sched/deadline.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index 7c17001..be2ca5e 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -953,7 +953,7 @@ static void enqueue_task_dl(struct rq *rq, struct task_struct *p, int flags)
>
> /*
> * Use the scheduling parameters of the top pi-waiter
> - * task if we have one and its (relative) deadline is
> + * task if we have one and its (absolute) deadline is
> * smaller than our one... OTW we keep our runtime and
> * deadline.
> */
>
Right, thanks for spotting it.
Best,
- Juri
Commit-ID: 4ffa08ed4cc4c5d47d197d749aae6f79af91eb73
Gitweb: http://git.kernel.org/tip/4ffa08ed4cc4c5d47d197d749aae6f79af91eb73
Author: Andrea Parri <[email protected]>
AuthorDate: Wed, 5 Aug 2015 15:56:18 +0200
Committer: Ingo Molnar <[email protected]>
CommitDate: Wed, 12 Aug 2015 12:06:10 +0200
sched/deadline: Fix comment in push_dl_tasks()
The comment is "misleading"; fix it by adapting a comment from
push_rt_tasks().
Signed-off-by: Andrea Parri <[email protected]>
Signed-off-by: Peter Zijlstra (Intel) <[email protected]>
Cc: Linus Torvalds <[email protected]>
Cc: Mike Galbraith <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Ingo Molnar <[email protected]>
---
kernel/sched/deadline.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index b473056..82c0dd0 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -1563,7 +1563,7 @@ out:
static void push_dl_tasks(struct rq *rq)
{
- /* Terminates as it moves a -deadline task */
+ /* push_dl_task() will return true if it moved a -deadline task */
while (push_dl_task(rq))
;
}
Commit-ID: ff277d4250fe715b6666219b1a3423b863418794
Gitweb: http://git.kernel.org/tip/ff277d4250fe715b6666219b1a3423b863418794
Author: Andrea Parri <[email protected]>
AuthorDate: Wed, 5 Aug 2015 15:56:19 +0200
Committer: Ingo Molnar <[email protected]>
CommitDate: Wed, 12 Aug 2015 12:06:10 +0200
sched/deadline: Fix comment in enqueue_task_dl()
The "dl_boosted" flag is set by comparing *absolute* deadlines
(c.f., rt_mutex_setprio()).
Signed-off-by: Andrea Parri <[email protected]>
Signed-off-by: Peter Zijlstra (Intel) <[email protected]>
Cc: Linus Torvalds <[email protected]>
Cc: Mike Galbraith <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Ingo Molnar <[email protected]>
---
kernel/sched/deadline.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index 82c0dd0..fc8f010 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -953,7 +953,7 @@ static void enqueue_task_dl(struct rq *rq, struct task_struct *p, int flags)
/*
* Use the scheduling parameters of the top pi-waiter
- * task if we have one and its (relative) deadline is
+ * task if we have one and its (absolute) deadline is
* smaller than our one... OTW we keep our runtime and
* deadline.
*/