To be able to compile drivers using devm_clk_rate_exclusive_get() also
on platforms without the common clk framework, add a dummy
implementation that does the same as clk_rate_exclusive_get() in that
case (i.e. nothing).
Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
Fixes: b0cde62e4c54 ("clk: Add a devm variant of clk_rate_exclusive_get()")
Signed-off-by: Uwe Kleine-König <[email protected]>
---
include/linux/clk.h | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/include/linux/clk.h b/include/linux/clk.h
index 00623f4de5e1..0fa56d672532 100644
--- a/include/linux/clk.h
+++ b/include/linux/clk.h
@@ -286,6 +286,11 @@ static inline int clk_rate_exclusive_get(struct clk *clk)
return 0;
}
+static inline int devm_clk_rate_exclusive_get(struct device *dev, struct clk *clk)
+{
+ return 0;
+}
+
static inline void clk_rate_exclusive_put(struct clk *clk) {}
#endif
base-commit: 4cece764965020c22cff7665b18a012006359095
--
2.43.0
Quoting Uwe Kleine-König (2024-03-27 00:33:10)
> To be able to compile drivers using devm_clk_rate_exclusive_get() also
> on platforms without the common clk framework, add a dummy
> implementation that does the same as clk_rate_exclusive_get() in that
> case (i.e. nothing).
>
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Fixes: b0cde62e4c54 ("clk: Add a devm variant of clk_rate_exclusive_get()")
> Signed-off-by: Uwe Kleine-König <[email protected]>
> ---
Applied to clk-fixes
Hello Stephen,
On Thu, Mar 28, 2024 at 03:35:57PM -0700, Stephen Boyd wrote:
> Quoting Uwe Kleine-K?nig (2024-03-27 00:33:10)
> > To be able to compile drivers using devm_clk_rate_exclusive_get() also
> > on platforms without the common clk framework, add a dummy
> > implementation that does the same as clk_rate_exclusive_get() in that
> > case (i.e. nothing).
> >
> > Reported-by: kernel test robot <[email protected]>
> > Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> > Fixes: b0cde62e4c54 ("clk: Add a devm variant of clk_rate_exclusive_get()")
> > Signed-off-by: Uwe Kleine-K?nig <[email protected]>
> > ---
>
> Applied to clk-fixes
I assume that means it will be sent to Linus before 6.9? That would be
great because I want to make use of this function in some drivers and
the build bots nag about my for-next branch that in some configurations
this function is missing.
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | https://www.pengutronix.de/ |
Hello Stephen,
On Fri, Apr 12, 2024 at 10:49:35PM +0200, Uwe Kleine-K?nig wrote:
> On Thu, Mar 28, 2024 at 03:35:57PM -0700, Stephen Boyd wrote:
> > Quoting Uwe Kleine-K?nig (2024-03-27 00:33:10)
> > > To be able to compile drivers using devm_clk_rate_exclusive_get() also
> > > on platforms without the common clk framework, add a dummy
> > > implementation that does the same as clk_rate_exclusive_get() in that
> > > case (i.e. nothing).
> > >
> > > Reported-by: kernel test robot <[email protected]>
> > > Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> > > Fixes: b0cde62e4c54 ("clk: Add a devm variant of clk_rate_exclusive_get()")
> > > Signed-off-by: Uwe Kleine-K?nig <[email protected]>
> > > ---
> >
> > Applied to clk-fixes
>
> I assume that means it will be sent to Linus before 6.9? That would be
> great because I want to make use of this function in some drivers and
> the build bots nag about my for-next branch that in some configurations
> this function is missing.
Gentle ping. I'd like to get the patches I intend to send to Linus for
v6.10-rc1 into shape. To have these unmodified in my for-next branch for
some time it would be great to know your plans for the clk-fixes branch.
Alternatively: Can I expect the commit not to be changed any more and
pull it into my pwm tree?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | https://www.pengutronix.de/ |
Quoting Uwe Kleine-König (2024-04-19 13:00:19)
> Hello Stephen,
>
> On Fri, Apr 12, 2024 at 10:49:35PM +0200, Uwe Kleine-K�nig wrote:
> > On Thu, Mar 28, 2024 at 03:35:57PM -0700, Stephen Boyd wrote:
> > > Quoting Uwe Kleine-K�nig (2024-03-27 00:33:10)
> > > > To be able to compile drivers using devm_clk_rate_exclusive_get() also
> > > > on platforms without the common clk framework, add a dummy
> > > > implementation that does the same as clk_rate_exclusive_get() in that
> > > > case (i.e. nothing).
> > > >
> > > > Reported-by: kernel test robot <[email protected]>
> > > > Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> > > > Fixes: b0cde62e4c54 ("clk: Add a devm variant of clk_rate_exclusive_get()")
> > > > Signed-off-by: Uwe Kleine-K�nig <[email protected]>
> > > > ---
> > >
> > > Applied to clk-fixes
> >
> > I assume that means it will be sent to Linus before 6.9? That would be
> > great because I want to make use of this function in some drivers and
> > the build bots nag about my for-next branch that in some configurations
> > this function is missing.
Yes.
>
> Gentle ping. I'd like to get the patches I intend to send to Linus for
> v6.10-rc1 into shape. To have these unmodified in my for-next branch for
> some time it would be great to know your plans for the clk-fixes branch.
> Alternatively: Can I expect the commit not to be changed any more and
> pull it into my pwm tree?
>
clk-fixes is sent to Linus during the rc cycle. I'm sending a PR today.