2014-06-16 14:09:55

by Szymon Janc

[permalink] [raw]
Subject: [PATCH] android: Build btiotest tool

This is useful for testing.
---
android/Android.mk | 32 ++++++++++++++++++++++++++++++++
1 file changed, 32 insertions(+)

diff --git a/android/Android.mk b/android/Android.mk
index fc7b59d..ecff9c8 100644
--- a/android/Android.mk
+++ b/android/Android.mk
@@ -620,3 +620,35 @@ LOCAL_MODULE := avinfo
LOCAL_ADDITIONAL_DEPENDENCIES := $(LOCAL_PATH)/bluez/configure.ac

include $(BUILD_EXECUTABLE)
+
+#
+# btiotest
+#
+
+include $(CLEAR_VARS)
+
+LOCAL_SRC_FILES := \
+ bluez/tools/btiotest.c \
+ bluez/btio/btio.c \
+ bluez/lib/bluetooth.c \
+
+LOCAL_C_INCLUDES := \
+ $(LOCAL_PATH)/bluez \
+ $(call include-path-for, glib) \
+ $(call include-path-for, glib)/glib \
+
+LOCAL_CFLAGS := $(BLUEZ_COMMON_CFLAGS)
+
+LOCAL_STATIC_LIBRARIES := \
+ bluetooth-headers \
+
+LOCAL_SHARED_LIBRARIES := \
+ libglib \
+
+LOCAL_MODULE_PATH := $(TARGET_OUT_OPTIONAL_EXECUTABLES)
+LOCAL_MODULE_TAGS := debug
+LOCAL_MODULE := btiotest
+
+LOCAL_ADDITIONAL_DEPENDENCIES := $(LOCAL_PATH)/bluez/configure.ac
+
+include $(BUILD_EXECUTABLE)
--
1.9.1



2014-06-16 21:38:37

by Lukasz Rymanowski

[permalink] [raw]
Subject: Re: [PATCH] android: Build btiotest tool

Hi Marcel, Szymon,

On Mon, Jun 16, 2014 at 10:40 PM, Marcel Holtmann <[email protected]> wrote:
> Hi Szymon,
>
>>>> This is useful for testing.
>>>> ---
>>>> android/Android.mk | 32 ++++++++++++++++++++++++++++++++
>>>> 1 file changed, 32 insertions(+)
>>>>
>>>> diff --git a/android/Android.mk b/android/Android.mk
>>>> index fc7b59d..ecff9c8 100644
>>>> --- a/android/Android.mk
>>>> +++ b/android/Android.mk
>>>> @@ -620,3 +620,35 @@ LOCAL_MODULE := avinfo
>>>> LOCAL_ADDITIONAL_DEPENDENCIES := $(LOCAL_PATH)/bluez/configure.ac
>>>>
>>>> include $(BUILD_EXECUTABLE)
>>>> +
>>>> +#
>>>> +# btiotest
>>>> +#
>>>> +
>>>> +include $(CLEAR_VARS)
>>>> +
>>>> +LOCAL_SRC_FILES := \
>>>> + bluez/tools/btiotest.c \
>>>> + bluez/btio/btio.c \
>>>> + bluez/lib/bluetooth.c \
>>>
>>> I would actually prefer that we get rid of btio and integrated this in
>>> struct io properly. However what can be tested with btiotest that can not
>>> be tested with l2test and other tools.
>>
>> This is mostly for tests related to (updating) connection security level.
>>
>> We should be able to craft custom GATT HAL test command for that, although
>> this is not really related to GATT...
>
> if it helps right now, then include the tool. However keep in mind that long term all the GLib based stuff has to go away. And especially the Android part of BlueZ should be GLib free first. This means if you are missing test functionality, lets get it into the existing test tools.
>

For now we need it for couple tests. I think we can already try to
cover it with l2test if btiotest is on the black list ;)

> Regards
>
> Marcel
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

\Lukasz

2014-06-16 20:40:50

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [PATCH] android: Build btiotest tool

Hi Szymon,

>>> This is useful for testing.
>>> ---
>>> android/Android.mk | 32 ++++++++++++++++++++++++++++++++
>>> 1 file changed, 32 insertions(+)
>>>
>>> diff --git a/android/Android.mk b/android/Android.mk
>>> index fc7b59d..ecff9c8 100644
>>> --- a/android/Android.mk
>>> +++ b/android/Android.mk
>>> @@ -620,3 +620,35 @@ LOCAL_MODULE := avinfo
>>> LOCAL_ADDITIONAL_DEPENDENCIES := $(LOCAL_PATH)/bluez/configure.ac
>>>
>>> include $(BUILD_EXECUTABLE)
>>> +
>>> +#
>>> +# btiotest
>>> +#
>>> +
>>> +include $(CLEAR_VARS)
>>> +
>>> +LOCAL_SRC_FILES := \
>>> + bluez/tools/btiotest.c \
>>> + bluez/btio/btio.c \
>>> + bluez/lib/bluetooth.c \
>>
>> I would actually prefer that we get rid of btio and integrated this in
>> struct io properly. However what can be tested with btiotest that can not
>> be tested with l2test and other tools.
>
> This is mostly for tests related to (updating) connection security level.
>
> We should be able to craft custom GATT HAL test command for that, although
> this is not really related to GATT...

if it helps right now, then include the tool. However keep in mind that long term all the GLib based stuff has to go away. And especially the Android part of BlueZ should be GLib free first. This means if you are missing test functionality, lets get it into the existing test tools.

Regards

Marcel


2014-06-16 20:25:52

by Szymon Janc

[permalink] [raw]
Subject: Re: [PATCH] android: Build btiotest tool

Hi Marcel,

On Monday 16 June 2014 18:27:27 Marcel Holtmann wrote:
> Hi Szymon,
>
> > This is useful for testing.
> > ---
> > android/Android.mk | 32 ++++++++++++++++++++++++++++++++
> > 1 file changed, 32 insertions(+)
> >
> > diff --git a/android/Android.mk b/android/Android.mk
> > index fc7b59d..ecff9c8 100644
> > --- a/android/Android.mk
> > +++ b/android/Android.mk
> > @@ -620,3 +620,35 @@ LOCAL_MODULE := avinfo
> > LOCAL_ADDITIONAL_DEPENDENCIES := $(LOCAL_PATH)/bluez/configure.ac
> >
> > include $(BUILD_EXECUTABLE)
> > +
> > +#
> > +# btiotest
> > +#
> > +
> > +include $(CLEAR_VARS)
> > +
> > +LOCAL_SRC_FILES := \
> > + bluez/tools/btiotest.c \
> > + bluez/btio/btio.c \
> > + bluez/lib/bluetooth.c \
>
> I would actually prefer that we get rid of btio and integrated this in
> struct io properly. However what can be tested with btiotest that can not
> be tested with l2test and other tools.

This is mostly for tests related to (updating) connection security level.

We should be able to craft custom GATT HAL test command for that, although
this is not really related to GATT...

--
Szymon K. Janc
[email protected]

2014-06-16 16:27:27

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [PATCH] android: Build btiotest tool

Hi Szymon,

> This is useful for testing.
> ---
> android/Android.mk | 32 ++++++++++++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
>
> diff --git a/android/Android.mk b/android/Android.mk
> index fc7b59d..ecff9c8 100644
> --- a/android/Android.mk
> +++ b/android/Android.mk
> @@ -620,3 +620,35 @@ LOCAL_MODULE := avinfo
> LOCAL_ADDITIONAL_DEPENDENCIES := $(LOCAL_PATH)/bluez/configure.ac
>
> include $(BUILD_EXECUTABLE)
> +
> +#
> +# btiotest
> +#
> +
> +include $(CLEAR_VARS)
> +
> +LOCAL_SRC_FILES := \
> + bluez/tools/btiotest.c \
> + bluez/btio/btio.c \
> + bluez/lib/bluetooth.c \

I would actually prefer that we get rid of btio and integrated this in struct io properly. However what can be tested with btiotest that can not be tested with l2test and other tools.

Regards

Marcel