2011-11-01 09:33:05

by Al Cho

[permalink] [raw]
Subject: [PATCH 1/3] add device entry for Broadcom Valentine combo card

This device declares itself to be vendor specific
It therefore needs to be added to the device table
to make btusb bind.

Signed-off-by: Cho, Yu-Chen <[email protected]>
---
drivers/bluetooth/btusb.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index abfc4ee..be01260 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -97,6 +97,10 @@ static struct usb_device_id btusb_table[] = {
/* Ericsson with non-standard id */
{ USB_DEVICE(0x0bdb, 0x1002) },

+ /* Broadcom 20702 Bluetooth 4.0 Adapter */
+ /* Broadcom Valentine 802.11bgn 1x1 Combo HMC */
+ { USB_DEVICE(0x0a5c, 0x21e3) },
+
/* Canyon CN-BTU1 with HID interfaces */
{ USB_DEVICE(0x0c10, 0x0000) },

--
1.7.3.4


2011-11-01 16:15:49

by Gustavo Padovan

[permalink] [raw]
Subject: Re: [PATCH 1/3] add device entry for Broadcom Valentine combo card

Hi Yu-Chen,

* Cho, Yu-Chen <[email protected]> [2011-11-01 17:33:05 +0800]:

> This device declares itself to be vendor specific
> It therefore needs to be added to the device table
> to make btusb bind.
>
> Signed-off-by: Cho, Yu-Chen <[email protected]>
> ---
> drivers/bluetooth/btusb.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)

Ok, but where is the output of usb-devices that I asked. Thanks.

Gustavo

2011-11-01 09:33:07

by Al Cho

[permalink] [raw]
Subject: [PATCH 3/3] add device entry for other Broadcom combo card

Those devices declare themselves to be vendor specific
It therefore needs to be added to the device table
to make btusb bind.

Signed-off-by: Cho, Yu-Chen <[email protected]>
---
drivers/bluetooth/btusb.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 8583aee..bc8f850 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -100,6 +100,12 @@ static struct usb_device_id btusb_table[] = {
/* Broadcom Valentine 802.11bgn 1x1 Combo HMC */
{ USB_DEVICE(0x0a5c, 0x21e3) },

+ { USB_DEVICE(0x03f0, 0x2a1d) },
+ { USB_DEVICE(0x03f0, 0x231d) },
+
+ /* BCM2070 Bluetooth 2.1 + EDR */
+ { USB_DEVICE(0x0a5c, 0x21b4) },
+
/* Canyon CN-BTU1 with HID interfaces */
{ USB_DEVICE(0x0c10, 0x0000) },

--
1.7.3.4

2011-11-01 09:33:06

by Al Cho

[permalink] [raw]
Subject: [PATCH 2/3] fix device id for Broadcom SoftSailing

Fixed the device VID:PID typo 05ac:21e1 to 0a5c:21e1

Signed-off-by: Cho, Yu-Chen <[email protected]>
---
drivers/bluetooth/btusb.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index be01260..8583aee 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -60,9 +60,6 @@ static struct usb_device_id btusb_table[] = {
/* Generic Bluetooth USB device */
{ USB_DEVICE_INFO(0xe0, 0x01, 0x01) },

- /* Broadcom SoftSailing reporting vendor specific */
- { USB_DEVICE(0x05ac, 0x21e1) },
-
/* Apple MacBookPro 7,1 */
{ USB_DEVICE(0x05ac, 0x8213) },

@@ -98,6 +95,8 @@ static struct usb_device_id btusb_table[] = {
{ USB_DEVICE(0x0bdb, 0x1002) },

/* Broadcom 20702 Bluetooth 4.0 Adapter */
+ /* Broadcom SoftSailing reporting vendor specific */
+ { USB_DEVICE(0x0a5c, 0x21e1) },
/* Broadcom Valentine 802.11bgn 1x1 Combo HMC */
{ USB_DEVICE(0x0a5c, 0x21e3) },

--
1.7.3.4

2011-12-12 08:43:29

by Al Cho

[permalink] [raw]
Subject: Re: [PATCH 1/3] add device entry for Broadcom Valentine combo card

Hi Gustavo,

Sorry I lost and late to reply this mail.

On Wed, Nov 2, 2011 at 12:15 AM, Gustavo Padovan <[email protected]> wrote:
> Hi Yu-Chen,
>
> * Cho, Yu-Chen <[email protected]> [2011-11-01 17:33:05 +0800]:
>
>> This device declares itself to be vendor specific
>> It therefore needs to be added to the device table
>> to make btusb bind.
>>
>> Signed-off-by: Cho, Yu-Chen <[email protected]>
>> ---
>> ?drivers/bluetooth/btusb.c | ? ?4 ++++
>> ?1 files changed, 4 insertions(+), 0 deletions(-)
>
> Ok, but where is the output of usb-devices that I asked. Thanks.
>
> ? ? ? ? Gustavo
>

T: Bus=01 Lev=02 Prnt=02 Port=03 Cnt=01 Dev#= 3 Spd=12 MxCh= 0
D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
P: Vendor=0a5c ProdID=21e3 Rev= 1.12
S: Manufacturer=Broadcom Corp
S: Product=BCM20702A0
S: SerialNumber=889FFAABE086
C:* #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr= 0mA
I:* If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb
E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=1ms
E: Ad=82(I) Atr=02(Bulk) MxPS= 64 Ivl=0ms
E: Ad=02(O) Atr=02(Bulk) MxPS= 64 Ivl=0ms
I:* If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb
E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms
E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms
I: If#= 1 Alt= 1 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb
E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms
E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms
I: If#= 1 Alt= 2 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb
E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms
E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms
I: If#= 1 Alt= 3 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb
E: Ad=83(I) Atr=01(Isoc) MxPS= 25 Ivl=1ms
E: Ad=03(O) Atr=01(Isoc) MxPS= 25 Ivl=1ms
I: If#= 1 Alt= 4 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb
E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms
E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms
I: If#= 1 Alt= 5 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb
E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms
E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms
I:* If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
E: Ad=84(I) Atr=02(Bulk) MxPS= 32 Ivl=0ms
E: Ad=04(O) Atr=02(Bulk) MxPS= 32 Ivl=0ms
I:* If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)

Please correct me if i got any mistake.

Sincerely,
AL