2012-10-07 22:00:13

by Peng Tao

[permalink] [raw]
Subject: [PATCH-Resend] NFS41: layoutget optimize and pnfsblock cleanup

Hi Trond,

Following first three patches were sent before and optimize layoutget size.
Last patch is cleanup and is also sent before.

Sorry that I have to send patches as attachments. I am having problem
with my smtp setup.

Thanks,
Tao

Peng Tao (4):
NFS: track direct IO left bytes
NFS41: send real write size in layoutget
NFS41: send real read size in layoutget
pnfsblock: cleanup nfs4_blkdev_get

fs/nfs/blocklayout/blocklayout.c | 38 ++++++++++++++++++++++++++++++++--
fs/nfs/blocklayout/blocklayout.h | 1 -
fs/nfs/blocklayout/blocklayoutdev.c | 25 ++++------------------
fs/nfs/direct.c | 12 +++++++++++
fs/nfs/internal.h | 1 +
fs/nfs/objlayout/objio_osd.c | 9 +++++++-
fs/nfs/pnfs.c | 16 ++++++++++++--
fs/nfs/pnfs.h | 3 +-
8 files changed, 76 insertions(+), 29 deletions(-)


Attachments:
0001-NFS-track-direct-IO-left-bytes.patch (2.01 kB)
0002-NFS41-send-real-write-size-in-layoutget.patch (6.18 kB)
0003-NFS41-send-real-read-size-in-layoutget.patch (1.21 kB)
0004-pnfsblock-cleanup-nfs4_blkdev_get.patch (2.25 kB)
Download all attachments

2012-10-07 22:06:15

by Myklebust, Trond

[permalink] [raw]
Subject: Re: [PATCH-Resend] NFS41: layoutget optimize and pnfsblock cleanup

Aren't these already in the nfs-for-next branch?

Peng Tao <[email protected]> wrote:


Hi Trond,

Following first three patches were sent before and optimize layoutget size.
Last patch is cleanup and is also sent before.

Sorry that I have to send patches as attachments. I am having problem
with my smtp setup.

Thanks,
Tao

Peng Tao (4):
NFS: track direct IO left bytes
NFS41: send real write size in layoutget
NFS41: send real read size in layoutget
pnfsblock: cleanup nfs4_blkdev_get

fs/nfs/blocklayout/blocklayout.c | 38 ++++++++++++++++++++++++++++++++--
fs/nfs/blocklayout/blocklayout.h | 1 -
fs/nfs/blocklayout/blocklayoutdev.c | 25 ++++------------------
fs/nfs/direct.c | 12 +++++++++++
fs/nfs/internal.h | 1 +
fs/nfs/objlayout/objio_osd.c | 9 +++++++-
fs/nfs/pnfs.c | 16 ++++++++++++--
fs/nfs/pnfs.h | 3 +-
8 files changed, 76 insertions(+), 29 deletions(-)

2012-10-10 18:47:57

by Boaz Harrosh

[permalink] [raw]
Subject: Re: [PATCH-Resend] NFS41: layoutget optimize and pnfsblock cleanup

On 10/10/2012 03:13 AM, Peng Tao wrote:
> Sorry I forgot to mention... They apply to Trond's nfs-for-next
> branch, commit (5f65753033d8c5a53e65810bff3832e8282c68d1).
>

NP thanks, I just saw Trond's pull request patches are part of that
pull, I will test with 3.7-rc1 and will report if I have any problems.

Thanks Tao
Boaz

> Thanks,
> Tao
>

2012-10-09 18:45:06

by Boaz Harrosh

[permalink] [raw]
Subject: Re: [PATCH-Resend] NFS41: layoutget optimize and pnfsblock cleanup

On 10/07/2012 02:59 PM, Peng Tao wrote:
> Hi Trond,
>
> Following first three patches were sent before and optimize layoutget size.
> Last patch is cleanup and is also sent before.
>
> Sorry that I have to send patches as attachments. I am having problem
> with my smtp setup.
>
> Thanks,
> Tao
>

Tao hi.

What are these patches based on? they do not apply to Linus tree as of today
(v3.6-9228-g547b1e8) and they do not apply to v3.6 nor v3.5 tags.

I get a conflict on the first patch:
NFS: track direct IO left bytes

(Do you have a public git tree with these on? Why don't you ask for a git tree
on git.linux-nfs.org. Trond who should we ask for an hosting on git.linux-nfs.org)

Thanks
Boaz

> Peng Tao (4):
> NFS: track direct IO left bytes
> NFS41: send real write size in layoutget
> NFS41: send real read size in layoutget
> pnfsblock: cleanup nfs4_blkdev_get
>
> fs/nfs/blocklayout/blocklayout.c | 38 ++++++++++++++++++++++++++++++++--
> fs/nfs/blocklayout/blocklayout.h | 1 -
> fs/nfs/blocklayout/blocklayoutdev.c | 25 ++++------------------
> fs/nfs/direct.c | 12 +++++++++++
> fs/nfs/internal.h | 1 +
> fs/nfs/objlayout/objio_osd.c | 9 +++++++-
> fs/nfs/pnfs.c | 16 ++++++++++++--
> fs/nfs/pnfs.h | 3 +-
> 8 files changed, 76 insertions(+), 29 deletions(-)
>



2012-10-10 10:14:13

by Peng Tao

[permalink] [raw]
Subject: Re: [PATCH-Resend] NFS41: layoutget optimize and pnfsblock cleanup

On Wed, Oct 10, 2012 at 3:03 AM, Boaz Harrosh <[email protected]> wrote:
> On 10/09/2012 11:44 AM, Boaz Harrosh wrote:
>> On 10/07/2012 02:59 PM, Peng Tao wrote:
>>> Hi Trond,
>>>
>>> Following first three patches were sent before and optimize layoutget size.
>>> Last patch is cleanup and is also sent before.
>>>
>>> Sorry that I have to send patches as attachments. I am having problem
>>> with my smtp setup.
>>>
>>> Thanks,
>>> Tao
>>>
>>
>> Tao hi.
>>
>> What are these patches based on? they do not apply to Linus tree as of today
>> (v3.6-9228-g547b1e8) and they do not apply to v3.6 nor v3.5 tags.
>>
>> I get a conflict on the first patch:
>> NFS: track direct IO left bytes
>>
>
> Actually the second patch does not apply either. minor on pnfs.c but
> a real fallout on blocklayout.c (3 and 4 are fine)
>
Sorry I forgot to mention... They apply to Trond's nfs-for-next
branch, commit (5f65753033d8c5a53e65810bff3832e8282c68d1).

Thanks,
Tao

2012-10-09 19:03:21

by Boaz Harrosh

[permalink] [raw]
Subject: Re: [PATCH-Resend] NFS41: layoutget optimize and pnfsblock cleanup

On 10/09/2012 11:44 AM, Boaz Harrosh wrote:
> On 10/07/2012 02:59 PM, Peng Tao wrote:
>> Hi Trond,
>>
>> Following first three patches were sent before and optimize layoutget size.
>> Last patch is cleanup and is also sent before.
>>
>> Sorry that I have to send patches as attachments. I am having problem
>> with my smtp setup.
>>
>> Thanks,
>> Tao
>>
>
> Tao hi.
>
> What are these patches based on? they do not apply to Linus tree as of today
> (v3.6-9228-g547b1e8) and they do not apply to v3.6 nor v3.5 tags.
>
> I get a conflict on the first patch:
> NFS: track direct IO left bytes
>

Actually the second patch does not apply either. minor on pnfs.c but
a real fallout on blocklayout.c (3 and 4 are fine)

Boaz

> (Do you have a public git tree with these on? Why don't you ask for a git tree
> on git.linux-nfs.org. Trond who should we ask for an hosting on git.linux-nfs.org)
>
> Thanks
> Boaz
>
>> Peng Tao (4):
>> NFS: track direct IO left bytes
>> NFS41: send real write size in layoutget
>> NFS41: send real read size in layoutget
>> pnfsblock: cleanup nfs4_blkdev_get
>>
>> fs/nfs/blocklayout/blocklayout.c | 38 ++++++++++++++++++++++++++++++++--
>> fs/nfs/blocklayout/blocklayout.h | 1 -
>> fs/nfs/blocklayout/blocklayoutdev.c | 25 ++++------------------
>> fs/nfs/direct.c | 12 +++++++++++
>> fs/nfs/internal.h | 1 +
>> fs/nfs/objlayout/objio_osd.c | 9 +++++++-
>> fs/nfs/pnfs.c | 16 ++++++++++++--
>> fs/nfs/pnfs.h | 3 +-
>> 8 files changed, 76 insertions(+), 29 deletions(-)
>>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>



2012-10-09 07:17:22

by Peng Tao

[permalink] [raw]
Subject: Re: [PATCH-Resend] NFS41: layoutget optimize and pnfsblock cleanup

On 10/8/12, Myklebust, Trond <[email protected]> wrote:
> Aren't these already in the nfs-for-next branch?
>
No. You only merged the IO alignment and bugfix patches.
These are layoutget size optimization that you and Boaz reviewed sometime ago.

Thanks,
Tao