2023-04-13 13:56:33

by David Howells

Subject: [PATCH] sunrpc: Fix RFC6803 encryption test

The usage_data[] array in rfc6803_encrypt_case() is uninitialised, so clear
it as it may cause the tests to fail otherwise.

Fixes: b958cff6b27b ("SUNRPC: Add encryption KUnit tests for the RFC 6803 encryption types")
Link: https://lore.kernel.org/r/[email protected]/
Signed-off-by: David Howells <[email protected]>
cc: Chuck Lever <[email protected]>
cc: Scott Mayhew <[email protected]>
cc: Herbert Xu <[email protected]>
cc: [email protected]
cc: [email protected]
---
net/sunrpc/auth_gss/gss_krb5_test.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/net/sunrpc/auth_gss/gss_krb5_test.c b/net/sunrpc/auth_gss/gss_krb5_test.c
index ce0541e32fc9..aa6ec4e858aa 100644
--- a/net/sunrpc/auth_gss/gss_krb5_test.c
+++ b/net/sunrpc/auth_gss/gss_krb5_test.c
@@ -1327,6 +1327,7 @@ static void rfc6803_encrypt_case(struct kunit *test)
if (!gk5e)
kunit_skip(test, "Encryption type is not available");

+ memset(usage_data, 0, sizeof(usage_data));
usage.data[3] = param->constant;

Ke.len = gk5e->Ke_length;

2023-04-13 13:59:47

by Chuck Lever III

Subject: Re: [PATCH] sunrpc: Fix RFC6803 encryption test

> On Apr 13, 2023, at 9:51 AM, David Howells <[email protected]> wrote:
>
>
> The usage_data[] array in rfc6803_encrypt_case() is uninitialised, so clear
> it as it may cause the tests to fail otherwise.
>
> Fixes: b958cff6b27b ("SUNRPC: Add encryption KUnit tests for the RFC 6803 encryption types")
> Link: https://lore.kernel.org/r/[email protected]/
> Signed-off-by: David Howells <[email protected]>
> cc: Chuck Lever <[email protected]>
> cc: Scott Mayhew <[email protected]>
> cc: Herbert Xu <[email protected]>
> cc: [email protected]
> cc: [email protected]
> ---
> net/sunrpc/auth_gss/gss_krb5_test.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/sunrpc/auth_gss/gss_krb5_test.c b/net/sunrpc/auth_gss/gss_krb5_test.c
> index ce0541e32fc9..aa6ec4e858aa 100644
> --- a/net/sunrpc/auth_gss/gss_krb5_test.c
> +++ b/net/sunrpc/auth_gss/gss_krb5_test.c
> @@ -1327,6 +1327,7 @@ static void rfc6803_encrypt_case(struct kunit *test)
> if (!gk5e)
> kunit_skip(test, "Encryption type is not available");
>
> + memset(usage_data, 0, sizeof(usage_data));
> usage.data[3] = param->constant;
>
> Ke.len = gk5e->Ke_length;
>

Many thanks! I will apply this to nfsd-fixes.


--
Chuck Lever