2020-08-31 08:01:36

by Andy Shevchenko

Subject: [PATCH v1] crypto: caam - use traditional error check pattern

Use traditional error check pattern
ret = ...;
if (ret)
return ret;
...
instead of checking error code to be 0.

Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/crypto/caam/ctrl.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/crypto/caam/ctrl.c b/drivers/crypto/caam/ctrl.c
index 65de57f169d9..25785404a58e 100644
--- a/drivers/crypto/caam/ctrl.c
+++ b/drivers/crypto/caam/ctrl.c
@@ -333,11 +333,10 @@ static int instantiate_rng(struct device *ctrldev, int state_handle_mask,

kfree(desc);

- if (!ret)
- ret = devm_add_action_or_reset(ctrldev, devm_deinstantiate_rng,
- ctrldev);
+ if (ret)
+ return ret;

- return ret;
+ return devm_add_action_or_reset(ctrldev, devm_deinstantiate_rng, ctrldev);
}

/*
--
2.28.0

2020-09-01 15:06:12

by Iuliana Prodan

Subject: Re: [PATCH v1] crypto: caam - use traditional error check pattern

On 8/31/2020 10:58 AM, Andy Shevchenko wrote:
> Use traditional error check pattern
> ret = ...;
> if (ret)
> return ret;
> ...
> instead of checking error code to be 0.
>
> Signed-off-by: Andy Shevchenko <[email protected]>

Reviewed-by: Iuliana Prodan <[email protected]>

> ---
> drivers/crypto/caam/ctrl.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/crypto/caam/ctrl.c b/drivers/crypto/caam/ctrl.c
> index 65de57f169d9..25785404a58e 100644
> --- a/drivers/crypto/caam/ctrl.c
> +++ b/drivers/crypto/caam/ctrl.c
> @@ -333,11 +333,10 @@ static int instantiate_rng(struct device *ctrldev, int state_handle_mask,
>
> kfree(desc);
>
> - if (!ret)
> - ret = devm_add_action_or_reset(ctrldev, devm_deinstantiate_rng,
> - ctrldev);
> + if (ret)
> + return ret;
>
> - return ret;
> + return devm_add_action_or_reset(ctrldev, devm_deinstantiate_rng, ctrldev);
> }
>
> /*
>

2020-09-11 06:57:48

by Herbert Xu

Subject: Re: [PATCH v1] crypto: caam - use traditional error check pattern

Andy Shevchenko <[email protected]> wrote:
> Use traditional error check pattern
> ret = ...;
> if (ret)
> return ret;
> ...
> instead of checking error code to be 0.
>
> Signed-off-by: Andy Shevchenko <[email protected]>
> ---
> drivers/crypto/caam/ctrl.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt