2020-04-15 22:19:00

by Kaixu Xia

[permalink] [raw]
Subject: [PATCH] ext4: remove redundant variable has_bigalloc in ext4_fill_super

From: Kaixu Xia <[email protected]>

We can use the ext4_has_feature_bigalloc() function directly to check
bigalloc feature and the variable has_bigalloc is reduncant, so remove
it.

Signed-off-by: Kaixu Xia <[email protected]>
---
fs/ext4/super.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 855874ea4b29..60bb3991304e 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -3681,7 +3681,7 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
int blocksize, clustersize;
unsigned int db_count;
unsigned int i;
- int needs_recovery, has_huge_files, has_bigalloc;
+ int needs_recovery, has_huge_files;
__u64 blocks_count;
int err = 0;
unsigned int journal_ioprio = DEFAULT_JOURNAL_IOPRIO;
@@ -4196,8 +4196,7 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)

/* Handle clustersize */
clustersize = BLOCK_SIZE << le32_to_cpu(es->s_log_cluster_size);
- has_bigalloc = ext4_has_feature_bigalloc(sb);
- if (has_bigalloc) {
+ if (ext4_has_feature_bigalloc(sb)) {
if (clustersize < blocksize) {
ext4_msg(sb, KERN_ERR,
"cluster size (%d) smaller than "
--
2.20.0


2020-04-16 00:43:31

by Andreas Dilger

[permalink] [raw]
Subject: Re: [PATCH] ext4: remove redundant variable has_bigalloc in ext4_fill_super

On Apr 15, 2020, at 1:25 AM, [email protected] wrote:
>
> From: Kaixu Xia <[email protected]>
>
> We can use the ext4_has_feature_bigalloc() function directly to check
> bigalloc feature and the variable has_bigalloc is reduncant, so remove
> it.
>
> Signed-off-by: Kaixu Xia <[email protected]>

Reviewed-by: Andreas Dilger <[email protected]>

> ---
> fs/ext4/super.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 855874ea4b29..60bb3991304e 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -3681,7 +3681,7 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
> int blocksize, clustersize;
> unsigned int db_count;
> unsigned int i;
> - int needs_recovery, has_huge_files, has_bigalloc;
> + int needs_recovery, has_huge_files;
> __u64 blocks_count;
> int err = 0;
> unsigned int journal_ioprio = DEFAULT_JOURNAL_IOPRIO;
> @@ -4196,8 +4196,7 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
>
> /* Handle clustersize */
> clustersize = BLOCK_SIZE << le32_to_cpu(es->s_log_cluster_size);
> - has_bigalloc = ext4_has_feature_bigalloc(sb);
> - if (has_bigalloc) {
> + if (ext4_has_feature_bigalloc(sb)) {
> if (clustersize < blocksize) {
> ext4_msg(sb, KERN_ERR,
> "cluster size (%d) smaller than "
> --
> 2.20.0
>


Cheers, Andreas





Attachments:
signature.asc (890.00 B)
Message signed with OpenPGP

2020-05-14 14:22:02

by Theodore Ts'o

[permalink] [raw]
Subject: Re: [PATCH] ext4: remove redundant variable has_bigalloc in ext4_fill_super

On Wed, Apr 15, 2020 at 03:25:42PM +0800, [email protected] wrote:
> From: Kaixu Xia <[email protected]>
>
> We can use the ext4_has_feature_bigalloc() function directly to check
> bigalloc feature and the variable has_bigalloc is reduncant, so remove
> it.
>
> Signed-off-by: Kaixu Xia <[email protected]>
> Reviewed-by: Andreas Dilger <[email protected]>

Applied, thanks.

- Ted