2021-12-10 08:23:16

by Tzung-Bi Shih

[permalink] [raw]
Subject: [PATCH] mt76: mt7921: reduce log severity levels for informative messages

"ASIC revision" and "Firmware init done" shouldn't be error messages.
Reduces the severity level to info.

Signed-off-by: Tzung-Bi Shih <[email protected]>
---
drivers/net/wireless/mediatek/mt76/mt7921/mcu.c | 2 +-
drivers/net/wireless/mediatek/mt76/mt7921/pci.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
index 6ada1ebe7d68..99b144fd8db5 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
@@ -882,7 +882,7 @@ static int mt7921_load_firmware(struct mt7921_dev *dev)
dev->mt76.hw->wiphy->wowlan = &mt76_connac_wowlan_support;
#endif /* CONFIG_PM */

- dev_err(dev->mt76.dev, "Firmware init done\n");
+ dev_info(dev->mt76.dev, "Firmware init done\n");

return 0;
}
diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/pci.c b/drivers/net/wireless/mediatek/mt76/mt7921/pci.c
index 305b63fa1a8a..8c53e376aa4e 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7921/pci.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7921/pci.c
@@ -188,7 +188,7 @@ static int mt7921_pci_probe(struct pci_dev *pdev,
tasklet_init(&dev->irq_tasklet, mt7921_irq_tasklet, (unsigned long)dev);
mdev->rev = (mt7921_l1_rr(dev, MT_HW_CHIPID) << 16) |
(mt7921_l1_rr(dev, MT_HW_REV) & 0xff);
- dev_err(mdev->dev, "ASIC revision: %04x\n", mdev->rev);
+ dev_info(mdev->dev, "ASIC revision: %04x\n", mdev->rev);

mt76_wr(dev, MT_WFDMA0_HOST_INT_ENA, 0);

--
2.34.1.173.g76aa8bc2d0-goog



2021-12-10 08:49:21

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] mt76: mt7921: reduce log severity levels for informative messages

Tzung-Bi Shih <[email protected]> writes:

> "ASIC revision" and "Firmware init done" shouldn't be error messages.
> Reduces the severity level to info.
>
> Signed-off-by: Tzung-Bi Shih <[email protected]>
> ---
> drivers/net/wireless/mediatek/mt76/mt7921/mcu.c | 2 +-
> drivers/net/wireless/mediatek/mt76/mt7921/pci.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
> index 6ada1ebe7d68..99b144fd8db5 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
> @@ -882,7 +882,7 @@ static int mt7921_load_firmware(struct mt7921_dev *dev)
> dev->mt76.hw->wiphy->wowlan = &mt76_connac_wowlan_support;
> #endif /* CONFIG_PM */
>
> - dev_err(dev->mt76.dev, "Firmware init done\n");
> + dev_info(dev->mt76.dev, "Firmware init done\n");

Shouldn't that be a debug message? Hard to see how's that useful in
normal operation.

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2021-12-10 09:20:03

by Tzung-Bi Shih

[permalink] [raw]
Subject: Re: [PATCH] mt76: mt7921: reduce log severity levels for informative messages

On Fri, Dec 10, 2021 at 4:49 PM Kalle Valo <[email protected]> wrote:
>
> Tzung-Bi Shih <[email protected]> writes:
[...]
> > diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
> > index 6ada1ebe7d68..99b144fd8db5 100644
> > --- a/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
> > +++ b/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
> > @@ -882,7 +882,7 @@ static int mt7921_load_firmware(struct mt7921_dev *dev)
> > dev->mt76.hw->wiphy->wowlan = &mt76_connac_wowlan_support;
> > #endif /* CONFIG_PM */
> >
> > - dev_err(dev->mt76.dev, "Firmware init done\n");
> > + dev_info(dev->mt76.dev, "Firmware init done\n");
>
> Shouldn't that be a debug message? Hard to see how's that useful in
> normal operation.

I thought the message was an indicator of "the firmware is loaded
completely". Sent v2 to use dbg instead.