clang-struct [1] found that ee_antenna in struct ath5k_eeprom_info is
unused. The commit 1048643ea94d ("ath5k: Clean up eeprom
parsing and add missing calibration data") added it, but did not use it
in any way. Neither, there is a later user.
So remove that unused member.
[1] https://github.com/jirislaby/clang-struct
Signed-off-by: Jiri Slaby (SUSE) <[email protected]>
Cc: Felix Fietkau <[email protected]>
Cc: Nick Kossifidis <[email protected]>
Cc: Luis Chamberlain <[email protected]>
Cc: Kalle Valo <[email protected]>
Cc: [email protected]
---
drivers/net/wireless/ath/ath5k/eeprom.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/wireless/ath/ath5k/eeprom.h b/drivers/net/wireless/ath/ath5k/eeprom.h
index 693296ee9693..e85b713950b1 100644
--- a/drivers/net/wireless/ath/ath5k/eeprom.h
+++ b/drivers/net/wireless/ath/ath5k/eeprom.h
@@ -489,7 +489,4 @@ struct ath5k_eeprom_info {
/* Spur mitigation data (fbin values for spur channels) */
u16 ee_spur_chans[AR5K_EEPROM_N_SPUR_CHANS][AR5K_EEPROM_N_FREQ_BANDS];
-
- /* Antenna raw switch tables */
- u32 ee_antenna[AR5K_EEPROM_N_MODES][AR5K_ANT_MAX];
};
--
2.43.0
"Jiri Slaby (SUSE)" <[email protected]> writes:
> clang-struct [1] found that ee_antenna in struct ath5k_eeprom_info is
> unused. The commit 1048643ea94d ("ath5k: Clean up eeprom
> parsing and add missing calibration data") added it, but did not use it
> in any way. Neither, there is a later user.
>
> So remove that unused member.
>
> [1] https://github.com/jirislaby/clang-struct
clang-struct looks really nice, especially if it can also find unused
structures. What about unused defines or enums, any chance to find those
in the future? :)
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
On 05. 12. 23, 13:07, Kalle Valo wrote:
> "Jiri Slaby (SUSE)" <[email protected]> writes:
>
>> clang-struct [1] found that ee_antenna in struct ath5k_eeprom_info is
>> unused. The commit 1048643ea94d ("ath5k: Clean up eeprom
>> parsing and add missing calibration data") added it, but did not use it
>> in any way. Neither, there is a later user.
>>
>> So remove that unused member.
>>
>> [1] https://github.com/jirislaby/clang-struct
>
> clang-struct looks really nice, especially if it can also find unused
> structures.
It can...
> What about unused defines or enums, any chance to find those
> in the future? :)
All of that is IMO possible (I'm not completely sure about macros,
despite clang ASTs provide a lot of info. Incl. info about them and
their expansion).
It's all limited only by man-force: me.
thanks,
--
js
suse labs
Jiri Slaby <[email protected]> writes:
> On 05. 12. 23, 13:07, Kalle Valo wrote:
>> "Jiri Slaby (SUSE)" <[email protected]> writes:
>>
>>> clang-struct [1] found that ee_antenna in struct ath5k_eeprom_info is
>>> unused. The commit 1048643ea94d ("ath5k: Clean up eeprom
>>> parsing and add missing calibration data") added it, but did not use it
>>> in any way. Neither, there is a later user.
>>>
>>> So remove that unused member.
>>>
>>> [1] https://github.com/jirislaby/clang-struct
>>
>> clang-struct looks really nice, especially if it can also find unused
>> structures.
>
> It can...
Nice!
>> What about unused defines or enums, any chance to find those
>> in the future? :)
>
> All of that is IMO possible (I'm not completely sure about macros,
> despite clang ASTs provide a lot of info. Incl. info about them and
> their expansion).
Too bad, I wish that there would be a tool for that. I suspect wireless
drivers have unused defines and enums, it would be nice to clean up
that.
> It's all limited only by man-force: me.
Yeah, I guessed that. Thanks for making this tool available, hopefully
more people start using it.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
"Jiri Slaby (SUSE)" <[email protected]> wrote:
> clang-struct [1] found that ee_antenna in struct ath5k_eeprom_info is
> unused. The commit 1048643ea94d ("ath5k: Clean up eeprom
> parsing and add missing calibration data") added it, but did not use it
> in any way. Neither, there is a later user.
>
> So remove that unused member.
>
> [1] https://github.com/jirislaby/clang-struct
>
> Signed-off-by: Jiri Slaby (SUSE) <[email protected]>
> Cc: Felix Fietkau <[email protected]>
> Cc: Nick Kossifidis <[email protected]>
> Cc: Luis Chamberlain <[email protected]>
> Cc: Kalle Valo <[email protected]>
> Cc: [email protected]
> Signed-off-by: Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
6783f10a1d07 wifi: ath5k: remove unused ath5k_eeprom_info::ee_antenna
--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches