Re-enable the function rtl8xxxu_gen2_report_connect.
It informs the firmware when connecting to a network. This makes the
firmware enable the rate control, which makes the upload faster.
It also informs the firmware when disconnecting from a network. In the
past this made reconnecting impossible because it was sending the
auth on queue 0x7 (TXDESC_QUEUE_VO) instead of queue 0x12
(TXDESC_QUEUE_MGNT):
wlp0s20f0u3: send auth to 90:55:de:__:__:__ (try 1/3)
wlp0s20f0u3: send auth to 90:55:de:__:__:__ (try 2/3)
wlp0s20f0u3: send auth to 90:55:de:__:__:__ (try 3/3)
wlp0s20f0u3: authentication with 90:55:de:__:__:__ timed out
Probably the firmware disables the unnecessary TX queues when it
knows it's disconnected.
However, this was fixed in commit edd5747aa12e ("wifi: rtl8xxxu: Fix
skb misuse in TX queue selection").
Fixes: c59f13bbead4 ("rtl8xxxu: Work around issue with 8192eu and 8723bu devices not reconn…")
Signed-off-by: Bitterblue Smith <[email protected]>
---
v2:
Report the disconnect as well.
v1 was part of the series "[PATCH 0/4] wifi: rtl8xxxu: A few
improvements".
---
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
index 4b76881cd50d..ba2a16de19ed 100644
--- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
+++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
@@ -4476,12 +4476,9 @@ void rtl8xxxu_gen1_report_connect(struct rtl8xxxu_priv *priv,
void rtl8xxxu_gen2_report_connect(struct rtl8xxxu_priv *priv,
u8 macid, bool connect)
{
-#ifdef RTL8XXXU_GEN2_REPORT_CONNECT
/*
- * Barry Day reports this causes issues with 8192eu and 8723bu
- * devices reconnecting. The reason for this is unclear, but
- * until it is better understood, leave the code in place but
- * disabled, so it is not lost.
+ * The firmware turns on the rate control when it knows it's
+ * connected to a network.
*/
struct h2c_cmd h2c;
@@ -4494,7 +4491,6 @@ void rtl8xxxu_gen2_report_connect(struct rtl8xxxu_priv *priv,
h2c.media_status_rpt.parm &= ~BIT(0);
rtl8xxxu_gen2_h2c_cmd(priv, &h2c, sizeof(h2c.media_status_rpt));
-#endif
}
void rtl8xxxu_gen1_init_aggregation(struct rtl8xxxu_priv *priv)
--
2.37.2
Bitterblue Smith <[email protected]> wrote:
> Re-enable the function rtl8xxxu_gen2_report_connect.
>
> It informs the firmware when connecting to a network. This makes the
> firmware enable the rate control, which makes the upload faster.
>
> It also informs the firmware when disconnecting from a network. In the
> past this made reconnecting impossible because it was sending the
> auth on queue 0x7 (TXDESC_QUEUE_VO) instead of queue 0x12
> (TXDESC_QUEUE_MGNT):
>
> wlp0s20f0u3: send auth to 90:55:de:__:__:__ (try 1/3)
> wlp0s20f0u3: send auth to 90:55:de:__:__:__ (try 2/3)
> wlp0s20f0u3: send auth to 90:55:de:__:__:__ (try 3/3)
> wlp0s20f0u3: authentication with 90:55:de:__:__:__ timed out
>
> Probably the firmware disables the unnecessary TX queues when it
> knows it's disconnected.
>
> However, this was fixed in commit edd5747aa12e ("wifi: rtl8xxxu: Fix
> skb misuse in TX queue selection").
>
> Fixes: c59f13bbead4 ("rtl8xxxu: Work around issue with 8192eu and 8723bu devices not reconn…")
> Signed-off-by: Bitterblue Smith <[email protected]>
Patch applied to wireless-next.git, thanks.
c5ef1cee5745 wifi: rtl8xxxu: gen2: Turn on the rate control
--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Kalle Valo <[email protected]> writes:
> Bitterblue Smith <[email protected]> wrote:
>
>> Re-enable the function rtl8xxxu_gen2_report_connect.
>>
>> It informs the firmware when connecting to a network. This makes the
>> firmware enable the rate control, which makes the upload faster.
>>
>> It also informs the firmware when disconnecting from a network. In the
>> past this made reconnecting impossible because it was sending the
>> auth on queue 0x7 (TXDESC_QUEUE_VO) instead of queue 0x12
>> (TXDESC_QUEUE_MGNT):
>>
>> wlp0s20f0u3: send auth to 90:55:de:__:__:__ (try 1/3)
>> wlp0s20f0u3: send auth to 90:55:de:__:__:__ (try 2/3)
>> wlp0s20f0u3: send auth to 90:55:de:__:__:__ (try 3/3)
>> wlp0s20f0u3: authentication with 90:55:de:__:__:__ timed out
>>
>> Probably the firmware disables the unnecessary TX queues when it
>> knows it's disconnected.
>>
>> However, this was fixed in commit edd5747aa12e ("wifi: rtl8xxxu: Fix
>> skb misuse in TX queue selection").
>>
>> Fixes: c59f13bbead4 ("rtl8xxxu: Work around issue with 8192eu and 8723bu devices not reconn…")
>> Signed-off-by: Bitterblue Smith <[email protected]>
>
> Patch applied to wireless-next.git, thanks.
>
> c5ef1cee5745 wifi: rtl8xxxu: gen2: Turn on the rate control
Please disregard the commit id, the fixes tag is incorrect so I need to
apply it again to fix it.
In commit
c5ef1cee5745 ("wifi: rtl8xxxu: gen2: Turn on the rate control")
Fixes tag
Fixes: c59f13bbead4 ("rtl8xxxu: Work around issue with 8192eu and
8723bu devices not reconn…")
has these problem(s):
- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Bitterblue Smith <[email protected]> wrote:
> Re-enable the function rtl8xxxu_gen2_report_connect.
>
> It informs the firmware when connecting to a network. This makes the
> firmware enable the rate control, which makes the upload faster.
>
> It also informs the firmware when disconnecting from a network. In the
> past this made reconnecting impossible because it was sending the
> auth on queue 0x7 (TXDESC_QUEUE_VO) instead of queue 0x12
> (TXDESC_QUEUE_MGNT):
>
> wlp0s20f0u3: send auth to 90:55:de:__:__:__ (try 1/3)
> wlp0s20f0u3: send auth to 90:55:de:__:__:__ (try 2/3)
> wlp0s20f0u3: send auth to 90:55:de:__:__:__ (try 3/3)
> wlp0s20f0u3: authentication with 90:55:de:__:__:__ timed out
>
> Probably the firmware disables the unnecessary TX queues when it
> knows it's disconnected.
>
> However, this was fixed in commit edd5747aa12e ("wifi: rtl8xxxu: Fix
> skb misuse in TX queue selection").
>
> Fixes: c59f13bbead4 ("rtl8xxxu: Work around issue with 8192eu and 8723bu devices not reconnecting")
> Signed-off-by: Bitterblue Smith <[email protected]>
Patch applied to wireless-next.git, thanks.
791082ec0ab8 wifi: rtl8xxxu: gen2: Turn on the rate control
--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches