Hi,
On Mon, Apr 17, 2023 at 11:41:34AM +0300, Gregory Greenman wrote:
> Start supporting API version 78 for AX devices.
>
This patch sets the ucode version for a large number of devices
to 78, but ucode version 78 is not available for many of those
in linux-firmware. It seems that .78 was skipped for some devices
in linux-firmware, and the last version for several others is .77.
This causes problems when trying to validate if the firmware
listed in MODULE_FIRMWARE actually exists.
Is the missing firmware going to be available at some point,
is there a plan to fix the code to only list actually available
firmware, or is it a wrong assumption to expect that the
firmware listed in the kernel actually exists ?
Thanks,
Guenter
> Signed-off-by: Gregory Greenman <[email protected]>
> Link: https://lore.kernel.org/r/20230417113648.5a4dcbf5a2c1.I125808566fe892ee0865e392bf1b1872daafe8ad@changeid
> Signed-off-by: Johannes Berg <[email protected]>
> ---
> drivers/net/wireless/intel/iwlwifi/cfg/22000.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/cfg/22000.c b/drivers/net/wireless/intel/iwlwifi/cfg/22000.c
> index b98f0ff02362..532d14f61253 100644
> --- a/drivers/net/wireless/intel/iwlwifi/cfg/22000.c
> +++ b/drivers/net/wireless/intel/iwlwifi/cfg/22000.c
> @@ -10,7 +10,7 @@
> #include "fw/api/txq.h"
>
> /* Highest firmware API version supported */
> -#define IWL_22000_UCODE_API_MAX 77
> +#define IWL_22000_UCODE_API_MAX 78
>
> /* Lowest firmware API version supported */
> #define IWL_22000_UCODE_API_MIN 39
> --
> 2.39.2
Hi,
On Thu, 2023-06-01 at 07:33 -0700, Guenter Roeck wrote:
> Hi,
>
> On Mon, Apr 17, 2023 at 11:41:34AM +0300, Gregory Greenman wrote:
> > Start supporting API version 78 for AX devices.
> >
>
> This patch sets the ucode version for a large number of devices
> to 78, but ucode version 78 is not available for many of those
> in linux-firmware. It seems that .78 was skipped for some devices
> in linux-firmware, and the last version for several others is .77.
>
> This causes problems when trying to validate if the firmware
> listed in MODULE_FIRMWARE actually exists.
>
> Is the missing firmware going to be available at some point,
> is there a plan to fix the code to only list actually available
> firmware, or is it a wrong assumption to expect that the
> firmware listed in the kernel actually exists ?
>
> Thanks,
> Guenter
>
> > Signed-off-by: Gregory Greenman <[email protected]>
> > Link: https://lore.kernel.org/r/20230417113648.5a4dcbf5a2c1.I125808566fe892ee0865e392bf1b1872daafe8ad@changeid
> > Signed-off-by: Johannes Berg <[email protected]>
> > ---
> > drivers/net/wireless/intel/iwlwifi/cfg/22000.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/wireless/intel/iwlwifi/cfg/22000.c b/drivers/net/wireless/intel/iwlwifi/cfg/22000.c
> > index b98f0ff02362..532d14f61253 100644
> > --- a/drivers/net/wireless/intel/iwlwifi/cfg/22000.c
> > +++ b/drivers/net/wireless/intel/iwlwifi/cfg/22000.c
> > @@ -10,7 +10,7 @@
> > #include "fw/api/txq.h"
> >
> > /* Highest firmware API version supported */
> > -#define IWL_22000_UCODE_API_MAX 77
> > +#define IWL_22000_UCODE_API_MAX 78
> >
> > /* Lowest firmware API version supported */
> > #define IWL_22000_UCODE_API_MIN 39
> > --
> > 2.39.2
Yes, I'll send it just in couple of days.
On 6/1/23 09:00, Greenman, Gregory wrote:
> Hi,
>
> On Thu, 2023-06-01 at 07:33 -0700, Guenter Roeck wrote:
>> Hi,
>>
>> On Mon, Apr 17, 2023 at 11:41:34AM +0300, Gregory Greenman wrote:
>>> Start supporting API version 78 for AX devices.
>>>
>>
>> This patch sets the ucode version for a large number of devices
>> to 78, but ucode version 78 is not available for many of those
>> in linux-firmware. It seems that .78 was skipped for some devices
>> in linux-firmware, and the last version for several others is .77.
>>
>> This causes problems when trying to validate if the firmware
>> listed in MODULE_FIRMWARE actually exists.
>>
>> Is the missing firmware going to be available at some point,
>> is there a plan to fix the code to only list actually available
>> firmware, or is it a wrong assumption to expect that the
>> firmware listed in the kernel actually exists ?
>>
>> Thanks,
>> Guenter
>>
>>> Signed-off-by: Gregory Greenman <[email protected]>
>>> Link: https://lore.kernel.org/r/20230417113648.5a4dcbf5a2c1.I125808566fe892ee0865e392bf1b1872daafe8ad@changeid
>>> Signed-off-by: Johannes Berg <[email protected]>
>>> ---
>>> drivers/net/wireless/intel/iwlwifi/cfg/22000.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/wireless/intel/iwlwifi/cfg/22000.c b/drivers/net/wireless/intel/iwlwifi/cfg/22000.c
>>> index b98f0ff02362..532d14f61253 100644
>>> --- a/drivers/net/wireless/intel/iwlwifi/cfg/22000.c
>>> +++ b/drivers/net/wireless/intel/iwlwifi/cfg/22000.c
>>> @@ -10,7 +10,7 @@
>>> #include "fw/api/txq.h"
>>>
>>> /* Highest firmware API version supported */
>>> -#define IWL_22000_UCODE_API_MAX 77
>>> +#define IWL_22000_UCODE_API_MAX 78
>>>
>>> /* Lowest firmware API version supported */
>>> #define IWL_22000_UCODE_API_MIN 39
>>> --
>>> 2.39.2
>
> Yes, I'll send it just in couple of days.
>
Thanks!
Guenter
On Thu, 2023-06-01 at 10:40 -0700, Guenter Roeck wrote:
> On 6/1/23 09:00, Greenman, Gregory wrote:
> > Hi,
> >
> > On Thu, 2023-06-01 at 07:33 -0700, Guenter Roeck wrote:
> > > Hi,
> > >
> > > On Mon, Apr 17, 2023 at 11:41:34AM +0300, Gregory Greenman wrote:
> > > > Start supporting API version 78 for AX devices.
> > > >
> > >
> > > This patch sets the ucode version for a large number of devices
> > > to 78, but ucode version 78 is not available for many of those
> > > in linux-firmware. It seems that .78 was skipped for some devices
> > > in linux-firmware, and the last version for several others is .77.
> > >
> > > This causes problems when trying to validate if the firmware
> > > listed in MODULE_FIRMWARE actually exists.
> > >
> > > Is the missing firmware going to be available at some point,
> > > is there a plan to fix the code to only list actually available
> > > firmware, or is it a wrong assumption to expect that the
> > > firmware listed in the kernel actually exists ?
> > >
> > > Thanks,
> > > Guenter
> > >
> > > > Signed-off-by: Gregory Greenman <[email protected]>
> > > > Link: https://lore.kernel.org/r/20230417113648.5a4dcbf5a2c1.I125808566fe892ee0865e392bf1b1872daafe8ad@changeid
> > > > Signed-off-by: Johannes Berg <[email protected]>
> > > > ---
> > > > drivers/net/wireless/intel/iwlwifi/cfg/22000.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/net/wireless/intel/iwlwifi/cfg/22000.c b/drivers/net/wireless/intel/iwlwifi/cfg/22000.c
> > > > index b98f0ff02362..532d14f61253 100644
> > > > --- a/drivers/net/wireless/intel/iwlwifi/cfg/22000.c
> > > > +++ b/drivers/net/wireless/intel/iwlwifi/cfg/22000.c
> > > > @@ -10,7 +10,7 @@
> > > > #include "fw/api/txq.h"
> > > >
> > > > /* Highest firmware API version supported */
> > > > -#define IWL_22000_UCODE_API_MAX 77
> > > > +#define IWL_22000_UCODE_API_MAX 78
> > > >
> > > > /* Lowest firmware API version supported */
> > > > #define IWL_22000_UCODE_API_MIN 39
> > > > --
> > > > 2.39.2
> >
> > Yes, I'll send it just in couple of days.
> >
> Thanks!
>
> Guenter
Sorry, I misunderstood what you said.
The firmwares which remain with version -77 are EOL, and this is the final
version for them. The commit in [1] handles it by freezing maximum firmare
version for the relevant devices.
[1] https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/