On October 24, 2022 2:40:08 PM Linus Walleij <[email protected]> wrote:
> The driver looks up the BCMA parent GPIO driver and checks that
> this succeeds, but then it goes on to use the deprecated GPIO
> call gpio_is_valid() to check the consistency of the .base
> member of the BCMA GPIO struct. Surely this belongs in the
> BCMA driver: we cannot have all drivers performing cosistency
Should be: consistency
>
> checks on the internals of things they are passed.
Apart from the typo in the subject and missing wifi: prefix (replace
'brcm80211' by 'wifi')...
Acked-by: Arend van Spriel <[email protected]>
> Signed-off-by: Linus Walleij <[email protected]>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmsmac/led.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Arend Van Spriel <[email protected]> writes:
> On October 24, 2022 2:40:08 PM Linus Walleij <[email protected]> wrote:
>
>> The driver looks up the BCMA parent GPIO driver and checks that
>> this succeeds, but then it goes on to use the deprecated GPIO
>> call gpio_is_valid() to check the consistency of the .base
>> member of the BCMA GPIO struct. Surely this belongs in the
>> BCMA driver: we cannot have all drivers performing cosistency
>
> Should be: consistency
>
>>
>> checks on the internals of things they are passed.
>
> Apart from the typo in the subject and missing wifi: prefix (replace
> 'brcm80211' by 'wifi')...
I can fix those.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
On Tue, Oct 25, 2022 at 10:09 PM Kalle Valo <[email protected]> wrote:
> Arend Van Spriel <[email protected]> writes:
>
> > On October 24, 2022 2:40:08 PM Linus Walleij <[email protected]> wrote:
> >
> >> The driver looks up the BCMA parent GPIO driver and checks that
> >> this succeeds, but then it goes on to use the deprecated GPIO
> >> call gpio_is_valid() to check the consistency of the .base
> >> member of the BCMA GPIO struct. Surely this belongs in the
> >> BCMA driver: we cannot have all drivers performing cosistency
> >
> > Should be: consistency
> >
> >>
> >> checks on the internals of things they are passed.
> >
> > Apart from the typo in the subject and missing wifi: prefix (replace
> > 'brcm80211' by 'wifi')...
>
> I can fix those.
I am sending a combined patch with this and the other bcma patch
because they happen to depend on each other. Dunno how to tag
a patch that affects bcma and brcn80211 at the same time so you
will probably have to edit it anyway.
Yours,
Linus Walleij