2023-07-12 13:38:56

by Minjie Du

Subject: [PATCH v1] drivers/net: intel: iwlwifi: fix two parameters check in iwl_mei_dbgfs_register()

Make IS_ERR() judge the debugfs_create_dir() function return
in iwl_mei_dbgfs_register().

Signed-off-by: Minjie Du <[email protected]>
---
drivers/net/wireless/intel/iwlwifi/mei/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/mei/main.c b/drivers/net/wireless/intel/iwlwifi/mei/main.c
index 54445f39f..e5d203a62 100644
--- a/drivers/net/wireless/intel/iwlwifi/mei/main.c
+++ b/drivers/net/wireless/intel/iwlwifi/mei/main.c
@@ -1888,7 +1888,7 @@ static void iwl_mei_dbgfs_register(struct iwl_mei *mei)
{
mei->dbgfs_dir = debugfs_create_dir(KBUILD_MODNAME, NULL);

- if (!mei->dbgfs_dir)
+ if (IS_ERR(mei->dbgfs_dir))
return;

debugfs_create_ulong("status", S_IRUSR,
--
2.39.0

2023-07-12 14:05:56

by Nicolas Escande

Subject: Re: [PATCH v1] drivers/net: intel: iwlwifi: fix two parameters check in iwl_mei_dbgfs_register()

On Wed Jul 12, 2023 at 3:14 PM CEST, Minjie Du wrote:
> Make IS_ERR() judge the debugfs_create_dir() function return
> in iwl_mei_dbgfs_register().
>
> Signed-off-by: Minjie Du <[email protected]>
> ---
> drivers/net/wireless/intel/iwlwifi/mei/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/mei/main.c b/drivers/net/wireless/intel/iwlwifi/mei/main.c
> index 54445f39f..e5d203a62 100644
> --- a/drivers/net/wireless/intel/iwlwifi/mei/main.c
> +++ b/drivers/net/wireless/intel/iwlwifi/mei/main.c
> @@ -1888,7 +1888,7 @@ static void iwl_mei_dbgfs_register(struct iwl_mei *mei)
> {
> mei->dbgfs_dir = debugfs_create_dir(KBUILD_MODNAME, NULL);
>
> - if (!mei->dbgfs_dir)
> + if (IS_ERR(mei->dbgfs_dir))
> return;

same as the other one

>
> debugfs_create_ulong("status", S_IRUSR,

2023-08-13 15:38:22

by Greenman, Gregory

Subject: Re: [PATCH v1] drivers/net: intel: iwlwifi: fix two parameters check in iwl_mei_dbgfs_register()

Hi,

On Wed, 2023-07-12 at 21:14 +0800, Minjie Du wrote:
> Make IS_ERR() judge the debugfs_create_dir() function return
> in iwl_mei_dbgfs_register().
>
> Signed-off-by: Minjie Du <[email protected]>
> ---
>  drivers/net/wireless/intel/iwlwifi/mei/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/mei/main.c b/drivers/net/wireless/intel/iwlwifi/mei/main.c
> index 54445f39f..e5d203a62 100644
> --- a/drivers/net/wireless/intel/iwlwifi/mei/main.c
> +++ b/drivers/net/wireless/intel/iwlwifi/mei/main.c
> @@ -1888,7 +1888,7 @@ static void iwl_mei_dbgfs_register(struct iwl_mei *mei)
>  {
>         mei->dbgfs_dir = debugfs_create_dir(KBUILD_MODNAME, NULL);
>  
> -       if (!mei->dbgfs_dir)
> +       if (IS_ERR(mei->dbgfs_dir))
>                 return;
>  
>         debugfs_create_ulong("status", S_IRUSR,

The title should be:

wifi: iwlwifi: mei: ...

Also, why two parameters? It only fixes dbgfs_dir?