2019-09-03 09:14:56

by Tony Chuang

[permalink] [raw]
Subject: [PATCH rebased 0/2] rtw88: pci: interrupt routine improvement

From: Yan-Hsuan Chuang <[email protected]>

This patch set includes two patches to improve PCI interrupt routine.
One is to reduce HW IRQ time, the other is to enable MSI.

The patches can be found at:
https://patchwork.kernel.org/patch/11114043/
https://patchwork.kernel.org/patch/11126007/

They were rebased properly to resolve conflicts.


Jian-Hong Pan (1):
rtw88: pci: Move a mass of jobs in hw IRQ to soft IRQ

Yu-Yen Ting (1):
rtw88: pci: enable MSI interrupt

drivers/net/wireless/realtek/rtw88/pci.c | 70 +++++++++++++++++++++++++++++---
1 file changed, 64 insertions(+), 6 deletions(-)

--
2.7.4


2019-09-03 11:11:25

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH rebased 0/2] rtw88: pci: interrupt routine improvement

<[email protected]> writes:

> From: Yan-Hsuan Chuang <[email protected]>
>
> This patch set includes two patches to improve PCI interrupt routine.
> One is to reduce HW IRQ time, the other is to enable MSI.
>
> The patches can be found at:
> https://patchwork.kernel.org/patch/11114043/
> https://patchwork.kernel.org/patch/11126007/
>
> They were rebased properly to resolve conflicts.

In the future, please use version markings ("v2", "v3" etc) in the
Subject and not something like "rebased". This makes my life easier as I
can immeaditely see what is the latest version I should take.

--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2019-09-03 11:58:53

by Tony Chuang

[permalink] [raw]
Subject: RE: [PATCH rebased 0/2] rtw88: pci: interrupt routine improvement

> From: Kalle Valo [mailto:[email protected]]
>
> <[email protected]> writes:
>
> > From: Yan-Hsuan Chuang <[email protected]>
> >
> > This patch set includes two patches to improve PCI interrupt routine.
> > One is to reduce HW IRQ time, the other is to enable MSI.
> >
> > The patches can be found at:
> > https://patchwork.kernel.org/patch/11114043/
> > https://patchwork.kernel.org/patch/11126007/
> >
> > They were rebased properly to resolve conflicts.
>
> In the future, please use version markings ("v2", "v3" etc) in the
> Subject and not something like "rebased". This makes my life easier as I
> can immeaditely see what is the latest version I should take.
>

Oh, I just combine two patches with different version markings.
And I don't know how to write a proper subject in this case, maybe
I shouldn't use cover latter?

Yan-Hsuan

2019-09-03 12:18:13

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH rebased 0/2] rtw88: pci: interrupt routine improvement

Tony Chuang <[email protected]> writes:

>> From: Kalle Valo [mailto:[email protected]]
>>
>> <[email protected]> writes:
>>
>> > From: Yan-Hsuan Chuang <[email protected]>
>> >
>> > This patch set includes two patches to improve PCI interrupt routine.
>> > One is to reduce HW IRQ time, the other is to enable MSI.
>> >
>> > The patches can be found at:
>> > https://patchwork.kernel.org/patch/11114043/
>> > https://patchwork.kernel.org/patch/11126007/
>> >
>> > They were rebased properly to resolve conflicts.
>>
>> In the future, please use version markings ("v2", "v3" etc) in the
>> Subject and not something like "rebased". This makes my life easier as I
>> can immeaditely see what is the latest version I should take.
>>
>
> Oh, I just combine two patches with different version markings.
> And I don't know how to write a proper subject in this case, maybe
> I shouldn't use cover latter?

The cover letter was helpful, please continue using that. IIRC the
separate patches were v3 and v4, so using v5 would have been clear for
me. But no need to resend because of this, just trying to streamline the
process and optimise my time :)

--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2019-09-03 12:22:06

by Tony Chuang

[permalink] [raw]
Subject: RE: [PATCH rebased 0/2] rtw88: pci: interrupt routine improvement

> From: Kalle Valo [mailto:[email protected]]
>
> Tony Chuang <[email protected]> writes:
>
> >> From: Kalle Valo [mailto:[email protected]]
> >>
> >> <[email protected]> writes:
> >>
> >> > From: Yan-Hsuan Chuang <[email protected]>
> >> >
> >> > This patch set includes two patches to improve PCI interrupt routine.
> >> > One is to reduce HW IRQ time, the other is to enable MSI.
> >> >
> >> > The patches can be found at:
> >> > https://patchwork.kernel.org/patch/11114043/
> >> > https://patchwork.kernel.org/patch/11126007/
> >> >
> >> > They were rebased properly to resolve conflicts.
> >>
> >> In the future, please use version markings ("v2", "v3" etc) in the
> >> Subject and not something like "rebased". This makes my life easier as I
> >> can immeaditely see what is the latest version I should take.
> >>
> >
> > Oh, I just combine two patches with different version markings.
> > And I don't know how to write a proper subject in this case, maybe
> > I shouldn't use cover latter?
>
> The cover letter was helpful, please continue using that. IIRC the
> separate patches were v3 and v4, so using v5 would have been clear for
> me. But no need to resend because of this, just trying to streamline the
> process and optimise my time :)
>

Sure! Next time I know I should pick the largest number.

Thanks,
Yan-Hsuan