2022-09-13 05:02:01

by Wen Gong

[permalink] [raw]
Subject: mlo rx nss value 0 of wifi

Hi Johannes,

Currently for MLO test, the others links's rx_nss of struct
ieee80211_link_sta is still value 0 in ieee80211_set_associated(),
becaue they are not pass into ieee80211_sta_set_rx_nss() in
mac80211 except the deflink which means the primary link in
rate_control_rate_init(). This lead driver get nss = 0 for
other links. Will you fix it or is it design by default?

Only primary link has valid rx_nss value which is not 0 by below call stack.
ieee80211_assoc_success()
    ->rate_control_rate_init(sta);
        ->ieee80211_sta_set_rx_nss(&sta->deflink);


2022-09-28 15:21:20

by Wen Gong

[permalink] [raw]
Subject: Re: mlo rx nss value 0 of wifi

Hi Johannes,

May I get your comment about this?

On 9/13/2022 12:37 PM, Wen Gong wrote:
> Hi Johannes,
>
> Currently for MLO test, the others links's rx_nss of struct
> ieee80211_link_sta is still value 0 in ieee80211_set_associated(),
> becaue they are not pass into ieee80211_sta_set_rx_nss() in
> mac80211 except the deflink which means the primary link in
> rate_control_rate_init(). This lead driver get nss = 0 for
> other links. Will you fix it or is it design by default?
>
> Only primary link has valid rx_nss value which is not 0 by below call
> stack.
> ieee80211_assoc_success()
>     ->rate_control_rate_init(sta);
>         ->ieee80211_sta_set_rx_nss(&sta->deflink);

2022-10-17 07:19:31

by Wen Gong

[permalink] [raw]
Subject: Re: wifi: mac80211: mlo rx nss value 0 of wifi

Hi Johannes,

May I get your comment about this?

On 9/13/2022 12:37 PM, Wen Gong wrote:
> Hi Johannes,
>
> Currently for MLO test, the others links's rx_nss of struct
> ieee80211_link_sta is still value 0 in ieee80211_set_associated(),
> becaue they are not pass into ieee80211_sta_set_rx_nss() in
> mac80211 except the deflink which means the primary link in
> rate_control_rate_init(). This lead driver get nss = 0 for
> other links. Will you fix it or is it design by default?
>
> Only primary link has valid rx_nss value which is not 0 by below call
> stack.
> ieee80211_assoc_success()
>     ->rate_control_rate_init(sta);
>         ->ieee80211_sta_set_rx_nss(&sta->deflink);

2022-10-17 07:58:50

by Johannes Berg

[permalink] [raw]
Subject: Re: wifi: mac80211: mlo rx nss value 0 of wifi

Hi,

> > Currently for MLO test, the others links's rx_nss of struct
> > ieee80211_link_sta is still value 0 in ieee80211_set_associated(),
> > becaue they are not pass into ieee80211_sta_set_rx_nss() in
> > mac80211 except the deflink which means the primary link in
> > rate_control_rate_init(). This lead driver get nss = 0 for
> > other links. Will you fix it or is it design by default?
> >
> > Only primary link has valid rx_nss value which is not 0 by below call
> > stack.
> > ieee80211_assoc_success()
> >     ->rate_control_rate_init(sta);
> >         ->ieee80211_sta_set_rx_nss(&sta->deflink);

Right, none of the rate scaling related stuff was updated yet.

Want to work on it? :)

johannes