2023-08-30 18:33:59

by Steven Rostedt

[permalink] [raw]
Subject: Re: [PATCH v3 1/1] tracing/kprobes: Return EADDRNOTAVAIL when func matches several symbols

On Fri, 25 Aug 2023 22:13:21 +0900
Masami Hiramatsu (Google) <[email protected]> wrote:

> > Excellent catch! Thank you, I will apply this patch and send v4 right after.
> > Regarding test, do you think I can add a test for the EADDRNOTAVAIL case?
>
> Hmm, in that case, you need to change something in tracefs/README so that
> we can identify the kernel has different behavior. Or we have to change
> this is a "Fix" for backporting.

I prefer this to be a Fix and backported.

Thanks,

-- Steve


2023-09-05 16:21:51

by Francis Laniel

[permalink] [raw]
Subject: Re: [PATCH v3 1/1] tracing/kprobes: Return EADDRNOTAVAIL when func matches several symbols

Hi.

Le mercredi 30 ao?t 2023, 01:57:19 CEST Steven Rostedt a ?crit :
> On Fri, 25 Aug 2023 22:13:21 +0900
>
> Masami Hiramatsu (Google) <[email protected]> wrote:
> > > Excellent catch! Thank you, I will apply this patch and send v4 right
> > > after. Regarding test, do you think I can add a test for the
> > > EADDRNOTAVAIL case?>
> > Hmm, in that case, you need to change something in tracefs/README so that
> > we can identify the kernel has different behavior. Or we have to change
> > this is a "Fix" for backporting.
>
> I prefer this to be a Fix and backported.

This makes sense, I will send v5 to stable mailing list too!

> Thanks,
>
> -- Steve

Best regards.


2023-10-18 06:31:16

by Masami Hiramatsu

[permalink] [raw]
Subject: Re: [PATCH v3 1/1] tracing/kprobes: Return EADDRNOTAVAIL when func matches several symbols

Hi Francis,

On Thu, 31 Aug 2023 09:14:55 +0200
Francis Laniel <[email protected]> wrote:

> Hi.
>
> Le mercredi 30 août 2023, 01:57:19 CEST Steven Rostedt a écrit :
> > On Fri, 25 Aug 2023 22:13:21 +0900
> >
> > Masami Hiramatsu (Google) <[email protected]> wrote:
> > > > Excellent catch! Thank you, I will apply this patch and send v4 right
> > > > after. Regarding test, do you think I can add a test for the
> > > > EADDRNOTAVAIL case?>
> > > Hmm, in that case, you need to change something in tracefs/README so that
> > > we can identify the kernel has different behavior. Or we have to change
> > > this is a "Fix" for backporting.
> >
> > I prefer this to be a Fix and backported.
>
> This makes sense, I will send v5 to stable mailing list too!

I missed this a while. did you send v5 ? I could not find in my mbox.

Thank you,

>
> > Thanks,
> >
> > -- Steve
>
> Best regards.
>
>


--
Masami Hiramatsu (Google) <[email protected]>

2023-10-18 14:43:56

by Francis Laniel

[permalink] [raw]
Subject: Re: [PATCH v3 1/1] tracing/kprobes: Return EADDRNOTAVAIL when func matches several symbols

Hi!

Le mercredi 18 octobre 2023, 09:30:20 EEST Masami Hiramatsu a ?crit :
> Hi Francis,
>
> On Thu, 31 Aug 2023 09:14:55 +0200
>
> Francis Laniel <[email protected]> wrote:
> > Hi.
> >
> > Le mercredi 30 ao?t 2023, 01:57:19 CEST Steven Rostedt a ?crit :
> > > On Fri, 25 Aug 2023 22:13:21 +0900
> > >
> > > Masami Hiramatsu (Google) <[email protected]> wrote:
> > > > > Excellent catch! Thank you, I will apply this patch and send v4
> > > > > right
> > > > > after. Regarding test, do you think I can add a test for the
> > > > > EADDRNOTAVAIL case?>
> > > >
> > > > Hmm, in that case, you need to change something in tracefs/README so
> > > > that
> > > > we can identify the kernel has different behavior. Or we have to
> > > > change
> > > > this is a "Fix" for backporting.
> > >
> > > I prefer this to be a Fix and backported.
> >
> > This makes sense, I will send v5 to stable mailing list too!
>
> I missed this a while. did you send v5 ? I could not find in my mbox.

Sorry, I took a bit of time before sending the v5 as I wanted to wait for
Alessandro patchset to be merged first.
As it seems more work is needed on his contribution I think we can go with
this fix first.

> Thank you,
>
> > > Thanks,
> > >
> > > -- Steve
> >
> > Best regards.

Best regards.