2019-11-22 12:36:00

by Chen Wandun

[permalink] [raw]
Subject: [PATCH] net: dsa: ocelot: fix "should it be static?" warnings

Fix following sparse warnings:
drivers/net/dsa/ocelot/felix.c:351:6: warning: symbol 'felix_txtstamp' was not declared. Should it be static?

Signed-off-by: Chen Wandun <[email protected]>
---
drivers/net/dsa/ocelot/felix.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/dsa/ocelot/felix.c b/drivers/net/dsa/ocelot/felix.c
index 167e415..b7f9246 100644
--- a/drivers/net/dsa/ocelot/felix.c
+++ b/drivers/net/dsa/ocelot/felix.c
@@ -348,8 +348,8 @@ static bool felix_rxtstamp(struct dsa_switch *ds, int port,
return false;
}

-bool felix_txtstamp(struct dsa_switch *ds, int port,
- struct sk_buff *clone, unsigned int type)
+static bool felix_txtstamp(struct dsa_switch *ds, int port,
+ struct sk_buff *clone, unsigned int type)
{
struct ocelot *ocelot = ds->priv;
struct ocelot_port *ocelot_port = ocelot->ports[port];
--
2.7.4


2019-11-22 15:33:59

by Vivien Didelot

[permalink] [raw]
Subject: Re: [PATCH] net: dsa: ocelot: fix "should it be static?" warnings

On Fri, 22 Nov 2019 20:32:45 +0800, Chen Wandun <[email protected]> wrote:
> Fix following sparse warnings:
> drivers/net/dsa/ocelot/felix.c:351:6: warning: symbol 'felix_txtstamp' was not declared. Should it be static?
>
> Signed-off-by: Chen Wandun <[email protected]>

Reviewed-by: Vivien Didelot <[email protected]>

2019-11-22 18:12:43

by David Miller

[permalink] [raw]
Subject: Re: [PATCH] net: dsa: ocelot: fix "should it be static?" warnings

From: Chen Wandun <[email protected]>
Date: Fri, 22 Nov 2019 20:32:45 +0800

> Fix following sparse warnings:
> drivers/net/dsa/ocelot/felix.c:351:6: warning: symbol 'felix_txtstamp' was not declared. Should it be static?
>
> Signed-off-by: Chen Wandun <[email protected]>

Next time please indicate _explicitly_ which tree your patch is targetting,
because especially in this case the change is only relevant for "net-next"

Also, please provide a proper Fixes: tag.