o Making pdata NULL check to (!pdata) as coding statndard
and all other checks in file.
o Removing redundant check of pdata, because we already
check for pdata, and also derefernced before this check
Signed-off-by: Maninder Singh <[email protected]>
Reviewed-by: Vaneet Narang <[email protected]>
---
drivers/mfd/t7l66xb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/t7l66xb.c b/drivers/mfd/t7l66xb.c
index c09fb5d..854b05f 100644
--- a/drivers/mfd/t7l66xb.c
+++ b/drivers/mfd/t7l66xb.c
@@ -318,7 +318,7 @@ static int t7l66xb_probe(struct platform_device *dev)
struct resource *iomem, *rscr;
int ret;
- if (pdata == NULL)
+ if (!pdata)
return -EINVAL;
iomem = platform_get_resource(dev, IORESOURCE_MEM, 0);
@@ -371,7 +371,7 @@ static int t7l66xb_probe(struct platform_device *dev)
clk_prepare_enable(t7l66xb->clk48m);
- if (pdata && pdata->enable)
+ if (pdata->enable)
pdata->enable(dev);
/* Mask all interrupts */
--
1.7.9.5
On Tue, 30 Jun 2015, Maninder Singh wrote:
> o Making pdata NULL check to (!pdata) as coding statndard
> and all other checks in file.
> o Removing redundant check of pdata, because we already
> check for pdata, and also derefernced before this check
>
> Signed-off-by: Maninder Singh <[email protected]>
> Reviewed-by: Vaneet Narang <[email protected]>
> ---
> drivers/mfd/t7l66xb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, with a properly formatted subject line.
> diff --git a/drivers/mfd/t7l66xb.c b/drivers/mfd/t7l66xb.c
> index c09fb5d..854b05f 100644
> --- a/drivers/mfd/t7l66xb.c
> +++ b/drivers/mfd/t7l66xb.c
> @@ -318,7 +318,7 @@ static int t7l66xb_probe(struct platform_device *dev)
> struct resource *iomem, *rscr;
> int ret;
>
> - if (pdata == NULL)
> + if (!pdata)
> return -EINVAL;
>
> iomem = platform_get_resource(dev, IORESOURCE_MEM, 0);
> @@ -371,7 +371,7 @@ static int t7l66xb_probe(struct platform_device *dev)
>
> clk_prepare_enable(t7l66xb->clk48m);
>
> - if (pdata && pdata->enable)
> + if (pdata->enable)
> pdata->enable(dev);
>
> /* Mask all interrupts */
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
On Wed, 01 Jul 2015, Lee Jones wrote:
> On Tue, 30 Jun 2015, Maninder Singh wrote:
>
> > o Making pdata NULL check to (!pdata) as coding statndard
> > and all other checks in file.
> > o Removing redundant check of pdata, because we already
> > check for pdata, and also derefernced before this check
> >
> > Signed-off-by: Maninder Singh <[email protected]>
> > Reviewed-by: Vaneet Narang <[email protected]>
> > ---
> > drivers/mfd/t7l66xb.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Applied, with a properly formatted subject line.
Should have probably been more forthcomming with some advice.
Next time, please use `git log --oneline -- <subsystem>` to see what
the accepted format is.
> > diff --git a/drivers/mfd/t7l66xb.c b/drivers/mfd/t7l66xb.c
> > index c09fb5d..854b05f 100644
> > --- a/drivers/mfd/t7l66xb.c
> > +++ b/drivers/mfd/t7l66xb.c
> > @@ -318,7 +318,7 @@ static int t7l66xb_probe(struct platform_device *dev)
> > struct resource *iomem, *rscr;
> > int ret;
> >
> > - if (pdata == NULL)
> > + if (!pdata)
> > return -EINVAL;
> >
> > iomem = platform_get_resource(dev, IORESOURCE_MEM, 0);
> > @@ -371,7 +371,7 @@ static int t7l66xb_probe(struct platform_device *dev)
> >
> > clk_prepare_enable(t7l66xb->clk48m);
> >
> > - if (pdata && pdata->enable)
> > + if (pdata->enable)
> > pdata->enable(dev);
> >
> > /* Mask all interrupts */
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
2015-07-01 16:40 GMT+09:00 Lee Jones <[email protected]>:
> On Wed, 01 Jul 2015, Lee Jones wrote:
>> On Tue, 30 Jun 2015, Maninder Singh wrote:
>>
>> > o Making pdata NULL check to (!pdata) as coding statndard
>> > and all other checks in file.
>> > o Removing redundant check of pdata, because we already
>> > check for pdata, and also derefernced before this check
>> >
>> > Signed-off-by: Maninder Singh <[email protected]>
>> > Reviewed-by: Vaneet Narang <[email protected]>
>> > ---
>> > drivers/mfd/t7l66xb.c | 4 ++--
>> > 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> Applied, with a properly formatted subject line.
>
> Should have probably been more forthcomming with some advice.
>
> Next time, please use `git log --oneline -- <subsystem>` to see what
> the accepted format is.
... and a spell-check could be useful as well :). The reviewed-by tag
was not sent on LKML and the person (Vaneet Narang) was not even CC-ed
so I think it should be dropped.
Best regards,
Krzysztof
On Wed, 01 Jul 2015, Krzysztof Kozlowski wrote:
> 2015-07-01 16:40 GMT+09:00 Lee Jones <[email protected]>:
> > On Wed, 01 Jul 2015, Lee Jones wrote:
> >> On Tue, 30 Jun 2015, Maninder Singh wrote:
> >>
> >> > o Making pdata NULL check to (!pdata) as coding statndard
> >> > and all other checks in file.
> >> > o Removing redundant check of pdata, because we already
> >> > check for pdata, and also derefernced before this check
> >> >
> >> > Signed-off-by: Maninder Singh <[email protected]>
> >> > Reviewed-by: Vaneet Narang <[email protected]>
> >> > ---
> >> > drivers/mfd/t7l66xb.c | 4 ++--
> >> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> Applied, with a properly formatted subject line.
> >
> > Should have probably been more forthcomming with some advice.
> >
> > Next time, please use `git log --oneline -- <subsystem>` to see what
> > the accepted format is.
>
> ... and a spell-check could be useful as well :). The reviewed-by tag
> was not sent on LKML and the person (Vaneet Narang) was not even CC-ed
> so I think it should be dropped.
Fair points. Patch dropped.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
2015-07-01 23:08 GMT+09:00 Lee Jones <[email protected]>:
> On Wed, 01 Jul 2015, Krzysztof Kozlowski wrote:
>
>> 2015-07-01 16:40 GMT+09:00 Lee Jones <[email protected]>:
>> > On Wed, 01 Jul 2015, Lee Jones wrote:
>> >> On Tue, 30 Jun 2015, Maninder Singh wrote:
>> >>
>> >> > o Making pdata NULL check to (!pdata) as coding statndard
>> >> > and all other checks in file.
>> >> > o Removing redundant check of pdata, because we already
>> >> > check for pdata, and also derefernced before this check
>> >> >
>> >> > Signed-off-by: Maninder Singh <[email protected]>
>> >> > Reviewed-by: Vaneet Narang <[email protected]>
>> >> > ---
>> >> > drivers/mfd/t7l66xb.c | 4 ++--
>> >> > 1 file changed, 2 insertions(+), 2 deletions(-)
>> >>
>> >> Applied, with a properly formatted subject line.
>> >
>> > Should have probably been more forthcomming with some advice.
>> >
>> > Next time, please use `git log --oneline -- <subsystem>` to see what
>> > the accepted format is.
>>
>> ... and a spell-check could be useful as well :). The reviewed-by tag
>> was not sent on LKML and the person (Vaneet Narang) was not even CC-ed
>> so I think it should be dropped.
>
> Fair points. Patch dropped.
I meant the reviewed-by tag should be dropped :) .
So now... Maninder Singh, could you resent the patch with this minor
issues fixed?
Best regards,
Krzysztof
Hello,
>>> >> >
>>> >> > Signed-off-by: Maninder Singh <[email protected]>
>>> >> > Reviewed-by: Vaneet Narang <[email protected]>
>>> >> > ---
>>> >> > drivers/mfd/t7l66xb.c | 4 ++--
>>> >> > 1 file changed, 2 insertions(+), 2 deletions(-)
>>> >>
>>> >> Applied, with a properly formatted subject line.
>>> >
>>> > Should have probably been more forthcomming with some advice.
>>> >
>>> > Next time, please use `git log --oneline -- <subsystem>` to see what
>>> > the accepted format is.
I did not know this thing.
I will keep that in mind from next time thanks.
>>> ... and a spell-check could be useful as well :). The reviewed-by tag
>>> was not sent on LKML and the person (Vaneet Narang) was not even CC-ed
>>> so I think it should be dropped.
Thanks for your feedback and noticing spell mistake "statndard" :-) and I applied reviewed-by tag in patch,
it is not from LKML, because if we reply any mail, our email client broke the mail thread,
Like my this reply will break down the mail chain from LKML.
>> Fair points. Patch dropped.
>
>I meant the reviewed-by tag should be dropped :) .
>
>So now... Maninder Singh, could you resent the patch with this minor
>issues fixed?
Yes I am sending patch with these fixes.
Thanks,
Maninder
.........
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay? ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?