Hi all,
Changes since 20130827:
The f2fs tree lost its build failure.
The md tree gained a conflict against the arm tree.
The libata tree lost its build failure.
The spi tree lost its build failure.
The arm-soc tree gained conflicts against the usb tree.
The dma-mapping tree gained a conflict against the driver-core tree.
The akpm-current tree gained a conflict against the net tree.
----------------------------------------------------------------------------
My build here breaks like this:
CC drivers/usb/host/xhci-ring.o
CC drivers/video/console/softcursor.o
drivers/usb/host/xhci-ring.c: In function 'xhci_queue_intr_tx':
drivers/usb/host/xhci-ring.c:3090:3: error: implicit declaration of
function 'DEFINE_DYNAMIC_DEBUG_METADATA'
[-Werror=implicit-function-declaration]
drivers/usb/host/xhci-ring.c:3090:3: error: 'descriptor' undeclared
(first use in this function)
drivers/usb/host/xhci-ring.c:3090:3: note: each undeclared identifier
is reported only once for each function it appears in
drivers/usb/host/xhci-ring.c:3090:3: error: implicit declaration of
function '__dynamic_pr_debug' [-Werror=implicit-function-declaration]
drivers/usb/host/xhci-ring.c: In function 'xhci_queue_isoc_tx_prepare':
drivers/usb/host/xhci-ring.c:3875:3: error: 'descriptor' undeclared
(first use in this function)
cc1: some warnings being treated as errors
make[5]: *** [drivers/usb/host/xhci-ring.o] Error 1
make[4]: *** [drivers/usb/host] Error 2
My kernel-config is attached.
Regards,
- Sedat -
On Wed, Aug 28, 2013 at 11:49 AM, Sedat Dilek <[email protected]> wrote:
> Hi all,
>
> Changes since 20130827:
>
> The f2fs tree lost its build failure.
>
> The md tree gained a conflict against the arm tree.
>
> The libata tree lost its build failure.
>
> The spi tree lost its build failure.
>
> The arm-soc tree gained conflicts against the usb tree.
>
> The dma-mapping tree gained a conflict against the driver-core tree.
>
> The akpm-current tree gained a conflict against the net tree.
>
> ----------------------------------------------------------------------------
>
> My build here breaks like this:
>
> CC drivers/usb/host/xhci-ring.o
> CC drivers/video/console/softcursor.o
> drivers/usb/host/xhci-ring.c: In function 'xhci_queue_intr_tx':
> drivers/usb/host/xhci-ring.c:3090:3: error: implicit declaration of
> function 'DEFINE_DYNAMIC_DEBUG_METADATA'
> [-Werror=implicit-function-declaration]
> drivers/usb/host/xhci-ring.c:3090:3: error: 'descriptor' undeclared
> (first use in this function)
> drivers/usb/host/xhci-ring.c:3090:3: note: each undeclared identifier
> is reported only once for each function it appears in
> drivers/usb/host/xhci-ring.c:3090:3: error: implicit declaration of
> function '__dynamic_pr_debug' [-Werror=implicit-function-declaration]
> drivers/usb/host/xhci-ring.c: In function 'xhci_queue_isoc_tx_prepare':
> drivers/usb/host/xhci-ring.c:3875:3: error: 'descriptor' undeclared
> (first use in this function)
> cc1: some warnings being treated as errors
> make[5]: *** [drivers/usb/host/xhci-ring.o] Error 1
> make[4]: *** [drivers/usb/host] Error 2
>
> My kernel-config is attached.
>
Looks like <linux/device.h> or <linux/dynamic_debug.h> is missing.
$ egrep -w '__dynamic_pr_debug|DEFINE_DYNAMIC_DEBUG_METADATA' -nr linux/include/
linux/include/linux/device.h:1118:
DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \
linux/include/linux/device.h:1121:
__dynamic_pr_debug(&descriptor, pr_fmt(fmt), \
linux/include/linux/dynamic_debug.h:45:int __dynamic_pr_debug(struct
_ddebug *descriptor, const char *fmt, ...);
linux/include/linux/dynamic_debug.h:63:#define
DEFINE_DYNAMIC_DEBUG_METADATA(name, fmt) \
linux/include/linux/dynamic_debug.h:76:
DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \
linux/include/linux/dynamic_debug.h:78:
__dynamic_pr_debug(&descriptor, pr_fmt(fmt), \
linux/include/linux/dynamic_debug.h:84:
DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \
linux/include/linux/dynamic_debug.h:92:
DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \
linux/include/linux/dynamic_debug.h:101:
DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, \
Can't say which one is preferred here.
- Sedat -
On Wed, Aug 28, 2013 at 11:56 AM, Sedat Dilek <[email protected]> wrote:
> On Wed, Aug 28, 2013 at 11:49 AM, Sedat Dilek <[email protected]> wrote:
>> Hi all,
>>
>> Changes since 20130827:
>>
>> The f2fs tree lost its build failure.
>>
>> The md tree gained a conflict against the arm tree.
>>
>> The libata tree lost its build failure.
>>
>> The spi tree lost its build failure.
>>
>> The arm-soc tree gained conflicts against the usb tree.
>>
>> The dma-mapping tree gained a conflict against the driver-core tree.
>>
>> The akpm-current tree gained a conflict against the net tree.
>>
>> ----------------------------------------------------------------------------
>>
>> My build here breaks like this:
>>
>> CC drivers/usb/host/xhci-ring.o
>> CC drivers/video/console/softcursor.o
>> drivers/usb/host/xhci-ring.c: In function 'xhci_queue_intr_tx':
>> drivers/usb/host/xhci-ring.c:3090:3: error: implicit declaration of
>> function 'DEFINE_DYNAMIC_DEBUG_METADATA'
>> [-Werror=implicit-function-declaration]
>> drivers/usb/host/xhci-ring.c:3090:3: error: 'descriptor' undeclared
>> (first use in this function)
>> drivers/usb/host/xhci-ring.c:3090:3: note: each undeclared identifier
>> is reported only once for each function it appears in
>> drivers/usb/host/xhci-ring.c:3090:3: error: implicit declaration of
>> function '__dynamic_pr_debug' [-Werror=implicit-function-declaration]
>> drivers/usb/host/xhci-ring.c: In function 'xhci_queue_isoc_tx_prepare':
>> drivers/usb/host/xhci-ring.c:3875:3: error: 'descriptor' undeclared
>> (first use in this function)
>> cc1: some warnings being treated as errors
>> make[5]: *** [drivers/usb/host/xhci-ring.o] Error 1
>> make[4]: *** [drivers/usb/host] Error 2
>>
>> My kernel-config is attached.
>>
>
> Looks like <linux/device.h> or <linux/dynamic_debug.h> is missing.
>
> $ egrep -w '__dynamic_pr_debug|DEFINE_DYNAMIC_DEBUG_METADATA' -nr linux/include/
> linux/include/linux/device.h:1118:
> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \
> linux/include/linux/device.h:1121:
> __dynamic_pr_debug(&descriptor, pr_fmt(fmt), \
> linux/include/linux/dynamic_debug.h:45:int __dynamic_pr_debug(struct
> _ddebug *descriptor, const char *fmt, ...);
> linux/include/linux/dynamic_debug.h:63:#define
> DEFINE_DYNAMIC_DEBUG_METADATA(name, fmt) \
> linux/include/linux/dynamic_debug.h:76:
> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \
> linux/include/linux/dynamic_debug.h:78:
> __dynamic_pr_debug(&descriptor, pr_fmt(fmt), \
> linux/include/linux/dynamic_debug.h:84:
> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \
> linux/include/linux/dynamic_debug.h:92:
> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \
> linux/include/linux/dynamic_debug.h:101:
> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, \
>
> Can't say which one is preferred here.
>
looks like device.h is preferred or used in the sources, but this does
not fix the issue here.
sth. wrong with dev_dbg_ratelimited()?
- sedat -
On Wed, Aug 28, 2013 at 12:29 PM, Sedat Dilek <[email protected]> wrote:
> On Wed, Aug 28, 2013 at 11:56 AM, Sedat Dilek <[email protected]> wrote:
>> On Wed, Aug 28, 2013 at 11:49 AM, Sedat Dilek <[email protected]> wrote:
>>> Hi all,
>>>
>>> Changes since 20130827:
>>>
>>> The f2fs tree lost its build failure.
>>>
>>> The md tree gained a conflict against the arm tree.
>>>
>>> The libata tree lost its build failure.
>>>
>>> The spi tree lost its build failure.
>>>
>>> The arm-soc tree gained conflicts against the usb tree.
>>>
>>> The dma-mapping tree gained a conflict against the driver-core tree.
>>>
>>> The akpm-current tree gained a conflict against the net tree.
>>>
>>> ----------------------------------------------------------------------------
>>>
>>> My build here breaks like this:
>>>
>>> CC drivers/usb/host/xhci-ring.o
>>> CC drivers/video/console/softcursor.o
>>> drivers/usb/host/xhci-ring.c: In function 'xhci_queue_intr_tx':
>>> drivers/usb/host/xhci-ring.c:3090:3: error: implicit declaration of
>>> function 'DEFINE_DYNAMIC_DEBUG_METADATA'
>>> [-Werror=implicit-function-declaration]
>>> drivers/usb/host/xhci-ring.c:3090:3: error: 'descriptor' undeclared
>>> (first use in this function)
>>> drivers/usb/host/xhci-ring.c:3090:3: note: each undeclared identifier
>>> is reported only once for each function it appears in
>>> drivers/usb/host/xhci-ring.c:3090:3: error: implicit declaration of
>>> function '__dynamic_pr_debug' [-Werror=implicit-function-declaration]
>>> drivers/usb/host/xhci-ring.c: In function 'xhci_queue_isoc_tx_prepare':
>>> drivers/usb/host/xhci-ring.c:3875:3: error: 'descriptor' undeclared
>>> (first use in this function)
>>> cc1: some warnings being treated as errors
>>> make[5]: *** [drivers/usb/host/xhci-ring.o] Error 1
>>> make[4]: *** [drivers/usb/host] Error 2
>>>
>>> My kernel-config is attached.
>>>
>>
>> Looks like <linux/device.h> or <linux/dynamic_debug.h> is missing.
>>
>> $ egrep -w '__dynamic_pr_debug|DEFINE_DYNAMIC_DEBUG_METADATA' -nr linux/include/
>> linux/include/linux/device.h:1118:
>> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \
>> linux/include/linux/device.h:1121:
>> __dynamic_pr_debug(&descriptor, pr_fmt(fmt), \
>> linux/include/linux/dynamic_debug.h:45:int __dynamic_pr_debug(struct
>> _ddebug *descriptor, const char *fmt, ...);
>> linux/include/linux/dynamic_debug.h:63:#define
>> DEFINE_DYNAMIC_DEBUG_METADATA(name, fmt) \
>> linux/include/linux/dynamic_debug.h:76:
>> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \
>> linux/include/linux/dynamic_debug.h:78:
>> __dynamic_pr_debug(&descriptor, pr_fmt(fmt), \
>> linux/include/linux/dynamic_debug.h:84:
>> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \
>> linux/include/linux/dynamic_debug.h:92:
>> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \
>> linux/include/linux/dynamic_debug.h:101:
>> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, \
>>
>> Can't say which one is preferred here.
>>
>
> looks like device.h is preferred or used in the sources, but this does
> not fix the issue here.
> sth. wrong with dev_dbg_ratelimited()?
>
That change seems to cause the problems:
commit 0730d52a86919300a39a2be37f6c140997dfb82f
"xhci:prevent "callbacks suppressed" when debug is not enabled"
- Sedat -
[1] http://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/drivers/usb/host/xhci-ring.c?h=usb-next&id=0730d52a86919300a39a2be37f6c140997dfb82f
On 28/08/13 13:38, Sedat Dilek wrote:
> On Wed, Aug 28, 2013 at 12:29 PM, Sedat Dilek <[email protected]> wrote:
>> On Wed, Aug 28, 2013 at 11:56 AM, Sedat Dilek <[email protected]> wrote:
>>> On Wed, Aug 28, 2013 at 11:49 AM, Sedat Dilek <[email protected]> wrote:
>>>> Hi all,
>>>>
>>>> Changes since 20130827:
>>>>
>>>> The f2fs tree lost its build failure.
>>>>
>>>> The md tree gained a conflict against the arm tree.
>>>>
>>>> The libata tree lost its build failure.
>>>>
>>>> The spi tree lost its build failure.
>>>>
>>>> The arm-soc tree gained conflicts against the usb tree.
>>>>
>>>> The dma-mapping tree gained a conflict against the driver-core tree.
>>>>
>>>> The akpm-current tree gained a conflict against the net tree.
>>>>
>>>> ----------------------------------------------------------------------------
>>>>
>>>> My build here breaks like this:
>>>>
>>>> CC drivers/usb/host/xhci-ring.o
>>>> CC drivers/video/console/softcursor.o
>>>> drivers/usb/host/xhci-ring.c: In function 'xhci_queue_intr_tx':
>>>> drivers/usb/host/xhci-ring.c:3090:3: error: implicit declaration of
>>>> function 'DEFINE_DYNAMIC_DEBUG_METADATA'
>>>> [-Werror=implicit-function-declaration]
>>>> drivers/usb/host/xhci-ring.c:3090:3: error: 'descriptor' undeclared
>>>> (first use in this function)
>>>> drivers/usb/host/xhci-ring.c:3090:3: note: each undeclared identifier
>>>> is reported only once for each function it appears in
>>>> drivers/usb/host/xhci-ring.c:3090:3: error: implicit declaration of
>>>> function '__dynamic_pr_debug' [-Werror=implicit-function-declaration]
>>>> drivers/usb/host/xhci-ring.c: In function 'xhci_queue_isoc_tx_prepare':
>>>> drivers/usb/host/xhci-ring.c:3875:3: error: 'descriptor' undeclared
>>>> (first use in this function)
>>>> cc1: some warnings being treated as errors
>>>> make[5]: *** [drivers/usb/host/xhci-ring.o] Error 1
>>>> make[4]: *** [drivers/usb/host] Error 2
>>>>
>>>> My kernel-config is attached.
>>>>
>>> Looks like <linux/device.h> or <linux/dynamic_debug.h> is missing.
>>>
>>> $ egrep -w '__dynamic_pr_debug|DEFINE_DYNAMIC_DEBUG_METADATA' -nr linux/include/
>>> linux/include/linux/device.h:1118:
>>> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \
>>> linux/include/linux/device.h:1121:
>>> __dynamic_pr_debug(&descriptor, pr_fmt(fmt), \
>>> linux/include/linux/dynamic_debug.h:45:int __dynamic_pr_debug(struct
>>> _ddebug *descriptor, const char *fmt, ...);
>>> linux/include/linux/dynamic_debug.h:63:#define
>>> DEFINE_DYNAMIC_DEBUG_METADATA(name, fmt) \
>>> linux/include/linux/dynamic_debug.h:76:
>>> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \
>>> linux/include/linux/dynamic_debug.h:78:
>>> __dynamic_pr_debug(&descriptor, pr_fmt(fmt), \
>>> linux/include/linux/dynamic_debug.h:84:
>>> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \
>>> linux/include/linux/dynamic_debug.h:92:
>>> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \
>>> linux/include/linux/dynamic_debug.h:101:
>>> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, \
>>>
>>> Can't say which one is preferred here.
>>>
>> looks like device.h is preferred or used in the sources, but this does
>> not fix the issue here.
>> sth. wrong with dev_dbg_ratelimited()?
>>
> That change seems to cause the problems:
>
> commit 0730d52a86919300a39a2be37f6c140997dfb82f
> "xhci:prevent "callbacks suppressed" when debug is not enabled"
>
> - Sedat -
>
> [1] http://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/drivers/usb/host/xhci-ring.c?h=usb-next&id=0730d52a86919300a39a2be37f6c140997dfb82f
>
Hello,
[PATCHv2 1/2] was not applied before.
I pointed this out few hours ago...
- Dmitry
On Wed, Aug 28, 2013 at 12:43 PM, Dmitry Kasatkin
<[email protected]> wrote:
> On 28/08/13 13:38, Sedat Dilek wrote:
>> On Wed, Aug 28, 2013 at 12:29 PM, Sedat Dilek <[email protected]> wrote:
>>> On Wed, Aug 28, 2013 at 11:56 AM, Sedat Dilek <[email protected]> wrote:
>>>> On Wed, Aug 28, 2013 at 11:49 AM, Sedat Dilek <[email protected]> wrote:
>>>>> Hi all,
>>>>>
>>>>> Changes since 20130827:
>>>>>
>>>>> The f2fs tree lost its build failure.
>>>>>
>>>>> The md tree gained a conflict against the arm tree.
>>>>>
>>>>> The libata tree lost its build failure.
>>>>>
>>>>> The spi tree lost its build failure.
>>>>>
>>>>> The arm-soc tree gained conflicts against the usb tree.
>>>>>
>>>>> The dma-mapping tree gained a conflict against the driver-core tree.
>>>>>
>>>>> The akpm-current tree gained a conflict against the net tree.
>>>>>
>>>>> ----------------------------------------------------------------------------
>>>>>
>>>>> My build here breaks like this:
>>>>>
>>>>> CC drivers/usb/host/xhci-ring.o
>>>>> CC drivers/video/console/softcursor.o
>>>>> drivers/usb/host/xhci-ring.c: In function 'xhci_queue_intr_tx':
>>>>> drivers/usb/host/xhci-ring.c:3090:3: error: implicit declaration of
>>>>> function 'DEFINE_DYNAMIC_DEBUG_METADATA'
>>>>> [-Werror=implicit-function-declaration]
>>>>> drivers/usb/host/xhci-ring.c:3090:3: error: 'descriptor' undeclared
>>>>> (first use in this function)
>>>>> drivers/usb/host/xhci-ring.c:3090:3: note: each undeclared identifier
>>>>> is reported only once for each function it appears in
>>>>> drivers/usb/host/xhci-ring.c:3090:3: error: implicit declaration of
>>>>> function '__dynamic_pr_debug' [-Werror=implicit-function-declaration]
>>>>> drivers/usb/host/xhci-ring.c: In function 'xhci_queue_isoc_tx_prepare':
>>>>> drivers/usb/host/xhci-ring.c:3875:3: error: 'descriptor' undeclared
>>>>> (first use in this function)
>>>>> cc1: some warnings being treated as errors
>>>>> make[5]: *** [drivers/usb/host/xhci-ring.o] Error 1
>>>>> make[4]: *** [drivers/usb/host] Error 2
>>>>>
>>>>> My kernel-config is attached.
>>>>>
>>>> Looks like <linux/device.h> or <linux/dynamic_debug.h> is missing.
>>>>
>>>> $ egrep -w '__dynamic_pr_debug|DEFINE_DYNAMIC_DEBUG_METADATA' -nr linux/include/
>>>> linux/include/linux/device.h:1118:
>>>> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \
>>>> linux/include/linux/device.h:1121:
>>>> __dynamic_pr_debug(&descriptor, pr_fmt(fmt), \
>>>> linux/include/linux/dynamic_debug.h:45:int __dynamic_pr_debug(struct
>>>> _ddebug *descriptor, const char *fmt, ...);
>>>> linux/include/linux/dynamic_debug.h:63:#define
>>>> DEFINE_DYNAMIC_DEBUG_METADATA(name, fmt) \
>>>> linux/include/linux/dynamic_debug.h:76:
>>>> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \
>>>> linux/include/linux/dynamic_debug.h:78:
>>>> __dynamic_pr_debug(&descriptor, pr_fmt(fmt), \
>>>> linux/include/linux/dynamic_debug.h:84:
>>>> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \
>>>> linux/include/linux/dynamic_debug.h:92:
>>>> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \
>>>> linux/include/linux/dynamic_debug.h:101:
>>>> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, \
>>>>
>>>> Can't say which one is preferred here.
>>>>
>>> looks like device.h is preferred or used in the sources, but this does
>>> not fix the issue here.
>>> sth. wrong with dev_dbg_ratelimited()?
>>>
>> That change seems to cause the problems:
>>
>> commit 0730d52a86919300a39a2be37f6c140997dfb82f
>> "xhci:prevent "callbacks suppressed" when debug is not enabled"
>>
>> - Sedat -
>>
>> [1] http://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/drivers/usb/host/xhci-ring.c?h=usb-next&id=0730d52a86919300a39a2be37f6c140997dfb82f
>>
> Hello,
>
> [PATCHv2 1/2] was not applied before.
> I pointed this out few hours ago...
>
> - Dmitry
>
Yupp, just read it a few seconds ago.
Where is that whatever 2nd fix?
- Sedat -
[1] http://marc.info/?l=linux-usb&m=137767590629869&w=2
On Wed, Aug 28, 2013 at 12:46 PM, Sedat Dilek <[email protected]> wrote:
> On Wed, Aug 28, 2013 at 12:43 PM, Dmitry Kasatkin
> <[email protected]> wrote:
>> On 28/08/13 13:38, Sedat Dilek wrote:
>>> On Wed, Aug 28, 2013 at 12:29 PM, Sedat Dilek <[email protected]> wrote:
>>>> On Wed, Aug 28, 2013 at 11:56 AM, Sedat Dilek <[email protected]> wrote:
>>>>> On Wed, Aug 28, 2013 at 11:49 AM, Sedat Dilek <[email protected]> wrote:
>>>>>> Hi all,
>>>>>>
>>>>>> Changes since 20130827:
>>>>>>
>>>>>> The f2fs tree lost its build failure.
>>>>>>
>>>>>> The md tree gained a conflict against the arm tree.
>>>>>>
>>>>>> The libata tree lost its build failure.
>>>>>>
>>>>>> The spi tree lost its build failure.
>>>>>>
>>>>>> The arm-soc tree gained conflicts against the usb tree.
>>>>>>
>>>>>> The dma-mapping tree gained a conflict against the driver-core tree.
>>>>>>
>>>>>> The akpm-current tree gained a conflict against the net tree.
>>>>>>
>>>>>> ----------------------------------------------------------------------------
>>>>>>
>>>>>> My build here breaks like this:
>>>>>>
>>>>>> CC drivers/usb/host/xhci-ring.o
>>>>>> CC drivers/video/console/softcursor.o
>>>>>> drivers/usb/host/xhci-ring.c: In function 'xhci_queue_intr_tx':
>>>>>> drivers/usb/host/xhci-ring.c:3090:3: error: implicit declaration of
>>>>>> function 'DEFINE_DYNAMIC_DEBUG_METADATA'
>>>>>> [-Werror=implicit-function-declaration]
>>>>>> drivers/usb/host/xhci-ring.c:3090:3: error: 'descriptor' undeclared
>>>>>> (first use in this function)
>>>>>> drivers/usb/host/xhci-ring.c:3090:3: note: each undeclared identifier
>>>>>> is reported only once for each function it appears in
>>>>>> drivers/usb/host/xhci-ring.c:3090:3: error: implicit declaration of
>>>>>> function '__dynamic_pr_debug' [-Werror=implicit-function-declaration]
>>>>>> drivers/usb/host/xhci-ring.c: In function 'xhci_queue_isoc_tx_prepare':
>>>>>> drivers/usb/host/xhci-ring.c:3875:3: error: 'descriptor' undeclared
>>>>>> (first use in this function)
>>>>>> cc1: some warnings being treated as errors
>>>>>> make[5]: *** [drivers/usb/host/xhci-ring.o] Error 1
>>>>>> make[4]: *** [drivers/usb/host] Error 2
>>>>>>
>>>>>> My kernel-config is attached.
>>>>>>
>>>>> Looks like <linux/device.h> or <linux/dynamic_debug.h> is missing.
>>>>>
>>>>> $ egrep -w '__dynamic_pr_debug|DEFINE_DYNAMIC_DEBUG_METADATA' -nr linux/include/
>>>>> linux/include/linux/device.h:1118:
>>>>> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \
>>>>> linux/include/linux/device.h:1121:
>>>>> __dynamic_pr_debug(&descriptor, pr_fmt(fmt), \
>>>>> linux/include/linux/dynamic_debug.h:45:int __dynamic_pr_debug(struct
>>>>> _ddebug *descriptor, const char *fmt, ...);
>>>>> linux/include/linux/dynamic_debug.h:63:#define
>>>>> DEFINE_DYNAMIC_DEBUG_METADATA(name, fmt) \
>>>>> linux/include/linux/dynamic_debug.h:76:
>>>>> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \
>>>>> linux/include/linux/dynamic_debug.h:78:
>>>>> __dynamic_pr_debug(&descriptor, pr_fmt(fmt), \
>>>>> linux/include/linux/dynamic_debug.h:84:
>>>>> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \
>>>>> linux/include/linux/dynamic_debug.h:92:
>>>>> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \
>>>>> linux/include/linux/dynamic_debug.h:101:
>>>>> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, \
>>>>>
>>>>> Can't say which one is preferred here.
>>>>>
>>>> looks like device.h is preferred or used in the sources, but this does
>>>> not fix the issue here.
>>>> sth. wrong with dev_dbg_ratelimited()?
>>>>
>>> That change seems to cause the problems:
>>>
>>> commit 0730d52a86919300a39a2be37f6c140997dfb82f
>>> "xhci:prevent "callbacks suppressed" when debug is not enabled"
>>>
>>> - Sedat -
>>>
>>> [1] http://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/drivers/usb/host/xhci-ring.c?h=usb-next&id=0730d52a86919300a39a2be37f6c140997dfb82f
>>>
>> Hello,
>>
>> [PATCHv2 1/2] was not applied before.
>> I pointed this out few hours ago...
>>
>> - Dmitry
>>
>
> Yupp, just read it a few seconds ago.
>
> Where is that whatever 2nd fix?
>
> - Sedat -
>
> [1] http://marc.info/?l=linux-usb&m=137767590629869&w=2
Was 1/2 sent to linux-usb, too?
I found your patch in the linux-kernel offline mail-archives.
[PATCHv2 1/2] dev-core: fix build break when DEBUG is enabled
- Sedat -
http://marc.info/?l=linux-kernel&m=137761487111748&w=2
On 28/08/13 13:46, Sedat Dilek wrote:
> On Wed, Aug 28, 2013 at 12:43 PM, Dmitry Kasatkin
> <[email protected]> wrote:
>> On 28/08/13 13:38, Sedat Dilek wrote:
>>> On Wed, Aug 28, 2013 at 12:29 PM, Sedat Dilek <[email protected]> wrote:
>>>> On Wed, Aug 28, 2013 at 11:56 AM, Sedat Dilek <[email protected]> wrote:
>>>>> On Wed, Aug 28, 2013 at 11:49 AM, Sedat Dilek <[email protected]> wrote:
>>>>>> Hi all,
>>>>>>
>>>>>> Changes since 20130827:
>>>>>>
>>>>>> The f2fs tree lost its build failure.
>>>>>>
>>>>>> The md tree gained a conflict against the arm tree.
>>>>>>
>>>>>> The libata tree lost its build failure.
>>>>>>
>>>>>> The spi tree lost its build failure.
>>>>>>
>>>>>> The arm-soc tree gained conflicts against the usb tree.
>>>>>>
>>>>>> The dma-mapping tree gained a conflict against the driver-core tree.
>>>>>>
>>>>>> The akpm-current tree gained a conflict against the net tree.
>>>>>>
>>>>>> ----------------------------------------------------------------------------
>>>>>>
>>>>>> My build here breaks like this:
>>>>>>
>>>>>> CC drivers/usb/host/xhci-ring.o
>>>>>> CC drivers/video/console/softcursor.o
>>>>>> drivers/usb/host/xhci-ring.c: In function 'xhci_queue_intr_tx':
>>>>>> drivers/usb/host/xhci-ring.c:3090:3: error: implicit declaration of
>>>>>> function 'DEFINE_DYNAMIC_DEBUG_METADATA'
>>>>>> [-Werror=implicit-function-declaration]
>>>>>> drivers/usb/host/xhci-ring.c:3090:3: error: 'descriptor' undeclared
>>>>>> (first use in this function)
>>>>>> drivers/usb/host/xhci-ring.c:3090:3: note: each undeclared identifier
>>>>>> is reported only once for each function it appears in
>>>>>> drivers/usb/host/xhci-ring.c:3090:3: error: implicit declaration of
>>>>>> function '__dynamic_pr_debug' [-Werror=implicit-function-declaration]
>>>>>> drivers/usb/host/xhci-ring.c: In function 'xhci_queue_isoc_tx_prepare':
>>>>>> drivers/usb/host/xhci-ring.c:3875:3: error: 'descriptor' undeclared
>>>>>> (first use in this function)
>>>>>> cc1: some warnings being treated as errors
>>>>>> make[5]: *** [drivers/usb/host/xhci-ring.o] Error 1
>>>>>> make[4]: *** [drivers/usb/host] Error 2
>>>>>>
>>>>>> My kernel-config is attached.
>>>>>>
>>>>> Looks like <linux/device.h> or <linux/dynamic_debug.h> is missing.
>>>>>
>>>>> $ egrep -w '__dynamic_pr_debug|DEFINE_DYNAMIC_DEBUG_METADATA' -nr linux/include/
>>>>> linux/include/linux/device.h:1118:
>>>>> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \
>>>>> linux/include/linux/device.h:1121:
>>>>> __dynamic_pr_debug(&descriptor, pr_fmt(fmt), \
>>>>> linux/include/linux/dynamic_debug.h:45:int __dynamic_pr_debug(struct
>>>>> _ddebug *descriptor, const char *fmt, ...);
>>>>> linux/include/linux/dynamic_debug.h:63:#define
>>>>> DEFINE_DYNAMIC_DEBUG_METADATA(name, fmt) \
>>>>> linux/include/linux/dynamic_debug.h:76:
>>>>> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \
>>>>> linux/include/linux/dynamic_debug.h:78:
>>>>> __dynamic_pr_debug(&descriptor, pr_fmt(fmt), \
>>>>> linux/include/linux/dynamic_debug.h:84:
>>>>> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \
>>>>> linux/include/linux/dynamic_debug.h:92:
>>>>> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \
>>>>> linux/include/linux/dynamic_debug.h:101:
>>>>> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, \
>>>>>
>>>>> Can't say which one is preferred here.
>>>>>
>>>> looks like device.h is preferred or used in the sources, but this does
>>>> not fix the issue here.
>>>> sth. wrong with dev_dbg_ratelimited()?
>>>>
>>> That change seems to cause the problems:
>>>
>>> commit 0730d52a86919300a39a2be37f6c140997dfb82f
>>> "xhci:prevent "callbacks suppressed" when debug is not enabled"
>>>
>>> - Sedat -
>>>
>>> [1] http://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/drivers/usb/host/xhci-ring.c?h=usb-next&id=0730d52a86919300a39a2be37f6c140997dfb82f
>>>
>> Hello,
>>
>> [PATCHv2 1/2] was not applied before.
>> I pointed this out few hours ago...
>>
>> - Dmitry
>>
> Yupp, just read it a few seconds ago.
>
> Where is that whatever 2nd fix?
>
> - Sedat -
>
> [1] http://marc.info/?l=linux-usb&m=137767590629869&w=2
>
1/2 - was not applied
https://patchwork.kernel.org/patch/2850217/
2/2 - this one was applied
https://patchwork.kernel.org/patch/2850218/
- Dmitry
On Wed, Aug 28, 2013 at 12:53 PM, Dmitry Kasatkin
<[email protected]> wrote:
> On 28/08/13 13:46, Sedat Dilek wrote:
>> On Wed, Aug 28, 2013 at 12:43 PM, Dmitry Kasatkin
>> <[email protected]> wrote:
>>> On 28/08/13 13:38, Sedat Dilek wrote:
>>>> On Wed, Aug 28, 2013 at 12:29 PM, Sedat Dilek <[email protected]> wrote:
>>>>> On Wed, Aug 28, 2013 at 11:56 AM, Sedat Dilek <[email protected]> wrote:
>>>>>> On Wed, Aug 28, 2013 at 11:49 AM, Sedat Dilek <[email protected]> wrote:
>>>>>>> Hi all,
>>>>>>>
>>>>>>> Changes since 20130827:
>>>>>>>
>>>>>>> The f2fs tree lost its build failure.
>>>>>>>
>>>>>>> The md tree gained a conflict against the arm tree.
>>>>>>>
>>>>>>> The libata tree lost its build failure.
>>>>>>>
>>>>>>> The spi tree lost its build failure.
>>>>>>>
>>>>>>> The arm-soc tree gained conflicts against the usb tree.
>>>>>>>
>>>>>>> The dma-mapping tree gained a conflict against the driver-core tree.
>>>>>>>
>>>>>>> The akpm-current tree gained a conflict against the net tree.
>>>>>>>
>>>>>>> ----------------------------------------------------------------------------
>>>>>>>
>>>>>>> My build here breaks like this:
>>>>>>>
>>>>>>> CC drivers/usb/host/xhci-ring.o
>>>>>>> CC drivers/video/console/softcursor.o
>>>>>>> drivers/usb/host/xhci-ring.c: In function 'xhci_queue_intr_tx':
>>>>>>> drivers/usb/host/xhci-ring.c:3090:3: error: implicit declaration of
>>>>>>> function 'DEFINE_DYNAMIC_DEBUG_METADATA'
>>>>>>> [-Werror=implicit-function-declaration]
>>>>>>> drivers/usb/host/xhci-ring.c:3090:3: error: 'descriptor' undeclared
>>>>>>> (first use in this function)
>>>>>>> drivers/usb/host/xhci-ring.c:3090:3: note: each undeclared identifier
>>>>>>> is reported only once for each function it appears in
>>>>>>> drivers/usb/host/xhci-ring.c:3090:3: error: implicit declaration of
>>>>>>> function '__dynamic_pr_debug' [-Werror=implicit-function-declaration]
>>>>>>> drivers/usb/host/xhci-ring.c: In function 'xhci_queue_isoc_tx_prepare':
>>>>>>> drivers/usb/host/xhci-ring.c:3875:3: error: 'descriptor' undeclared
>>>>>>> (first use in this function)
>>>>>>> cc1: some warnings being treated as errors
>>>>>>> make[5]: *** [drivers/usb/host/xhci-ring.o] Error 1
>>>>>>> make[4]: *** [drivers/usb/host] Error 2
>>>>>>>
>>>>>>> My kernel-config is attached.
>>>>>>>
>>>>>> Looks like <linux/device.h> or <linux/dynamic_debug.h> is missing.
>>>>>>
>>>>>> $ egrep -w '__dynamic_pr_debug|DEFINE_DYNAMIC_DEBUG_METADATA' -nr linux/include/
>>>>>> linux/include/linux/device.h:1118:
>>>>>> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \
>>>>>> linux/include/linux/device.h:1121:
>>>>>> __dynamic_pr_debug(&descriptor, pr_fmt(fmt), \
>>>>>> linux/include/linux/dynamic_debug.h:45:int __dynamic_pr_debug(struct
>>>>>> _ddebug *descriptor, const char *fmt, ...);
>>>>>> linux/include/linux/dynamic_debug.h:63:#define
>>>>>> DEFINE_DYNAMIC_DEBUG_METADATA(name, fmt) \
>>>>>> linux/include/linux/dynamic_debug.h:76:
>>>>>> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \
>>>>>> linux/include/linux/dynamic_debug.h:78:
>>>>>> __dynamic_pr_debug(&descriptor, pr_fmt(fmt), \
>>>>>> linux/include/linux/dynamic_debug.h:84:
>>>>>> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \
>>>>>> linux/include/linux/dynamic_debug.h:92:
>>>>>> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \
>>>>>> linux/include/linux/dynamic_debug.h:101:
>>>>>> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, \
>>>>>>
>>>>>> Can't say which one is preferred here.
>>>>>>
>>>>> looks like device.h is preferred or used in the sources, but this does
>>>>> not fix the issue here.
>>>>> sth. wrong with dev_dbg_ratelimited()?
>>>>>
>>>> That change seems to cause the problems:
>>>>
>>>> commit 0730d52a86919300a39a2be37f6c140997dfb82f
>>>> "xhci:prevent "callbacks suppressed" when debug is not enabled"
>>>>
>>>> - Sedat -
>>>>
>>>> [1] http://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/drivers/usb/host/xhci-ring.c?h=usb-next&id=0730d52a86919300a39a2be37f6c140997dfb82f
>>>>
>>> Hello,
>>>
>>> [PATCHv2 1/2] was not applied before.
>>> I pointed this out few hours ago...
>>>
>>> - Dmitry
>>>
>> Yupp, just read it a few seconds ago.
>>
>> Where is that whatever 2nd fix?
>>
>> - Sedat -
>>
>> [1] http://marc.info/?l=linux-usb&m=137767590629869&w=2
>>
>
> 1/2 - was not applied
> https://patchwork.kernel.org/patch/2850217/
>
> 2/2 - this one was applied
> https://patchwork.kernel.org/patch/2850218/
>
> - Dmitry
>
Thanks for the patchwork-URLs, it's easier to apply from there.
- Sedat -
On Wed, Aug 28, 2013 at 12:53 PM, Dmitry Kasatkin
<[email protected]> wrote:
> On 28/08/13 13:46, Sedat Dilek wrote:
>> On Wed, Aug 28, 2013 at 12:43 PM, Dmitry Kasatkin
>> <[email protected]> wrote:
>>> On 28/08/13 13:38, Sedat Dilek wrote:
>>>> On Wed, Aug 28, 2013 at 12:29 PM, Sedat Dilek <[email protected]> wrote:
>>>>> On Wed, Aug 28, 2013 at 11:56 AM, Sedat Dilek <[email protected]> wrote:
>>>>>> On Wed, Aug 28, 2013 at 11:49 AM, Sedat Dilek <[email protected]> wrote:
>>>>>>> Hi all,
>>>>>>>
>>>>>>> Changes since 20130827:
>>>>>>>
>>>>>>> The f2fs tree lost its build failure.
>>>>>>>
>>>>>>> The md tree gained a conflict against the arm tree.
>>>>>>>
>>>>>>> The libata tree lost its build failure.
>>>>>>>
>>>>>>> The spi tree lost its build failure.
>>>>>>>
>>>>>>> The arm-soc tree gained conflicts against the usb tree.
>>>>>>>
>>>>>>> The dma-mapping tree gained a conflict against the driver-core tree.
>>>>>>>
>>>>>>> The akpm-current tree gained a conflict against the net tree.
>>>>>>>
>>>>>>> ----------------------------------------------------------------------------
>>>>>>>
>>>>>>> My build here breaks like this:
>>>>>>>
>>>>>>> CC drivers/usb/host/xhci-ring.o
>>>>>>> CC drivers/video/console/softcursor.o
>>>>>>> drivers/usb/host/xhci-ring.c: In function 'xhci_queue_intr_tx':
>>>>>>> drivers/usb/host/xhci-ring.c:3090:3: error: implicit declaration of
>>>>>>> function 'DEFINE_DYNAMIC_DEBUG_METADATA'
>>>>>>> [-Werror=implicit-function-declaration]
>>>>>>> drivers/usb/host/xhci-ring.c:3090:3: error: 'descriptor' undeclared
>>>>>>> (first use in this function)
>>>>>>> drivers/usb/host/xhci-ring.c:3090:3: note: each undeclared identifier
>>>>>>> is reported only once for each function it appears in
>>>>>>> drivers/usb/host/xhci-ring.c:3090:3: error: implicit declaration of
>>>>>>> function '__dynamic_pr_debug' [-Werror=implicit-function-declaration]
>>>>>>> drivers/usb/host/xhci-ring.c: In function 'xhci_queue_isoc_tx_prepare':
>>>>>>> drivers/usb/host/xhci-ring.c:3875:3: error: 'descriptor' undeclared
>>>>>>> (first use in this function)
>>>>>>> cc1: some warnings being treated as errors
>>>>>>> make[5]: *** [drivers/usb/host/xhci-ring.o] Error 1
>>>>>>> make[4]: *** [drivers/usb/host] Error 2
>>>>>>>
>>>>>>> My kernel-config is attached.
>>>>>>>
>>>>>> Looks like <linux/device.h> or <linux/dynamic_debug.h> is missing.
>>>>>>
>>>>>> $ egrep -w '__dynamic_pr_debug|DEFINE_DYNAMIC_DEBUG_METADATA' -nr linux/include/
>>>>>> linux/include/linux/device.h:1118:
>>>>>> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \
>>>>>> linux/include/linux/device.h:1121:
>>>>>> __dynamic_pr_debug(&descriptor, pr_fmt(fmt), \
>>>>>> linux/include/linux/dynamic_debug.h:45:int __dynamic_pr_debug(struct
>>>>>> _ddebug *descriptor, const char *fmt, ...);
>>>>>> linux/include/linux/dynamic_debug.h:63:#define
>>>>>> DEFINE_DYNAMIC_DEBUG_METADATA(name, fmt) \
>>>>>> linux/include/linux/dynamic_debug.h:76:
>>>>>> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \
>>>>>> linux/include/linux/dynamic_debug.h:78:
>>>>>> __dynamic_pr_debug(&descriptor, pr_fmt(fmt), \
>>>>>> linux/include/linux/dynamic_debug.h:84:
>>>>>> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \
>>>>>> linux/include/linux/dynamic_debug.h:92:
>>>>>> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \
>>>>>> linux/include/linux/dynamic_debug.h:101:
>>>>>> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, \
>>>>>>
>>>>>> Can't say which one is preferred here.
>>>>>>
>>>>> looks like device.h is preferred or used in the sources, but this does
>>>>> not fix the issue here.
>>>>> sth. wrong with dev_dbg_ratelimited()?
>>>>>
>>>> That change seems to cause the problems:
>>>>
>>>> commit 0730d52a86919300a39a2be37f6c140997dfb82f
>>>> "xhci:prevent "callbacks suppressed" when debug is not enabled"
>>>>
>>>> - Sedat -
>>>>
>>>> [1] http://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/drivers/usb/host/xhci-ring.c?h=usb-next&id=0730d52a86919300a39a2be37f6c140997dfb82f
>>>>
>>> Hello,
>>>
>>> [PATCHv2 1/2] was not applied before.
>>> I pointed this out few hours ago...
>>>
>>> - Dmitry
>>>
>> Yupp, just read it a few seconds ago.
>>
>> Where is that whatever 2nd fix?
>>
>> - Sedat -
>>
>> [1] http://marc.info/?l=linux-usb&m=137767590629869&w=2
>>
>
> 1/2 - was not applied
> https://patchwork.kernel.org/patch/2850217/
>
Tested-by: Sedat Dilek <[email protected]> (against next-20130828).
- Sedat -
> 2/2 - this one was applied
> https://patchwork.kernel.org/patch/2850218/
>
> - Dmitry
>
On Wed, Aug 28, 2013 at 1:19 PM, Sedat Dilek <[email protected]> wrote:
> On Wed, Aug 28, 2013 at 12:53 PM, Dmitry Kasatkin
> <[email protected]> wrote:
>> On 28/08/13 13:46, Sedat Dilek wrote:
>>> On Wed, Aug 28, 2013 at 12:43 PM, Dmitry Kasatkin
>>> <[email protected]> wrote:
>>>> On 28/08/13 13:38, Sedat Dilek wrote:
>>>>> On Wed, Aug 28, 2013 at 12:29 PM, Sedat Dilek <[email protected]> wrote:
>>>>>> On Wed, Aug 28, 2013 at 11:56 AM, Sedat Dilek <[email protected]> wrote:
>>>>>>> On Wed, Aug 28, 2013 at 11:49 AM, Sedat Dilek <[email protected]> wrote:
>>>>>>>> Hi all,
>>>>>>>>
>>>>>>>> Changes since 20130827:
>>>>>>>>
>>>>>>>> The f2fs tree lost its build failure.
>>>>>>>>
>>>>>>>> The md tree gained a conflict against the arm tree.
>>>>>>>>
>>>>>>>> The libata tree lost its build failure.
>>>>>>>>
>>>>>>>> The spi tree lost its build failure.
>>>>>>>>
>>>>>>>> The arm-soc tree gained conflicts against the usb tree.
>>>>>>>>
>>>>>>>> The dma-mapping tree gained a conflict against the driver-core tree.
>>>>>>>>
>>>>>>>> The akpm-current tree gained a conflict against the net tree.
>>>>>>>>
>>>>>>>> ----------------------------------------------------------------------------
>>>>>>>>
>>>>>>>> My build here breaks like this:
>>>>>>>>
>>>>>>>> CC drivers/usb/host/xhci-ring.o
>>>>>>>> CC drivers/video/console/softcursor.o
>>>>>>>> drivers/usb/host/xhci-ring.c: In function 'xhci_queue_intr_tx':
>>>>>>>> drivers/usb/host/xhci-ring.c:3090:3: error: implicit declaration of
>>>>>>>> function 'DEFINE_DYNAMIC_DEBUG_METADATA'
>>>>>>>> [-Werror=implicit-function-declaration]
>>>>>>>> drivers/usb/host/xhci-ring.c:3090:3: error: 'descriptor' undeclared
>>>>>>>> (first use in this function)
>>>>>>>> drivers/usb/host/xhci-ring.c:3090:3: note: each undeclared identifier
>>>>>>>> is reported only once for each function it appears in
>>>>>>>> drivers/usb/host/xhci-ring.c:3090:3: error: implicit declaration of
>>>>>>>> function '__dynamic_pr_debug' [-Werror=implicit-function-declaration]
>>>>>>>> drivers/usb/host/xhci-ring.c: In function 'xhci_queue_isoc_tx_prepare':
>>>>>>>> drivers/usb/host/xhci-ring.c:3875:3: error: 'descriptor' undeclared
>>>>>>>> (first use in this function)
>>>>>>>> cc1: some warnings being treated as errors
>>>>>>>> make[5]: *** [drivers/usb/host/xhci-ring.o] Error 1
>>>>>>>> make[4]: *** [drivers/usb/host] Error 2
>>>>>>>>
>>>>>>>> My kernel-config is attached.
>>>>>>>>
>>>>>>> Looks like <linux/device.h> or <linux/dynamic_debug.h> is missing.
>>>>>>>
>>>>>>> $ egrep -w '__dynamic_pr_debug|DEFINE_DYNAMIC_DEBUG_METADATA' -nr linux/include/
>>>>>>> linux/include/linux/device.h:1118:
>>>>>>> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \
>>>>>>> linux/include/linux/device.h:1121:
>>>>>>> __dynamic_pr_debug(&descriptor, pr_fmt(fmt), \
>>>>>>> linux/include/linux/dynamic_debug.h:45:int __dynamic_pr_debug(struct
>>>>>>> _ddebug *descriptor, const char *fmt, ...);
>>>>>>> linux/include/linux/dynamic_debug.h:63:#define
>>>>>>> DEFINE_DYNAMIC_DEBUG_METADATA(name, fmt) \
>>>>>>> linux/include/linux/dynamic_debug.h:76:
>>>>>>> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \
>>>>>>> linux/include/linux/dynamic_debug.h:78:
>>>>>>> __dynamic_pr_debug(&descriptor, pr_fmt(fmt), \
>>>>>>> linux/include/linux/dynamic_debug.h:84:
>>>>>>> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \
>>>>>>> linux/include/linux/dynamic_debug.h:92:
>>>>>>> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \
>>>>>>> linux/include/linux/dynamic_debug.h:101:
>>>>>>> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, \
>>>>>>>
>>>>>>> Can't say which one is preferred here.
>>>>>>>
>>>>>> looks like device.h is preferred or used in the sources, but this does
>>>>>> not fix the issue here.
>>>>>> sth. wrong with dev_dbg_ratelimited()?
>>>>>>
>>>>> That change seems to cause the problems:
>>>>>
>>>>> commit 0730d52a86919300a39a2be37f6c140997dfb82f
>>>>> "xhci:prevent "callbacks suppressed" when debug is not enabled"
>>>>>
>>>>> - Sedat -
>>>>>
>>>>> [1] http://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/drivers/usb/host/xhci-ring.c?h=usb-next&id=0730d52a86919300a39a2be37f6c140997dfb82f
>>>>>
>>>> Hello,
>>>>
>>>> [PATCHv2 1/2] was not applied before.
>>>> I pointed this out few hours ago...
>>>>
>>>> - Dmitry
>>>>
>>> Yupp, just read it a few seconds ago.
>>>
>>> Where is that whatever 2nd fix?
>>>
>>> - Sedat -
>>>
>>> [1] http://marc.info/?l=linux-usb&m=137767590629869&w=2
>>>
>>
>> 1/2 - was not applied
>> https://patchwork.kernel.org/patch/2850217/
>>
>
> Tested-by: Sedat Dilek <[email protected]> (against next-20130828).
>
The build-breakage happened here with CONFIG_DYNAMIC_DEBUG=n (see
changelog of Dmitry's 1/2 patch).
$ grep CONFIG_DYNAMIC_DEBUG /boot/config-$(uname -r)
# CONFIG_DYNAMIC_DEBUG is not set
I guess with the "defined(DEBUG)" statement people check for
CONFIG_DEBUG_KERNEL=y.
- Sedat -
> - Sedat -
>
>> 2/2 - this one was applied
>> https://patchwork.kernel.org/patch/2850218/
>>
>> - Dmitry
>>
Please trim your replies.
On Wed, Aug 28, 2013 at 01:53:49PM +0300, Dmitry Kasatkin wrote:
> >>> That change seems to cause the problems:
> >>>
> >>> commit 0730d52a86919300a39a2be37f6c140997dfb82f
> >>> "xhci:prevent "callbacks suppressed" when debug is not enabled"
> >>>
> >>> - Sedat -
> >>>
> >>> [1] http://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/drivers/usb/host/xhci-ring.c?h=usb-next&id=0730d52a86919300a39a2be37f6c140997dfb82f
> >>>
> >> Hello,
> >>
> >> [PATCHv2 1/2] was not applied before.
> >> I pointed this out few hours ago...
So commit 0730d52a86919300a39a2be37f6c140997dfb82f 'xhci:prevent
"callbacks suppressed" when debug is not enabled' needed to be applied
after your first patch? And basically applying that patch alone breaks
the build?
Ugh. Sorry about this. Greg, how do you want to handle this?
Sarah "needs a vacation" Sharp
On Wed, Aug 28, 2013 at 09:59:38AM -0700, Sarah Sharp wrote:
> Please trim your replies.
>
> On Wed, Aug 28, 2013 at 01:53:49PM +0300, Dmitry Kasatkin wrote:
> > >>> That change seems to cause the problems:
> > >>>
> > >>> commit 0730d52a86919300a39a2be37f6c140997dfb82f
> > >>> "xhci:prevent "callbacks suppressed" when debug is not enabled"
> > >>>
> > >>> - Sedat -
> > >>>
> > >>> [1] http://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/drivers/usb/host/xhci-ring.c?h=usb-next&id=0730d52a86919300a39a2be37f6c140997dfb82f
> > >>>
> > >> Hello,
> > >>
> > >> [PATCHv2 1/2] was not applied before.
> > >> I pointed this out few hours ago...
>
> So commit 0730d52a86919300a39a2be37f6c140997dfb82f 'xhci:prevent
> "callbacks suppressed" when debug is not enabled' needed to be applied
> after your first patch? And basically applying that patch alone breaks
> the build?
>
> Ugh. Sorry about this. Greg, how do you want to handle this?
See my other response about your pull request, how about tacking it onto
there?
thanks,
greg k-h
On 28/08/13 19:59, Sarah Sharp wrote:
> Please trim your replies.
>
> On Wed, Aug 28, 2013 at 01:53:49PM +0300, Dmitry Kasatkin wrote:
>>>>> That change seems to cause the problems:
>>>>>
>>>>> commit 0730d52a86919300a39a2be37f6c140997dfb82f
>>>>> "xhci:prevent "callbacks suppressed" when debug is not enabled"
>>>>>
>>>>> - Sedat -
>>>>>
>>>>> [1] http://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/drivers/usb/host/xhci-ring.c?h=usb-next&id=0730d52a86919300a39a2be37f6c140997dfb82f
>>>>>
>>>> Hello,
>>>>
>>>> [PATCHv2 1/2] was not applied before.
>>>> I pointed this out few hours ago...
> So commit 0730d52a86919300a39a2be37f6c140997dfb82f 'xhci:prevent
> "callbacks suppressed" when debug is not enabled' needed to be applied
> after your first patch? And basically applying that patch alone breaks
> the build?
Right...
May be I had to stress it somehow... sorry.
> Ugh. Sorry about this. Greg, how do you want to handle this?
>
> Sarah "needs a vacation" Sharp
>
On Wed, Aug 28, 2013 at 10:18:24AM -0700, Greg Kroah-Hartman wrote:
> On Wed, Aug 28, 2013 at 09:59:38AM -0700, Sarah Sharp wrote:
> > Please trim your replies.
> >
> > On Wed, Aug 28, 2013 at 01:53:49PM +0300, Dmitry Kasatkin wrote:
> > > >>> That change seems to cause the problems:
> > > >>>
> > > >>> commit 0730d52a86919300a39a2be37f6c140997dfb82f
> > > >>> "xhci:prevent "callbacks suppressed" when debug is not enabled"
> > > >>>
> > > >>> - Sedat -
> > > >>>
> > > >>> [1] http://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/drivers/usb/host/xhci-ring.c?h=usb-next&id=0730d52a86919300a39a2be37f6c140997dfb82f
> > > >>>
> > > >> Hello,
> > > >>
> > > >> [PATCHv2 1/2] was not applied before.
> > > >> I pointed this out few hours ago...
> >
> > So commit 0730d52a86919300a39a2be37f6c140997dfb82f 'xhci:prevent
> > "callbacks suppressed" when debug is not enabled' needed to be applied
> > after your first patch? And basically applying that patch alone breaks
> > the build?
> >
> > Ugh. Sorry about this. Greg, how do you want to handle this?
>
> See my other response about your pull request, how about tacking it onto
> there?
Yeah, you could take the first patch and apply it to the usb-next tree.
There would still be a few patches where build breakage occurs, but that
will be there regardless of whether we revert that patch, apply the
first one, and then re-apply the second one. So just applying the first
patch seems to be the better option.
Sarah Sharp
On Wed, Aug 28, 2013 at 7:24 PM, Dmitry Kasatkin <[email protected]> wrote:
> On 28/08/13 19:59, Sarah Sharp wrote:
>> Please trim your replies.
>>
>> On Wed, Aug 28, 2013 at 01:53:49PM +0300, Dmitry Kasatkin wrote:
>>>>>> That change seems to cause the problems:
>>>>>>
>>>>>> commit 0730d52a86919300a39a2be37f6c140997dfb82f
>>>>>> "xhci:prevent "callbacks suppressed" when debug is not enabled"
>>>>>>
>>>>>> - Sedat -
>>>>>>
>>>>>> [1] http://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/drivers/usb/host/xhci-ring.c?h=usb-next&id=0730d52a86919300a39a2be37f6c140997dfb82f
>>>>>>
>>>>> Hello,
>>>>>
>>>>> [PATCHv2 1/2] was not applied before.
>>>>> I pointed this out few hours ago...
>> So commit 0730d52a86919300a39a2be37f6c140997dfb82f 'xhci:prevent
>> "callbacks suppressed" when debug is not enabled' needed to be applied
>> after your first patch? And basically applying that patch alone breaks
>> the build?
>
> Right...
> May be I had to stress it somehow... sorry.
>
Still noone answered me why "drivers/usb/host/xhci-ring.c" does NOT
include <linux/device.h> (dev_info_ratelimited() and other defines).
I am expecting that... even I see...
drivers/usb/host/.xhci-ring.o.cmd:715: include/linux/device.h \
...where I don't know why this happens.
( For me this is a bit more important than """trimming""" my
responses, I keep the history... )
- Sedat -
P.S.: List of includes in xhci-ring.c
$ grep ^'#include' -nr drivers/usb/host/xhci-ring.c
67:#include <linux/scatterlist.h>
68:#include <linux/slab.h>
69:#include "xhci.h"
70:#include "xhci-trace.h"
>> Ugh. Sorry about this. Greg, how do you want to handle this?
>>
>> Sarah "needs a vacation" Sharp
>>
>
>
On Wed, Aug 28, 2013 at 07:39:14PM +0200, Sedat Dilek wrote:
> On Wed, Aug 28, 2013 at 7:24 PM, Dmitry Kasatkin <[email protected]> wrote:
> Still noone answered me why "drivers/usb/host/xhci-ring.c" does NOT
> include <linux/device.h> (dev_info_ratelimited() and other defines).
> I am expecting that... even I see...
>
> drivers/usb/host/.xhci-ring.o.cmd:715: include/linux/device.h \
>
> ...where I don't know why this happens.
>
> ( For me this is a bit more important than """trimming""" my
> responses, I keep the history... )
>
> - Sedat -
>
> P.S.: List of includes in xhci-ring.c
>
> $ grep ^'#include' -nr drivers/usb/host/xhci-ring.c
> 67:#include <linux/scatterlist.h>
> 68:#include <linux/slab.h>
> 69:#include "xhci.h"
> 70:#include "xhci-trace.h"
Because a header that xhci-ring.c uses includes device.h instead.
drivers/usb/host/xhci/xhci-ring.c includes
drivers/usb/host/xhci.h which includes
include/linux/usb.h which includes
include/linux/device.h
All USB host controllers depend on including usb.h, so I don't think
there's a need for the driver to explicitly include device.h.
Sarah Sharp
On Wed, Aug 28, 2013 at 11:15 PM, Sarah Sharp
<[email protected]> wrote:
> On Wed, Aug 28, 2013 at 07:39:14PM +0200, Sedat Dilek wrote:
>> On Wed, Aug 28, 2013 at 7:24 PM, Dmitry Kasatkin <[email protected]> wrote:
>> Still noone answered me why "drivers/usb/host/xhci-ring.c" does NOT
>> include <linux/device.h> (dev_info_ratelimited() and other defines).
>> I am expecting that... even I see...
>>
>> drivers/usb/host/.xhci-ring.o.cmd:715: include/linux/device.h \
>>
>> ...where I don't know why this happens.
>>
>> ( For me this is a bit more important than """trimming""" my
>> responses, I keep the history... )
>>
>> - Sedat -
>>
>> P.S.: List of includes in xhci-ring.c
>>
>> $ grep ^'#include' -nr drivers/usb/host/xhci-ring.c
>> 67:#include <linux/scatterlist.h>
>> 68:#include <linux/slab.h>
>> 69:#include "xhci.h"
>> 70:#include "xhci-trace.h"
>
> Because a header that xhci-ring.c uses includes device.h instead.
>
> drivers/usb/host/xhci/xhci-ring.c includes
> drivers/usb/host/xhci.h which includes
> include/linux/usb.h which includes
> include/linux/device.h
>
> All USB host controllers depend on including usb.h, so I don't think
> there's a need for the driver to explicitly include device.h.
>
Thanks for the explanations.
On the one hand it is a fine thingie to place include-files at one
single place - think of renamed or moved (uapi) include-files.
Looking at xhci-ring.c means for me to dig through 3 or 4 files as
someone not dealing everyday with USB stuff.
What is the effect of CONFIG_DYNAMIC_DEBUG=[y|n] in the affected code?
- Sedat -
P.S.: The forgotten patch is now in usb-next, but I don't see any
credits, coins, gold, platin...
On Thu, Aug 29, 2013 at 10:02:13AM +0200, Sedat Dilek wrote:
> P.S.: The forgotten patch is now in usb-next, but I don't see any
> credits, coins, gold, platin...
Thank you for reporting this. Your name was mentioned in the tag Greg
pulled:
https://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/?h=usb-next&id=ff49896aa45de286f3cbfda800fc92665374546a
As for the non-credit tokens of appreciation, I don't have any gold bars
handy, and I don't do bitcoins, sorry. :)
Sarah Sharp