Fix build error by selecting COREDUMP when X86_32 is selected:
arch/x86/um/built-in.o: In function `elf_core_write_extra_phdrs':
(.text+0x3e62): undefined reference to `dump_emit'
arch/x86/um/built-in.o: In function `elf_core_write_extra_data':
(.text+0x3eef): undefined reference to `dump_emit'
Fixes: 5d2acfc7b974 ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT")
Signed-off-by: Mickaël Salaün <[email protected]>
Cc: Jeff Dike <[email protected]>
Cc: Richard Weinberger <[email protected]>
Cc: Josh Triplett <[email protected]>
Cc: Paul E. McKenney <[email protected]>
Cc: Michal Marek <[email protected]>
Cc: Andrew Morton <[email protected]>
Cc: Linus Torvalds <[email protected]>
---
arch/x86/um/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/um/Kconfig b/arch/x86/um/Kconfig
index ed56a1c4ae73..bb7cd8b38043 100644
--- a/arch/x86/um/Kconfig
+++ b/arch/x86/um/Kconfig
@@ -26,6 +26,7 @@ config X86_32
select CLONE_BACKWARDS
select OLD_SIGSUSPEND3
select OLD_SIGACTION
+ select COREDUMP
config X86_64
def_bool 64BIT
--
2.6.4
On Wed, Dec 23, 2015 at 01:59:13PM +0100, Micka?l Sala?n wrote:
> Fix build error by selecting COREDUMP when X86_32 is selected:
>
> arch/x86/um/built-in.o: In function `elf_core_write_extra_phdrs':
> (.text+0x3e62): undefined reference to `dump_emit'
> arch/x86/um/built-in.o: In function `elf_core_write_extra_data':
> (.text+0x3eef): undefined reference to `dump_emit'
>
> Fixes: 5d2acfc7b974 ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT")
> Signed-off-by: Micka?l Sala?n <[email protected]>
> Cc: Jeff Dike <[email protected]>
> Cc: Richard Weinberger <[email protected]>
> Cc: Josh Triplett <[email protected]>
> Cc: Paul E. McKenney <[email protected]>
> Cc: Michal Marek <[email protected]>
> Cc: Andrew Morton <[email protected]>
> Cc: Linus Torvalds <[email protected]>
I suppose um doesn't care deeply about binary size, but ideally I would
suggest changing arch/x86/um/Makefile to make elfcore.c compiled in when
CONFIG_ELF_CORE rather than CONFIG_BINFMT_ELF.
> arch/x86/um/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/um/Kconfig b/arch/x86/um/Kconfig
> index ed56a1c4ae73..bb7cd8b38043 100644
> --- a/arch/x86/um/Kconfig
> +++ b/arch/x86/um/Kconfig
> @@ -26,6 +26,7 @@ config X86_32
> select CLONE_BACKWARDS
> select OLD_SIGSUSPEND3
> select OLD_SIGACTION
> + select COREDUMP
>
> config X86_64
> def_bool 64BIT
> --
> 2.6.4
>
On 23/12/2015 22:42, Josh Triplett wrote:
> On Wed, Dec 23, 2015 at 01:59:13PM +0100, Micka?l Sala?n wrote:
>> Fix build error by selecting COREDUMP when X86_32 is selected:
>>
>> arch/x86/um/built-in.o: In function `elf_core_write_extra_phdrs':
>> (.text+0x3e62): undefined reference to `dump_emit'
>> arch/x86/um/built-in.o: In function `elf_core_write_extra_data':
>> (.text+0x3eef): undefined reference to `dump_emit'
>>
>> Fixes: 5d2acfc7b974 ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT")
>> Signed-off-by: Micka?l Sala?n <[email protected]>
>> Cc: Jeff Dike <[email protected]>
>> Cc: Richard Weinberger <[email protected]>
>> Cc: Josh Triplett <[email protected]>
>> Cc: Paul E. McKenney <[email protected]>
>> Cc: Michal Marek <[email protected]>
>> Cc: Andrew Morton <[email protected]>
>> Cc: Linus Torvalds <[email protected]>
>
> I suppose um doesn't care deeply about binary size, but ideally I would
> suggest changing arch/x86/um/Makefile to make elfcore.c compiled in when
> CONFIG_ELF_CORE rather than CONFIG_BINFMT_ELF.
That looks better! Since the first patch has been added to the mmots tree (but not yet in mmotm) I'll send a patch update instead of a new one reverting the first. I hope this is OK.
Regards,
Micka?l
On Thu, Dec 24, 2015 at 01:09:45PM +0100, Micka?l Sala?n wrote:
>
> On 23/12/2015 22:42, Josh Triplett wrote:
> > On Wed, Dec 23, 2015 at 01:59:13PM +0100, Micka?l Sala?n wrote:
> >> Fix build error by selecting COREDUMP when X86_32 is selected:
> >>
> >> arch/x86/um/built-in.o: In function `elf_core_write_extra_phdrs':
> >> (.text+0x3e62): undefined reference to `dump_emit'
> >> arch/x86/um/built-in.o: In function `elf_core_write_extra_data':
> >> (.text+0x3eef): undefined reference to `dump_emit'
> >>
> >> Fixes: 5d2acfc7b974 ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT")
> >> Signed-off-by: Micka?l Sala?n <[email protected]>
> >> Cc: Jeff Dike <[email protected]>
> >> Cc: Richard Weinberger <[email protected]>
> >> Cc: Josh Triplett <[email protected]>
> >> Cc: Paul E. McKenney <[email protected]>
> >> Cc: Michal Marek <[email protected]>
> >> Cc: Andrew Morton <[email protected]>
> >> Cc: Linus Torvalds <[email protected]>
> >
> > I suppose um doesn't care deeply about binary size, but ideally I would
> > suggest changing arch/x86/um/Makefile to make elfcore.c compiled in when
> > CONFIG_ELF_CORE rather than CONFIG_BINFMT_ELF.
>
> That looks better! Since the first patch has been added to the mmots tree (but not yet in mmotm) I'll send a patch update instead of a new one reverting the first. I hope this is OK.
-mm regularly replaces patches with newer versions, so that ought to be
fine.
Am 25.12.2015 um 02:26 schrieb Josh Triplett:
> On Thu, Dec 24, 2015 at 01:09:45PM +0100, Micka?l Sala?n wrote:
>>
>> On 23/12/2015 22:42, Josh Triplett wrote:
>>> On Wed, Dec 23, 2015 at 01:59:13PM +0100, Micka?l Sala?n wrote:
>>>> Fix build error by selecting COREDUMP when X86_32 is selected:
>>>>
>>>> arch/x86/um/built-in.o: In function `elf_core_write_extra_phdrs':
>>>> (.text+0x3e62): undefined reference to `dump_emit'
>>>> arch/x86/um/built-in.o: In function `elf_core_write_extra_data':
>>>> (.text+0x3eef): undefined reference to `dump_emit'
>>>>
>>>> Fixes: 5d2acfc7b974 ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT")
>>>> Signed-off-by: Micka?l Sala?n <[email protected]>
>>>> Cc: Jeff Dike <[email protected]>
>>>> Cc: Richard Weinberger <[email protected]>
>>>> Cc: Josh Triplett <[email protected]>
>>>> Cc: Paul E. McKenney <[email protected]>
>>>> Cc: Michal Marek <[email protected]>
>>>> Cc: Andrew Morton <[email protected]>
>>>> Cc: Linus Torvalds <[email protected]>
>>>
>>> I suppose um doesn't care deeply about binary size, but ideally I would
>>> suggest changing arch/x86/um/Makefile to make elfcore.c compiled in when
>>> CONFIG_ELF_CORE rather than CONFIG_BINFMT_ELF.
>>
>> That looks better! Since the first patch has been added to the mmots tree (but not yet in mmotm) I'll send a patch update instead of a new one reverting the first. I hope this is OK.
>
> -mm regularly replaces patches with newer versions, so that ought to be
> fine.
Usually non-trivial UML stuff goes thought me.
As Josh noted, just post an updated version of the patch.
Either me or Andrew will pick it up.
Thanks,
//richard