On Tue, Feb 21, 2017 at 7:11 PM, Stafford Horne <[email protected]> wrote:
> From: Stefan Kristiansson <[email protected]>
>
> Motivation for this is to be able to print the way information
> properly in print_cpuinfo(), instead of hardcoding it to one.
>
Any particular reason not to use generic cacheinfo sysfs infrastructure ?
--
Regards,
Sudeep
On 14/03/17 13:11, Stefan Kristiansson wrote:
> On Tue, Mar 14, 2017 at 12:08:33PM +0000, Sudeep Holla wrote:
>> On Tue, Feb 21, 2017 at 7:11 PM, Stafford Horne <[email protected]> wrote:
>>> From: Stefan Kristiansson <[email protected]>
>>>
>>> Motivation for this is to be able to print the way information
>>> properly in print_cpuinfo(), instead of hardcoding it to one.
>>>
>>
>> Any particular reason not to use generic cacheinfo sysfs infrastructure ?
>>
>
> No reason as far as I can see, the creation of this patch predates the
> generic cacheinfo sysfs infrastructure.
>
> The patch itself doesn't add cache information to cpuinfo though,
> only corrects a bug in the information that is already there.
>
> We should look into exposing the info in the generic cache info sysfs
> and potentially removing the information from cpuinfo.
>
Ah OK, sorry I mistook it as a new addition rather than bug fox.
--
Regards,
Sudeep
On Tue, Mar 14, 2017 at 01:45:24PM +0000, Sudeep Holla wrote:
>
>
> On 14/03/17 13:11, Stefan Kristiansson wrote:
> > On Tue, Mar 14, 2017 at 12:08:33PM +0000, Sudeep Holla wrote:
> >> On Tue, Feb 21, 2017 at 7:11 PM, Stafford Horne <[email protected]> wrote:
> >>> From: Stefan Kristiansson <[email protected]>
> >>>
> >>> Motivation for this is to be able to print the way information
> >>> properly in print_cpuinfo(), instead of hardcoding it to one.
> >>>
> >>
> >> Any particular reason not to use generic cacheinfo sysfs infrastructure ?
> >>
> >
> > No reason as far as I can see, the creation of this patch predates the
> > generic cacheinfo sysfs infrastructure.
> >
> > The patch itself doesn't add cache information to cpuinfo though,
> > only corrects a bug in the information that is already there.
> >
> > We should look into exposing the info in the generic cache info sysfs
> > and potentially removing the information from cpuinfo.
> >
>
> Ah OK, sorry I mistook it as a new addition rather than bug fox.
Hello,
The comment is appreciated I didnt know about the generic cacheinfo
intrstructure to be honest. The simplifications it brings look good, I
will put this on my todo list.
If you want to have a go at patching it in for openrisc it would be
appreciated. :)
-Stafford
On Tue, Mar 14, 2017 at 12:08:33PM +0000, Sudeep Holla wrote:
> On Tue, Feb 21, 2017 at 7:11 PM, Stafford Horne <[email protected]> wrote:
> > From: Stefan Kristiansson <[email protected]>
> >
> > Motivation for this is to be able to print the way information
> > properly in print_cpuinfo(), instead of hardcoding it to one.
> >
>
> Any particular reason not to use generic cacheinfo sysfs infrastructure ?
>
No reason as far as I can see, the creation of this patch predates the
generic cacheinfo sysfs infrastructure.
The patch itself doesn't add cache information to cpuinfo though,
only corrects a bug in the information that is already there.
We should look into exposing the info in the generic cache info sysfs
and potentially removing the information from cpuinfo.
Stefan
On 14/03/17 14:09, Stafford Horne wrote:
> On Tue, Mar 14, 2017 at 01:45:24PM +0000, Sudeep Holla wrote:
>>
>>
>> On 14/03/17 13:11, Stefan Kristiansson wrote:
>>> On Tue, Mar 14, 2017 at 12:08:33PM +0000, Sudeep Holla wrote:
>>>> On Tue, Feb 21, 2017 at 7:11 PM, Stafford Horne <[email protected]> wrote:
>>>>> From: Stefan Kristiansson <[email protected]>
>>>>>
>>>>> Motivation for this is to be able to print the way information
>>>>> properly in print_cpuinfo(), instead of hardcoding it to one.
>>>>>
>>>>
>>>> Any particular reason not to use generic cacheinfo sysfs infrastructure ?
>>>>
>>>
>>> No reason as far as I can see, the creation of this patch predates the
>>> generic cacheinfo sysfs infrastructure.
>>>
>>> The patch itself doesn't add cache information to cpuinfo though,
>>> only corrects a bug in the information that is already there.
>>>
>>> We should look into exposing the info in the generic cache info sysfs
>>> and potentially removing the information from cpuinfo.
>>>
>>
>> Ah OK, sorry I mistook it as a new addition rather than bug fox.
>
> Hello,
>
> The comment is appreciated I didnt know about the generic cacheinfo
> intrstructure to be honest. The simplifications it brings look good, I
> will put this on my todo list.
>
Thanks.
> If you want to have a go at patching it in for openrisc it would be
> appreciated. :)
>
Sure I can try if I get time before someone else does that ;)
--
Regards,
Sudeep